From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ED54C388F9 for ; Sun, 8 Nov 2020 04:54:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A45A420897 for ; Sun, 8 Nov 2020 04:54:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D4/QPIBA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A45A420897 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D2C426B0068; Sat, 7 Nov 2020 23:54:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CDC3A6B006C; Sat, 7 Nov 2020 23:54:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCB826B006E; Sat, 7 Nov 2020 23:54:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id 8D9F56B0068 for ; Sat, 7 Nov 2020 23:54:18 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1A966181AEF00 for ; Sun, 8 Nov 2020 04:54:18 +0000 (UTC) X-FDA: 77460034596.26.eye87_070401f272e1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 0024B1804B656 for ; Sun, 8 Nov 2020 04:54:17 +0000 (UTC) X-HE-Tag: eye87_070401f272e1 X-Filterd-Recvd-Size: 4606 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Sun, 8 Nov 2020 04:54:17 +0000 (UTC) Received: by mail-pf1-f195.google.com with SMTP id w14so2449744pfd.7 for ; Sat, 07 Nov 2020 20:54:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=F1OfcUiT8PCqG13bu2Daw7S9aBJED13dekqt0FlSaVI=; b=D4/QPIBAxCnbpRD0Lqy33tmcROAoXd7FnBEzg+ti4r0y08uco04p3tTGZlsXU42KNl bj8M99/gF9xlCReURvUregYPOfO1X4jRl4xxYGBfljuMv9oOHzXJF6BcjVBI3xK58S0A jiJnUNIsIuENzdXeZ3Qwyx91L2vkVj2P9KNIp+PYyINP0Ex5KywYwXV1vzm+2zE9XqCk 1fl28ovs5AAHLjcSkEGcRPbI9lwX44l6RBR/l6H5wjqP+b5VW4IuXOIDlpx8UnoDwamy 0z4+itJfsam2DOV8GAHVjKJyz47jq/JAfpXd6JXiTYBnSILeqx3NIQsS9BOysBrdHcKz 2phw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=F1OfcUiT8PCqG13bu2Daw7S9aBJED13dekqt0FlSaVI=; b=JXE2fditcZpds9EM16VKguuQaD+k/GvsaE15Pw0JmmrYQMdGYbeB2YSzXR93QwrNBG VCWJt5v2cYc9lBX2k9ISqs1EBaR+xrDqmJ/+PXnT1OMLhydkKWGxmwSZFOTNIZ69MpG5 UzAqdLxj6KK7tkCnDMnDUpb4ppCkvvtugLcA/OHtRSI3a1DOe8Ack5lN6v+whXykPRR6 AsASB6mDSn1fCbkya/+bPM3HSEBrk4GKwTnybnRmNZ37lD5sPNiwUfSX5Q0C/ED7E0tB IriaKZ7skxWhL5x9HjQgV7NWc9aS/6oqraL/AunQL10okwzfCI0jmPcKo9VVp1cebSON M36Q== X-Gm-Message-State: AOAM532eafIpsB72ONTyHh4yDa2HTo91BF/3ZAxYbnoIczp+o2ZGxKAi abYuON9Bip/yv0xrHTwp/Sw= X-Google-Smtp-Source: ABdhPJzr0We/2944Bv+0jqST+vRUDGQ0+D651QrDBbeZE29JDnUkIiysug8N4SqQ0Qfh1jHJS+VPlA== X-Received: by 2002:a63:d54c:: with SMTP id v12mr8343961pgi.429.1604811256496; Sat, 07 Nov 2020 20:54:16 -0800 (PST) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id y10sm12205852pjr.2.2020.11.07.20.54.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Nov 2020 20:54:15 -0800 (PST) Subject: Re: [PATCH] mm/zsmalloc: include sparsemem.h for MAX_PHYSMEM_BITS To: Stefan Agner , Andrew Morton Cc: minchan@kernel.org, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, sjenning@linux.vnet.ibm.com, gregkh@linuxfoundation.org, arnd@arndb.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20201107165645.1b139b595b6b64feaca61bcb@linux-foundation.org> From: Florian Fainelli Message-ID: <29cb13a4-e10d-a394-3c00-1d7721a2dc0a@gmail.com> Date: Sat, 7 Nov 2020 20:54:13 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/7/2020 5:16 PM, Stefan Agner wrote: > On 2020-11-08 01:56, Andrew Morton wrote: >> On Sat, 7 Nov 2020 16:22:06 +0100 Stefan Agner wrote: >> >>> Most architectures define MAX_PHYSMEM_BITS in asm/sparsemem.h and don't >>> include it in asm/pgtable.h. Include asm/sparsemem.h directly to get >>> the MAX_PHYSMEM_BITS define on all architectures. >>> >>> This fixes a crash when accessing zram on 32-bit ARM platform with LPAE and >>> more than 4GB of memory: >>> Unable to handle kernel NULL pointer dereference at virtual address 00000000 >> >> Mysterious. Presumably without this include, some compilation unit is >> picking up the wrong value of MAX_PHYSMEM_BITS? But I couldn't >> actually see where/how this occurs. Can you please explain further? > > Not sure if I got that right, but from what I understand if > MAX_PHYSMEM_BITS is not set in mm/zsmalloc.c it will set > MAX_PHYSMEM_BITS to BITS_PER_LONG. And this is 32-bit, too short when > LPAE is in use... You should probably include this in your commit message since that is describing the bug and then your fix makes complete sense. -- Florian