From: Joe Perches <joe@perches.com>
To: Nathan Chancellor <natechancellor@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>
Cc: Nathan Huckleberry <nhuck@google.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: Re: [PATCH v2] kbuild: Change fallthrough comments to attributes
Date: Tue, 13 Aug 2019 00:43:12 -0700 [thread overview]
Message-ID: <2a6c7952793a7973c7edc6b2c44ac3c2587562fd.camel@perches.com> (raw)
In-Reply-To: <3078e553a777976655f72718d088791363544caa.camel@perches.com>
On Tue, 2019-08-13 at 00:04 -0700, Joe Perches wrote:
> On Mon, 2019-08-12 at 23:33 -0700, Nathan Chancellor wrote:
[]
> > a disagreement between GCC and Clang on
> > emitting a warning when falling through to a case statement that is
> > either the last one and empty or simply breaks..
[]
> > I personally think that GCC is right and Clang should adapt but I don't
> > know enough about the Clang codebase to know how feasible this is.
>
> I think gcc is wrong here and code like
>
> switch (foo) {
> case 1:
> bar = 1;
> default:
> break;
> }
>
> should emit a fallthrough warning.
btw: I just filed https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91432
next prev parent reply other threads:[~2019-08-13 7:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 21:47 [PATCH] kbuild: Change fallthrough comments to attributes Nathan Huckleberry
2019-08-12 22:14 ` [PATCH v2] " Nathan Huckleberry
2019-08-12 22:40 ` Joe Perches
2019-08-12 23:11 ` Nick Desaulniers
2019-08-12 23:23 ` Joe Perches
2019-08-13 6:33 ` Nathan Chancellor
2019-08-13 7:04 ` Joe Perches
2019-08-13 7:43 ` Joe Perches [this message]
2019-08-13 9:48 ` David Laight
2019-08-12 23:06 ` [PATCH] " Nick Desaulniers
2019-08-13 7:15 ` Christoph Hellwig
2019-08-15 21:07 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a6c7952793a7973c7edc6b2c44ac3c2587562fd.camel@perches.com \
--to=joe@perches.com \
--cc=clang-built-linux@googlegroups.com \
--cc=gustavo@embeddedor.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=michal.lkml@markovi.net \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=nhuck@google.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).