From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB31BC433F5 for ; Tue, 15 Feb 2022 11:22:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E93766B0078; Tue, 15 Feb 2022 06:22:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E443E6B007B; Tue, 15 Feb 2022 06:22:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0B196B007D; Tue, 15 Feb 2022 06:22:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0006.hostedemail.com [216.40.44.6]) by kanga.kvack.org (Postfix) with ESMTP id BE4D36B0078 for ; Tue, 15 Feb 2022 06:22:53 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6EEE5181AC9C6 for ; Tue, 15 Feb 2022 11:22:53 +0000 (UTC) X-FDA: 79144777026.28.5C61A40 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf31.hostedemail.com (Postfix) with ESMTP id E77D020004 for ; Tue, 15 Feb 2022 11:22:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644924172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9XqhwGYN094qwt4YHsGwrAuGrVX5AKcgWAioi8UK100=; b=bFeoQegVChoIeBI4F2Qm4zK3okFp3q8ZaKfKwjtSHBV7QAGUUwfMu8BcovRhmrkN+qJcld 3FZhkErH4YGxRbWPMpTe5oVbBN80to8rZRh+PpMbUNWOjQP4wClTW+pdOpHjxISOsWW8Q9 4mqQcNeiy1tg9X3YfXJPC4WxX4r6p1E= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-379-cqc0stmbPMyAmT3hNwOkPA-1; Tue, 15 Feb 2022 06:22:51 -0500 X-MC-Unique: cqc0stmbPMyAmT3hNwOkPA-1 Received: by mail-wr1-f70.google.com with SMTP id j8-20020adfa548000000b001e33074ac51so8266019wrb.11 for ; Tue, 15 Feb 2022 03:22:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=9XqhwGYN094qwt4YHsGwrAuGrVX5AKcgWAioi8UK100=; b=Pq2jHzdF9Zd2ON5pHOO7kyBi90ypOkJbdwstwq0bg2haCNFCgplG1STnMkTbIA2GPP YHnD+B1SuBY4WJ1BtWnPXX9FBF0wK63dSj7dn0Eq2Q4iLvnI7CA1ZRjx2jnK9cRC63J1 2mj94xEULKq7Ph4vMvn9HQfe4dtF6dtM437L7z+ubaFU5AThyiWHF4OoYClOy+MHLKku 2T4nE53GwFmxi6GV5CeaPXnhO9aCuV3yyPN+g8gepkshmAEyCb2zhj27Jf1TH6kYLPG9 yFMY0c8JYg3Zg3TsEkmCMI6iLUDttqtoKL1xmyNyrB98vNMzgs1xJRjkAAH9dwi/Sa41 DF0g== X-Gm-Message-State: AOAM530HWeqXs1d6dc1SmZIhI6wggQRkhWCBgH3/T4k1Ob0fuqXS8rID o3WkyObmqAadcihFo+cp7UakiwyVKXuWhba1bMJDiLuSMfKwk1U4+hpkCmC2xw2R7vvlinhqAwl UbSTBN/2JaA8= X-Received: by 2002:a05:600c:2251:: with SMTP id a17mr2747303wmm.88.1644924170083; Tue, 15 Feb 2022 03:22:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJwcIfVMCEHJLu5xgjU8cUK6l+eYU4b2sEheN2xCNVYgq6X6+sTtzgVQ5eUDpsPRNgauInnZdQ== X-Received: by 2002:a05:600c:2251:: with SMTP id a17mr2747284wmm.88.1644924169809; Tue, 15 Feb 2022 03:22:49 -0800 (PST) Received: from ?IPV6:2003:cb:c70e:3700:9260:2fb2:742d:da3e? (p200300cbc70e370092602fb2742dda3e.dip0.t-ipconnect.de. [2003:cb:c70e:3700:9260:2fb2:742d:da3e]) by smtp.gmail.com with ESMTPSA id d14sm15871286wrv.50.2022.02.15.03.22.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Feb 2022 03:22:49 -0800 (PST) Message-ID: <2a881586-3f5e-c277-f373-a9014d631700@redhat.com> Date: Tue, 15 Feb 2022 12:22:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v2] mm: clean up hwpoison page cache page in fault path To: Rik van Riel , linux-kernel@vger.kernel.org Cc: kernel-team@fb.com, linux-mm@kvack.org, Miaohe Lin , Andrew Morton , Mel Gorman , Johannes Weiner , Matthew Wilcox References: <20220212213740.423efcea@imladris.surriel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220212213740.423efcea@imladris.surriel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E77D020004 X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bFeoQegV; spf=none (imf31.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: et5ayrbfo4qbbmsrm3bu7bxj3h8rr1ng X-HE-Tag: 1644924172-593424 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.02.22 03:37, Rik van Riel wrote: > Sometimes the page offlining code can leave behind a hwpoisoned clean > page cache page. This can lead to programs being killed over and over > and over again as they fault in the hwpoisoned page, get killed, and > then get re-spawned by whatever wanted to run them. Hi Rik, am I correct that you are only talking about soft offlining as triggered from mm/memory-failure.c, not page offlining as in memory offlining mm/memory_hotunplug.c ? Maybe you can clarify that in the patch description, it made me nervous for a second :) -- Thanks, David / dhildenb