From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8082C433F5 for ; Tue, 15 Feb 2022 15:06:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57A6A6B0085; Tue, 15 Feb 2022 10:06:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 54FB78D0001; Tue, 15 Feb 2022 10:06:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CB306B0088; Tue, 15 Feb 2022 10:06:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id 2E8556B0085 for ; Tue, 15 Feb 2022 10:06:13 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id ED8F093D97 for ; Tue, 15 Feb 2022 15:06:12 +0000 (UTC) X-FDA: 79145339784.16.55A7155 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 2A83A4001D for ; Tue, 15 Feb 2022 15:06:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644937571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HfA3vO8+6n1DQao6u/Mr2EuXbzpIlm1ffHmAiLuPWK8=; b=HFHL8jwZqNkMvu8vNowEEo+PgbI4sMcFTqIC9lmii2xRs1PiqkmwcVJKit4gHF3bV3Hdq1 ya9qw4KqyrhYu0b1od1mzjmOKWDfcJ3KNN/ttX+K9xv2R/O3ylQvAWwGnsw52VrWb4ModO Ds84VsBxcg7a9Qt3O7ALF7zuuH+NEHg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-617-nW3VR0FkO0SEeZL7Hg6S_g-1; Tue, 15 Feb 2022 10:06:10 -0500 X-MC-Unique: nW3VR0FkO0SEeZL7Hg6S_g-1 Received: by mail-wr1-f70.google.com with SMTP id h24-20020adfaa98000000b001e33eb81e71so8482875wrc.9 for ; Tue, 15 Feb 2022 07:06:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=HfA3vO8+6n1DQao6u/Mr2EuXbzpIlm1ffHmAiLuPWK8=; b=4TNpr91liUu1BLvAEKiLu0yca2NFYYpE67odjTRxeb6IhTx9rjO3QEXnLl489Vkw/V P7qlBG4hsN+nTJnIfaRMORdZBN4jPrEjqGM9vVOxEconWAjqExS9/Zf1r1P837OwjsDt fQYRKfS839rMwVN8fJOit/A99OrG1ORdVUG9O8lFFoRFpj2Naix4CHH12GvTiwanV+qb cjfGZqogNo1Uzl7V6em68RCIjJ7gtpFajOPUHy7LPCF1JabTECQ6S7E0ghzWq3YlOiUr cYVxArOT1ESGZ+8EJUrpEIYexAd066N6sHR7gRk7+ZnzX6bcwthdLRAVldQJTo2gCqMd om2A== X-Gm-Message-State: AOAM53067IzW9EPaJ+lr9hSn0LAH3MOoIvMVc8oS0gq1ykr+EIp0aM+G wIlZAv2H0GKZQ4S1p8l7lirrBGCp2LofeMHipcnghwlvwK4NYCYQrInqDmXAYqiEGuALAYKyEiH PCEFUh6eJEJY= X-Received: by 2002:a05:6000:2c5:: with SMTP id o5mr3572613wry.130.1644937569077; Tue, 15 Feb 2022 07:06:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJzGuhi4OibgJoa3W0FK7ohMmfc7Hmn4KSzRw7AVu1OMbfqzr7TxKkeEcpypUNuJd+1KYhk38Q== X-Received: by 2002:a05:6000:2c5:: with SMTP id o5mr3572592wry.130.1644937568834; Tue, 15 Feb 2022 07:06:08 -0800 (PST) Received: from ?IPV6:2003:cb:c70e:3700:9260:2fb2:742d:da3e? (p200300cbc70e370092602fb2742dda3e.dip0.t-ipconnect.de. [2003:cb:c70e:3700:9260:2fb2:742d:da3e]) by smtp.gmail.com with ESMTPSA id s7sm3872048wro.104.2022.02.15.07.06.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Feb 2022 07:06:08 -0800 (PST) Message-ID: <2cc44d0d-1ede-daca-30fd-d302f1537dfe@redhat.com> Date: Tue, 15 Feb 2022 16:06:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v2] mm: clean up hwpoison page cache page in fault path To: Rik van Riel , linux-kernel@vger.kernel.org Cc: kernel-team@fb.com, linux-mm@kvack.org, Miaohe Lin , Andrew Morton , Mel Gorman , Johannes Weiner , Matthew Wilcox References: <20220212213740.423efcea@imladris.surriel.com> <2a881586-3f5e-c277-f373-a9014d631700@redhat.com> <63f930e411655a6ad37d4818d0ae19784c82f076.camel@surriel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <63f930e411655a6ad37d4818d0ae19784c82f076.camel@surriel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2A83A4001D X-Stat-Signature: t9f3i6y3mtajnhaboiuk6a999xfqz5bp X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HFHL8jwZ; spf=none (imf27.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1644937571-747443 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.02.22 16:01, Rik van Riel wrote: > On Tue, 2022-02-15 at 12:22 +0100, David Hildenbrand wrote: >> On 13.02.22 03:37, Rik van Riel wrote: >>> Sometimes the page offlining code can leave behind a hwpoisoned >>> clean >>> page cache page. This can lead to programs being killed over and >>> over >>> and over again as they fault in the hwpoisoned page, get killed, >>> and >>> then get re-spawned by whatever wanted to run them. >> >> Hi Rik, >> >> am I correct that you are only talking about soft offlining as >> triggered >> from mm/memory-failure.c, not page offlining as in memory offlining >> mm/memory_hotunplug.c ? > > That is correct in that I am talking only about memory-failure.c, > however the code in memory-failure.c has both hard and soft > offlining modes, and I suppose this patch covers both? > Right, for hwpoison handling there is hard and soft offlining of pages ... maybe "hwpoison page offlining" would be clearer, not sure. Thanks for clarifying! -- Thanks, David / dhildenb