From: David Hildenbrand <david@redhat.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: Mike Rapoport <rppt@linux.ibm.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: reorder memory-hotplug documentation
Date: Wed, 22 May 2019 09:29:21 +0200 [thread overview]
Message-ID: <2cd2bbde-e929-d730-30f3-a9419072a788@redhat.com> (raw)
In-Reply-To: <20190521161101.GA2372@linux>
On 21.05.19 18:11, Oscar Salvador wrote:
> On Tue, May 21, 2019 at 12:41:50PM +0200, David Hildenbrand wrote:
>>> +Future Work
>>> +===========
>>> +
>>> + - allowing memory hot-add to ZONE_MOVABLE. maybe we need some switch like
>>> + sysctl or new control file.
>>
>> ... that already works if I am not completely missing the point here
>
> It does.
>
>>> + - support HugeTLB page migration and offlining.
>>
>> ... I remember that Oscar was doing something in that area, Oscar?
>
> Yes, in general offlinining on hugetlb pages was already working, but we did not
> allow to offline 1GB-hugetlb pages on x86_64.
> I removed that limitation with
> ("commit: 10eeadf3045c mm,memory_hotplug: unlock 1GB-hugetlb on x86_64") , so now
> offlining on hugetlb pages should be fully operative.
>
>> I'd vote for removing the future work part, this is pretty outdated.
>
> Instead of removing it, I would rather make it consistent with the present.
> E.g:
>
> - Move page handling from memory-hotremove to offline stage
> - Enable a way to allocate vmemmap pages from hot-added memory
> etc.
>
>
Fair enough, but at least the current content is absolutely useless and
confusing/misleading.
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2019-05-22 7:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 8:23 [PATCH] docs: reorder memory-hotplug documentation Mike Rapoport
2019-05-21 10:41 ` David Hildenbrand
2019-05-21 16:00 ` Mike Rapoport
2019-05-21 16:11 ` Oscar Salvador
2019-05-22 7:29 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cd2bbde-e929-d730-30f3-a9419072a788@redhat.com \
--to=david@redhat.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).