From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5B87C43219 for ; Wed, 23 Nov 2022 18:18:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E2896B0073; Wed, 23 Nov 2022 13:18:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5914F6B0074; Wed, 23 Nov 2022 13:18:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4322E6B0075; Wed, 23 Nov 2022 13:18:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 345416B0073 for ; Wed, 23 Nov 2022 13:18:50 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 11328A0166 for ; Wed, 23 Nov 2022 18:18:50 +0000 (UTC) X-FDA: 80165518020.04.677FAFD Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf26.hostedemail.com (Postfix) with ESMTP id 75487140013 for ; Wed, 23 Nov 2022 18:18:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669227528; x=1700763528; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=E89CZqbaoYjUKLoTevrvJoCvfEz61O1bB0tNgiHnTvA=; b=JKO1cREIy5XvPZPEP1FkwSzgcQn//WFF0KRdUCwkLJOVd24fvNByWTLn RSiJqsNdgwhg09p44xvVx2rROMMU/gPEn+qjpvpmFBBhBHBYh7oOePHGH 1XDUGmcfvcJ+ozOVyqCswFCwV232pFN9JzE12iFBO9vjBEF34L60sJSQW jjnPE1dAmmkaZouPD1IYy/vk+H9i2QeRArYQrXT7v0HQMtJoP9BXH74n/ JxI5639m5mcIn0IDvHZTtnUyRYI6UL0QaVbqiEjLlRKUiJv+mxICRbkRT cDpDSgywUXvoKGGe0BjBE5kZAzbG/rBUhpvc8wT8sB+URVJpqCACZ7G+d w==; X-IronPort-AV: E=McAfee;i="6500,9779,10540"; a="294519299" X-IronPort-AV: E=Sophos;i="5.96,187,1665471600"; d="scan'208";a="294519299" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2022 10:18:46 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10540"; a="672965938" X-IronPort-AV: E=Sophos;i="5.96,187,1665471600"; d="scan'208";a="672965938" Received: from vcbudden-mobl3.amr.corp.intel.com (HELO [10.212.129.67]) ([10.212.129.67]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2022 10:18:45 -0800 Message-ID: <2d99f823-09bb-ff51-0e71-f254cc6ad28b@intel.com> Date: Wed, 23 Nov 2022 10:18:45 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v7 06/20] x86/virt/tdx: Shut down TDX module in case of error Content-Language: en-US To: Sean Christopherson Cc: "Huang, Kai" , "peterz@infradead.org" , "kvm@vger.kernel.org" , "Luck, Tony" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "linux-kernel@vger.kernel.org" , "Chatre, Reinette" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "kirill.shutemov@linux.intel.com" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" References: <48505089b645019a734d85c2c29f3c8ae2dbd6bd.1668988357.git.kai.huang@intel.com> <52b2be9b-defd-63ce-4cb2-96cd624a95a6@intel.com> <791bf9a2-a079-3cd6-90a3-42dbb332a38c@intel.com> <9f1ea2639839305dd8b82694b3d8c697803f43a1.camel@intel.com> <168ca2b3-ffac-31c4-0b83-2d0ee75f34a5@intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=JKO1cREI; spf=pass (imf26.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669227529; a=rsa-sha256; cv=none; b=D0Gf6wSC5RAbo53q7cFEIs3tByzTMFhrI3pICzQbvWwBFKte1q7KunA+kBuNGzG7J3+rKU TKmBwpmX2SvrmesXX2gcUCIl+fLXOaJWU5KilsN0UqYthbqNllwOtNbdxkduZruQe37aaW sybS2eMLJ2XDVKiiOu9Y85ieV+lHnIg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669227529; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4B8DXl3lvnJ6NObZ6XTjxegtFXxF0CfRn4fXjyCDQAY=; b=LQI80yu3HqD4ki7crOYE8jtX7pUyxi5jtPOgLkGtwAdv8P9cTcI88tCBo1k3Xvp7beWo2E Au873OvFeRWIresYa7V/HtGYTf/BnSr/r6W39m4qqDvWNE6mOFwja2gqWhfiVpVKKYd/mH Pw4wEAqbt+bOV3yXEMxePFe/Mksjtus= X-Stat-Signature: b1em1mwqzaft9r3hohibgigurzwr9qkt X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 75487140013 Authentication-Results: imf26.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=JKO1cREI; spf=pass (imf26.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspam-User: X-HE-Tag: 1669227528-514126 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/23/22 09:37, Sean Christopherson wrote: > On Wed, Nov 23, 2022, Dave Hansen wrote: >> There's no way we can guarantee _that_. For one, the PAMT* allocations >> can always fail. I guess we could ask sysadmins to fire up a guest to >> "prime" things, but that seems a little silly. Maybe that would work as >> the initial implementation that we merge, but I suspect our users will >> demand more determinism, maybe a boot or module parameter. > Oh, you mean all of TDX initialization? I thought "initialization" here mean just > doing tdx_enable(). Yes, but the first call to tdx_enable() does TDH_SYS_INIT and all the subsequent work to get the module going. > Yeah, that's not going to be a viable option. Aside from lacking determinisim, > it would be all too easy to end up on a system with fragmented memory that can't > allocate the PAMTs post-boot. For now, the post-boot runtime PAMT allocations are the one any only way that TDX can be initialized. I pushed for it to be done this way. Here's why: Doing tdx_enable() is relatively slow and it eats up a non-zero amount of physically contiguous RAM for metadata (~1/256th or ~0.4% of RAM). Systems that support TDX but will never run TDX guests should not pay that cost. That means that we either make folks opt-in at boot-time or we try to make a best effort at runtime to do the metadata allocations. >From my perspective, the best-effort stuff is absolutely needed. Users are going to forget the command-line opt in and there's no harm in _trying_ the big allocations even if they fail. Second, in reality, the "real" systems that can run TDX guests are probably not going to sit around fragmenting memory for a month before they run their first guest. They're going to run one shortly after they boot when memory isn't fragmented and the best-effort allocation will work really well. Third, if anyone *REALLY* cared to make it reliable *and* wanted to sit around fragmenting memory for a month, they could just start a TDX guest and kill it to get TDX initialized. This isn't ideal. But, to me, it beats defining some new, separate ABI (or boot/module option) to do it. So, let's have those discussions. Long-term, what *is* the most reliable way to get the TDX module loaded with 100% determinism? What new ABI or interfaces are needed? Also, is that 100% determinism required the moment this series is merged? Or, can we work up to it? I think it can wait until this particular series is farther along.