From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 268D7C433FE for ; Fri, 24 Sep 2021 02:41:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B4CE860F0F for ; Fri, 24 Sep 2021 02:41:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B4CE860F0F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 3BE05900002; Thu, 23 Sep 2021 22:41:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36DDD6B0071; Thu, 23 Sep 2021 22:41:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28277900002; Thu, 23 Sep 2021 22:41:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0067.hostedemail.com [216.40.44.67]) by kanga.kvack.org (Postfix) with ESMTP id 1B82A6B006C for ; Thu, 23 Sep 2021 22:41:41 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id CE51A1830D164 for ; Fri, 24 Sep 2021 02:41:40 +0000 (UTC) X-FDA: 78620916360.01.95D7DAB Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf13.hostedemail.com (Postfix) with ESMTP id 1BB57102EE31 for ; Fri, 24 Sep 2021 02:41:39 +0000 (UTC) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4HFx8k3cyXzWNjN; Fri, 24 Sep 2021 10:40:22 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Fri, 24 Sep 2021 10:41:30 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Fri, 24 Sep 2021 10:41:30 +0800 Subject: Re: [PATCH v3 1/1] mm: Fix the uninitialized use in overcommit_policy_handler To: Andrew Morton , Chen Jun CC: , , , , References: <20210923020524.13289-1-chenjun102@huawei.com> <20210923192312.53dbe65db0375038c99defaa@linux-foundation.org> From: Kefeng Wang Message-ID: <2e27177d-2db2-de2e-96ba-fe9048c82978@huawei.com> Date: Fri, 24 Sep 2021 10:41:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20210923192312.53dbe65db0375038c99defaa@linux-foundation.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 1BB57102EE31 X-Stat-Signature: t5c3ciym146awo9qr5uebdea8eq8x4ap Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=huawei.com; spf=pass (imf13.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com X-HE-Tag: 1632451299-853598 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/9/24 10:23, Andrew Morton wrote: > On Thu, 23 Sep 2021 02:05:24 +0000 Chen Jun wro= te: > >> An unexpected value of /proc/sys/vm/overcommit_memory we will get, >> after running the following program. >> >> int main() >> { >> int fd =3D open("/proc/sys/vm/overcommit_memory", O_RDWR) Hi Andrew=EF=BC=8C missing=C2=A0 ';' here, > Thanks. I added a cc:stable to this, so the fix will be backported > into earlier kernels. ...=C2=A0 and the Fixes tag miss a ')' in the end ,=C2=A0 please help to = add them :) Reviewed-by: Kefeng Wang