From: Dmitry Osipenko <digetx@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
gregkh@linuxfoundation.org, surenb@google.com,
joaodias@google.com, jhubbard@nvidia.com, willy@infradead.org,
Colin Ian King <colin.king@canonical.com>
Subject: Re: [PATCH v7] mm: cma: support sysfs
Date: Thu, 25 Mar 2021 01:16:20 +0300 [thread overview]
Message-ID: <2f0ef658-9848-b655-f7c0-fee6aadb9846@gmail.com> (raw)
In-Reply-To: <YFu1QoiPEnAOAvXS@google.com>
25.03.2021 00:55, Minchan Kim пишет:
>>> +static ssize_t alloc_pages_success_show(struct kobject *kobj,
>>> + struct kobj_attribute *attr, char *buf)
>>> +{
>>> + struct cma *cma = cma_from_kobj(kobj);
>>> +
>>> + return sysfs_emit(buf, "%llu\n",
>>> + atomic64_read(&cma->nr_pages_succeeded));
>> nit: Algnment isn't right, should be better to write it as single line, IMO.
> Let me make it align rather than single line since I know someone
> who keep asking us to not overflow 80 columns unless it's special.
>
I'm actually one of those guys who complains about 80 chars (where
necessary), but in this particular case it only hurts readability of the
code, IMO.
next prev parent reply other threads:[~2021-03-24 22:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 20:55 [PATCH v7] mm: cma: support sysfs Minchan Kim
2021-03-24 21:31 ` Dmitry Osipenko
2021-03-24 21:35 ` Dmitry Osipenko
2021-03-24 21:55 ` Minchan Kim
2021-03-24 22:10 ` Dmitry Osipenko
2021-03-24 22:12 ` Dmitry Osipenko
2021-03-24 22:16 ` Dmitry Osipenko [this message]
2021-03-24 22:21 ` Dmitry Osipenko
2021-03-24 22:01 ` John Hubbard
2021-03-24 22:11 ` Dmitry Osipenko
2021-03-24 22:23 ` John Hubbard
2021-03-24 22:42 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f0ef658-9848-b655-f7c0-fee6aadb9846@gmail.com \
--to=digetx@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=jhubbard@nvidia.com \
--cc=joaodias@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=surenb@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).