From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 640FFC433E0 for ; Thu, 18 Feb 2021 09:02:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0763A64DE8 for ; Thu, 18 Feb 2021 09:02:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0763A64DE8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7F13C6B006C; Thu, 18 Feb 2021 04:02:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A2BD6B006E; Thu, 18 Feb 2021 04:02:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 691D56B0070; Thu, 18 Feb 2021 04:02:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id 52FAD6B006C for ; Thu, 18 Feb 2021 04:02:52 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 17D8C8249980 for ; Thu, 18 Feb 2021 09:02:52 +0000 (UTC) X-FDA: 77830798584.08.FFEF592 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf09.hostedemail.com (Postfix) with ESMTP id BBACA600249D for ; Thu, 18 Feb 2021 09:02:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613638970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/ugCbqPb9oy0RzBcGGyZx8mxEAfNFimnPKtTNa7iXdU=; b=SrwZ+ck/PnZ1Lz1W8YPFEbPi7QI7NSWkJ+/WRFR5qTz6MkwtobXBQExvXdeYXwfgWJHFoE +QpwuOzHPLeL1BvAsUQn/N2T5N5+vf5FDPcBJYPOaz8Q2ZLQlthG3KXmyxO+IjsrtGEyGl 4QqtAahONfMbSNbM1KpwTR+hBFhHBkI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-344-TI3-VbojPyWyyGO_gc9zOg-1; Thu, 18 Feb 2021 04:02:46 -0500 X-MC-Unique: TI3-VbojPyWyyGO_gc9zOg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 92D80107ACED; Thu, 18 Feb 2021 09:02:45 +0000 (UTC) Received: from [10.36.114.59] (ovpn-114-59.ams2.redhat.com [10.36.114.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5A59A6F7EC; Thu, 18 Feb 2021 09:02:44 +0000 (UTC) Subject: Re: [PATCH] mm: be more verbose for alloc_contig_range faliures To: Michal Hocko , Minchan Kim Cc: Andrew Morton , linux-mm , LKML , joaodias@google.com References: <20210217163603.429062-1-minchan@kernel.org> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <2f167b3c-5f0a-444a-c627-49181fc8fe0d@redhat.com> Date: Thu, 18 Feb 2021 10:02:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Stat-Signature: t4pd39f76th4x6ma1su9tfbc6mi1pbb4 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: BBACA600249D Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf09; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=63.128.21.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613638968-576392 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 18.02.21 09:56, Michal Hocko wrote: > On Wed 17-02-21 08:36:03, Minchan Kim wrote: >> alloc_contig_range is usually used on cma area or movable zone. >> It's critical if the page migration fails on those areas so >> dump more debugging message like memory_hotplug unless user >> specifiy __GFP_NOWARN. > > I agree with David that this has a potential to generate a lot of output > and it is not really clear whether it is worth it. Page isolation code > already has REPORT_FAILURE mode which currently used only for the memory > hotplug because this was just too noisy from the CMA path - d381c54760dc > ("mm: only report isolation failures when offlining memory"). > > Maybe migration failures are less likely to fail but still. Side note: I really dislike that uncontrolled error reporting on memory offlining path we have enabled as default. Yeah, it might be useful for ZONE_MOVABLE in some cases, but otherwise it's just noise. Just do a "sudo stress-ng --memhotplug 1" and see the log getting flooded ... -- Thanks, David / dhildenb