From: Zi Yan <ziy@nvidia.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "\"Huang,
Ying\"" <ying.huang@intel.com>,
Ryan Roberts <ryan.roberts@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
"\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
David Hildenbrand <david@redhat.com>,
"\"Yin, Fengwei\"" <fengwei.yin@intel.com>,
Yu Zhao <yuzhao@google.com>, Vlastimil Babka <vbabka@suse.cz>,
"\"Kirill A . Shutemov\"" <kirill.shutemov@linux.intel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Kemeng Shi <shikemeng@huaweicloud.com>,
Mel Gorman <mgorman@techsingularity.net>,
Rohan Puri <rohan.puri15@gmail.com>,
Mcgrof Chamberlain <mcgrof@kernel.org>,
Adam Manzanares <a.manzanares@samsung.com>,
"\"Vishal Moola (Oracle)\"" <vishal.moola@gmail.com>
Subject: Re: [PATCH v1 1/4] mm/compaction: enable compacting >0 order folios.
Date: Mon, 20 Nov 2023 09:05:59 -0500 [thread overview]
Message-ID: <300AECEE-2B86-4124-8571-E74E97988C50@nvidia.com> (raw)
In-Reply-To: <f2111ca6-4be7-4125-af3f-ffab47378bf1@linux.alibaba.com>
[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]
>> @@ -1144,17 +1166,18 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
>> goto isolate_abort;
>> }
>> }
>> + }
>> - /*
>> - * folio become large since the non-locked check,
>> - * and it's on LRU.
>> - */
>> - if (unlikely(folio_test_large(folio) && !cc->alloc_contig)) {
>> - low_pfn += folio_nr_pages(folio) - 1;
>> - nr_scanned += folio_nr_pages(folio) - 1;
>> - folio_set_lru(folio);
>> - goto isolate_fail_put;
>> - }
>> + /*
>> + * Check LRU folio order under the lock
>> + */
>> + if (unlikely(skip_isolation_on_order(folio_order(folio),
>> + cc->order) &&
>> + !cc->alloc_contig)) {
>> + low_pfn += folio_nr_pages(folio) - 1;
>> + nr_scanned += folio_nr_pages(folio) - 1;
>> + folio_set_lru(folio);
>> + goto isolate_fail_put;
>> }
>
> Why was this part moved out of the 'if (lruvec != locked)' block? If we hold the lru lock, then we do not need to check again, right?
Probably I messed this up during rebase. Thank you for pointing this out.
Will fix it in the next version.
--
Best Regards,
Yan, Zi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]
next prev parent reply other threads:[~2023-11-20 14:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 17:01 [PATCH v1 0/4] Enable >0 order folio memory compaction Zi Yan
2023-11-13 17:01 ` [PATCH v1 1/4] mm/compaction: enable compacting >0 order folios Zi Yan
2023-11-13 18:30 ` Matthew Wilcox
2023-11-13 19:22 ` Zi Yan
2023-11-20 9:18 ` Baolin Wang
2023-11-20 14:05 ` Zi Yan [this message]
2023-11-13 17:01 ` [PATCH v1 2/4] mm/compaction: add support for >0 order folio memory compaction Zi Yan
2024-01-09 15:18 ` Ryan Roberts
2024-01-09 15:25 ` Zi Yan
2023-11-13 17:01 ` [PATCH v1 3/4] mm/compaction: optimize >0 order folio compaction with free page split Zi Yan
2023-11-22 10:26 ` Ryan Roberts
2023-11-22 14:35 ` Zi Yan
2023-11-13 17:01 ` [PATCH v1 4/4] mm/compaction: optimize >0 order folio compaction by sorting source pages Zi Yan
2023-11-21 15:46 ` [PATCH v1 0/4] Enable >0 order folio memory compaction Ryan Roberts
2023-11-21 16:45 ` Zi Yan
2023-11-21 17:11 ` Ryan Roberts
2024-01-02 20:50 ` Zi Yan
2024-01-03 9:12 ` Ryan Roberts
2024-01-03 15:51 ` Zi Yan
2024-01-05 22:56 ` Zi Yan
2023-11-24 14:58 ` Ryan Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=300AECEE-2B86-4124-8571-E74E97988C50@nvidia.com \
--to=ziy@nvidia.com \
--cc=a.manzanares@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=fengwei.yin@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=mgorman@techsingularity.net \
--cc=rohan.puri15@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=shikemeng@huaweicloud.com \
--cc=vbabka@suse.cz \
--cc=vishal.moola@gmail.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).