From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Minchan Kim <minchan@kernel.org>,
Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
kernel-team@lge.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.com>,
"Kirill A . Shutemov" <kirill@shutemov.name>
Subject: Re: [RFC 01/11] mm: use SWAP_SUCCESS instead of 0
Date: Mon, 6 Mar 2017 14:37:40 +0530 [thread overview]
Message-ID: <33a8d76e-dbeb-bcf1-5024-5e780b81bef6@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170303030158.GD3503@bbox>
On 03/03/2017 08:31 AM, Minchan Kim wrote:
> On Thu, Mar 02, 2017 at 07:57:10PM +0530, Anshuman Khandual wrote:
>> On 03/02/2017 12:09 PM, Minchan Kim wrote:
>>> SWAP_SUCCESS defined value 0 can be changed always so don't rely on
>>> it. Instead, use explict macro.
>>
>> Right. But should not we move the changes to the callers last in the
>> patch series after doing the cleanup to the try_to_unmap() function
>> as intended first.
>
> I don't understand what you are pointing out. Could you elaborate it
> a bit?
I was just referring to the order of this patch in the series and
thinking if it would have been better if this patch would be at a
later stage in the series. But I guess its okay as we are any way
dropping off SWAP_FAIL, SWAP_SUCCESS etc in the end.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-06 9:08 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 6:39 [RFC 00/11] make try_to_unmap simple Minchan Kim
2017-03-02 6:39 ` [RFC 01/11] mm: use SWAP_SUCCESS instead of 0 Minchan Kim
2017-03-02 14:27 ` Anshuman Khandual
2017-03-03 3:01 ` Minchan Kim
2017-03-06 9:07 ` Anshuman Khandual [this message]
2017-03-07 14:19 ` Kirill A. Shutemov
2017-03-08 6:25 ` Minchan Kim
2017-03-02 6:39 ` [RFC 02/11] mm: remove unncessary ret in page_referenced Minchan Kim
2017-03-02 14:33 ` Anshuman Khandual
2017-03-03 3:03 ` Minchan Kim
2017-03-07 14:20 ` Kirill A. Shutemov
2017-03-02 6:39 ` [RFC 03/11] mm: remove SWAP_DIRTY in ttu Minchan Kim
2017-03-02 7:34 ` Hillf Danton
2017-03-03 2:57 ` Minchan Kim
2017-03-02 14:42 ` Anshuman Khandual
2017-03-07 14:20 ` Kirill A. Shutemov
2017-03-02 6:39 ` [RFC 04/11] mm: remove SWAP_MLOCK check for SWAP_SUCCESS " Minchan Kim
2017-03-02 14:51 ` Anshuman Khandual
2017-03-03 3:04 ` Minchan Kim
2017-03-07 14:26 ` Kirill A. Shutemov
2017-03-08 6:40 ` Minchan Kim
2017-03-02 6:39 ` [RFC 05/11] mm: make the try_to_munlock void function Minchan Kim
2017-03-03 11:43 ` Anshuman Khandual
2017-03-06 2:09 ` Minchan Kim
2017-03-06 9:40 ` Anshuman Khandual
2017-03-07 6:50 ` Minchan Kim
2017-03-07 8:55 ` Anshuman Khandual
2017-03-07 15:17 ` Kirill A. Shutemov
2017-03-08 6:41 ` Minchan Kim
2017-03-02 6:39 ` [RFC 06/11] mm: remove SWAP_MLOCK in ttu Minchan Kim
2017-03-03 12:36 ` Anshuman Khandual
2017-03-06 2:15 ` Minchan Kim
2017-03-07 15:24 ` Kirill A. Shutemov
2017-03-08 6:42 ` Minchan Kim
2017-03-02 6:39 ` [RFC 07/11] mm: remove SWAP_AGAIN " Minchan Kim
2017-03-03 12:54 ` Anshuman Khandual
2017-03-06 2:16 ` Minchan Kim
2017-03-02 6:39 ` [RFC 08/11] mm: make ttu's return boolean Minchan Kim
2017-03-08 7:13 ` John Hubbard
2017-03-09 6:37 ` Minchan Kim
2017-03-09 6:46 ` John Hubbard
2017-03-02 6:39 ` [RFC 09/11] mm: make rmap_walk void function Minchan Kim
2017-03-02 6:39 ` [RFC 10/11] mm: make rmap_one boolean function Minchan Kim
2017-03-02 6:39 ` [RFC 11/11] mm: remove SWAP_[SUCCESS|AGAIN|FAIL] Minchan Kim
2017-03-03 13:04 ` Anshuman Khandual
2017-03-06 2:18 ` Minchan Kim
2017-03-02 14:22 ` [RFC 00/11] make try_to_unmap simple Anshuman Khandual
2017-03-03 2:11 ` Minchan Kim
2017-03-03 5:39 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33a8d76e-dbeb-bcf1-5024-5e780b81bef6@linux.vnet.ibm.com \
--to=khandual@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@lge.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).