linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm/mempolicy: use helper range_in_vma() in queue_pages_test_walk()
@ 2021-01-30  9:13 Miaohe Lin
  2021-02-01 11:09 ` David Hildenbrand
  0 siblings, 1 reply; 2+ messages in thread
From: Miaohe Lin @ 2021-01-30  9:13 UTC (permalink / raw)
  To: akpm; +Cc: linux-mm, linux-kernel, linmiaohe

The helper range_in_vma() is introduced via commit 017b1660df89 ("mm:
migration: fix migration of huge PMD shared pages"). But we forgot to
use it in queue_pages_test_walk().

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 mm/mempolicy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 6961238c7ef5..ab51132547b8 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -677,7 +677,7 @@ static int queue_pages_test_walk(unsigned long start, unsigned long end,
 	unsigned long flags = qp->flags;
 
 	/* range check first */
-	VM_BUG_ON_VMA((vma->vm_start > start) || (vma->vm_end < end), vma);
+	VM_BUG_ON_VMA(!range_in_vma(vma, start, end), vma);
 
 	if (!qp->first) {
 		qp->first = vma;
-- 
2.19.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mm/mempolicy: use helper range_in_vma() in queue_pages_test_walk()
  2021-01-30  9:13 [PATCH] mm/mempolicy: use helper range_in_vma() in queue_pages_test_walk() Miaohe Lin
@ 2021-02-01 11:09 ` David Hildenbrand
  0 siblings, 0 replies; 2+ messages in thread
From: David Hildenbrand @ 2021-02-01 11:09 UTC (permalink / raw)
  To: Miaohe Lin, akpm; +Cc: linux-mm, linux-kernel

On 30.01.21 10:13, Miaohe Lin wrote:
> The helper range_in_vma() is introduced via commit 017b1660df89 ("mm:
> migration: fix migration of huge PMD shared pages"). But we forgot to
> use it in queue_pages_test_walk().
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>   mm/mempolicy.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 6961238c7ef5..ab51132547b8 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -677,7 +677,7 @@ static int queue_pages_test_walk(unsigned long start, unsigned long end,
>   	unsigned long flags = qp->flags;
>   
>   	/* range check first */
> -	VM_BUG_ON_VMA((vma->vm_start > start) || (vma->vm_end < end), vma);
> +	VM_BUG_ON_VMA(!range_in_vma(vma, start, end), vma);
>   
>   	if (!qp->first) {
>   		qp->first = vma;
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-02-01 11:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-30  9:13 [PATCH] mm/mempolicy: use helper range_in_vma() in queue_pages_test_walk() Miaohe Lin
2021-02-01 11:09 ` David Hildenbrand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).