From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D67EC54EE9 for ; Wed, 14 Sep 2022 01:07:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B1586B0071; Tue, 13 Sep 2022 21:07:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 760BC6B0073; Tue, 13 Sep 2022 21:07:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 601D38D0001; Tue, 13 Sep 2022 21:07:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4F0816B0071 for ; Tue, 13 Sep 2022 21:07:48 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 22544C07B1 for ; Wed, 14 Sep 2022 01:07:48 +0000 (UTC) X-FDA: 79908903816.15.7E65854 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) by imf25.hostedemail.com (Postfix) with ESMTP id 9D80EA00C6 for ; Wed, 14 Sep 2022 01:07:47 +0000 (UTC) Received: by mail-qk1-f171.google.com with SMTP id u28so6876787qku.2 for ; Tue, 13 Sep 2022 18:07:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=plxos9uquFOD+IvTyP/oZn7J1wpWUgAiZjzQhRQDPPQ=; b=b5Ib02DcxbD8iGr+e9uO3ofxDa5NOXUgiKqm4v2kO2kVzLFaIksphZ+L5Zdbvek1wM Wmqq1e6M0COkpEIS2jTy/PtUgCdajEtU48nkMBXp1pD9XDM6s+PucJjIlGaVewK6jpAB MixvjHa8iEwvkFwCTzd4+IiI1JDNHjbquWMgFtpWgjJj6qqEw5WAYPSMVDEgpLo3HNek 36boSZgTaGRXICe0uFLtjuI38uivs5RzA7nLftvI8tOPpKmyKy3pz/VsvafUilaTeUvi fcpstGUbfcwFK2RzmK6KZVIK3Hl4+3OGNIQyl05fWMzuh3cx6pq0kx437GIDICGwdU2D iecg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=plxos9uquFOD+IvTyP/oZn7J1wpWUgAiZjzQhRQDPPQ=; b=yAE5H9CDpreN454j2bOy+WRKVA52UtOU3h26B6dFyKoQJQVZ7VP9J3NOA3rXUJfv4f cQalnTsOT1iPkGfC8znluyF9WVBsFxJou2yGX2HCpFE1lFPOBT8h/uGWoKH6zqnbtyqW UtgHM4EtNzC8pQF1S90A91Ob5xVhAXkm/1WUe6PDPA5LW8m0JgR9Fl+vEmTVVpauUKBr vrhmXWiAI4ReQv8Au9pXOexsLQB7y4FF+7l3f7zCKgC8H+a43n6oDg1G6/wKfanlzkou 9P3m0slmQ54/hxCL5udBsaoBQVuibanD9nc2eF773O7S704tz6tcxVfozk/xeR181ScP VPOw== X-Gm-Message-State: ACgBeo0xjF3ehje7zYK3SHhr4frGvDRtzvwnQCRN8MVJeHAbGZSIBFut OIpz9x1vsR8+Hmc2MOLJJtQ= X-Google-Smtp-Source: AA6agR6T8fHDs9UyqzsDp4Um9poKtPw3ia21pUGOlENIFjDdlRCXupm+CtiBRXcOgUDRfWYaL1iLtg== X-Received: by 2002:a05:620a:4114:b0:6bb:33c2:45f9 with SMTP id j20-20020a05620a411400b006bb33c245f9mr24395201qko.374.1663117666899; Tue, 13 Sep 2022 18:07:46 -0700 (PDT) Received: from [10.69.40.226] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id bs14-20020a05620a470e00b006b58d8f6181sm707879qkb.72.2022.09.13.18.07.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Sep 2022 18:07:45 -0700 (PDT) Message-ID: <33ff9543-3396-7609-3865-7eed20b853f5@gmail.com> Date: Tue, 13 Sep 2022 18:07:41 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH 03/21] mm/hugetlb: correct demote page offset logic Content-Language: en-US To: Matthew Wilcox Cc: Andrew Morton , Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Frank Rowand , Mike Kravetz , Muchun Song , Mike Rapoport , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Borislav Petkov , "Paul E. McKenney" , Neeraj Upadhyay , Randy Dunlap , Damien Le Moal , Florian Fainelli , David Hildenbrand , Zi Yan , Oscar Salvador , Hari Bathini , Kees Cook , - , KOSAKI Motohiro , Mel Gorman , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux.dev References: <20220913195508.3511038-1-opendmb@gmail.com> <20220913195508.3511038-4-opendmb@gmail.com> From: Doug Berger In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663117667; a=rsa-sha256; cv=none; b=y53Gya6nL49Evjf6PRuAFykMGiTCjBi1yaZRcIaq3IQncH+/sxFDYem3jQXdbwzVBCMxfg cUhBza/qOutptYg5VMdb1Ah7Mbxr4pq6Nn+KItX+XSxegq51Gz3SILEHmwX5+SqW8cWje8 vQk50J7HgzzrdDmuonU1ECFj+mhcZvg= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=b5Ib02Dc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of opendmb@gmail.com designates 209.85.222.171 as permitted sender) smtp.mailfrom=opendmb@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663117667; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=plxos9uquFOD+IvTyP/oZn7J1wpWUgAiZjzQhRQDPPQ=; b=Uz/OLk9xTyqSAKqsxQDa48EkueWCnBGOiux0kUfuLDbCMuCJ+htfbIx67G6npfiepebniK l7OoL/u8nphEpCVfIvRWlSH7ghk0JwHjWHAnrZEFcKx0dyA2W4Zlb6p7JIaAlVMVIv0M9I H/iA57sZD1Zde9dtwMQjm66lJ7hsdCU= X-Stat-Signature: ezzpbq6hw7nx7nmhr1ry74qt139n1dzt X-Rspamd-Queue-Id: 9D80EA00C6 X-Rspamd-Server: rspam03 X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=b5Ib02Dc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of opendmb@gmail.com designates 209.85.222.171 as permitted sender) smtp.mailfrom=opendmb@gmail.com X-HE-Tag: 1663117667-772328 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/13/2022 4:34 PM, Matthew Wilcox wrote: > On Tue, Sep 13, 2022 at 12:54:50PM -0700, Doug Berger wrote: >> With gigantic pages it may not be true that struct page structures >> are contiguous across the entire gigantic page. The mem_map_offset >> function is used here in place of direct pointer arithmetic to >> correct for this. > > We're just eliminating mem_map_offset(). Please use nth_page() > instead.That's good to know. I will include that in v2. > >> for (i = 0; i < pages_per_huge_page(h); >> i += pages_per_huge_page(target_hstate)) { >> + subpage = mem_map_offset(page, i); >> if (hstate_is_gigantic(target_hstate))