From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DA09C433E0 for ; Fri, 19 Feb 2021 06:26:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DDA2C64E44 for ; Fri, 19 Feb 2021 06:26:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDA2C64E44 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 551AD6B0005; Fri, 19 Feb 2021 01:26:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E5026B006C; Fri, 19 Feb 2021 01:26:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32DC86B006E; Fri, 19 Feb 2021 01:26:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0193.hostedemail.com [216.40.44.193]) by kanga.kvack.org (Postfix) with ESMTP id 1682A6B0005 for ; Fri, 19 Feb 2021 01:26:40 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id BD95E181AF5E1 for ; Fri, 19 Feb 2021 06:26:39 +0000 (UTC) X-FDA: 77834033718.26.FE7937B Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf21.hostedemail.com (Postfix) with ESMTP id 13F87E0011C5 for ; Fri, 19 Feb 2021 06:26:36 +0000 (UTC) Received: by mail-lj1-f178.google.com with SMTP id g1so8136219ljj.13 for ; Thu, 18 Feb 2021 22:26:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=oKYBAFwZK2E+NJOykSWZQckrzDPJsnQG1WaF3x3BaDE=; b=MfFtugkAdc3dP2dxZgEsGrmYpvqLTEZSbhMx9o98zYWxHiFwLLHzJMphbF63pMW+eP 6/Inaix0PYIDxtvahNYNCvL5DMpUp8haMiU/uvbV/PgGu02dIHcctByjrlypstKL3968 xw8TJ+YQFGdGKQlDmPaHPRkGRojowaEkuw/uxE56e1jWBuWLD60EdZUZ9Kx4a09p4gD8 OP27gWhi41iuzjInDOfw80oCEblUKs6fIrKqGevXztwrN5CEVjlIDLqM+UTT/U2pvuql 9/zUJ0VkWxY8yCxxjWFqQo09BplPJcevJxit68cJz1c+dpYbiEUcFoSA6tUK6UwCTDHb fU5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oKYBAFwZK2E+NJOykSWZQckrzDPJsnQG1WaF3x3BaDE=; b=RxjmYBkhCaIXtQwQsQkh/tHYJnPPyOxPO9nTBBIS7VO6BAU+3U3JsaO17AuyYxwGuy Myk2Kg10Yi6nQgIgejbhYsm+77vNuPzaH9oumoo6Yqgi85jHq32MIT460mxqcZ4kqbWS b9ghLJGYFoax15bFhcBjE7lTR4pS6osdl7STGzC24ju80YiWSu9c/X2O6i4uFPP1fbEy 55KzoPD6U+8FYIb/edoLy1YBG9NnHk3KGz24Mc84e/OfEobv3lF/uYKkB4mF+GURL+d5 HsKGp1ZZaAvMyS880Yd4oVkYw+Zr8q9J9VpUzhmJKTVxFxcGxG1DD9VSaMXMG1kxnkHa oTMA== X-Gm-Message-State: AOAM530IgVnfKRRfSs5fqnLIBcpr85p/0hjs6yC5UtJlBjXyyJWP0Lrp irIX+SbAlBUqstFFdJXk0w8= X-Google-Smtp-Source: ABdhPJwodep7z9QRVTJ2+rVez3WEP0V4jVE7YDjCvmizDGX2NJRqcCByAi9ozWyV8E6bbOgm44wZbw== X-Received: by 2002:a19:54f:: with SMTP id 76mr4450292lff.303.1613715997534; Thu, 18 Feb 2021 22:26:37 -0800 (PST) Received: from [192.168.0.160] (10.177.smarthome.spb.ru. [109.71.177.10]) by smtp.gmail.com with ESMTPSA id a9sm851738ljn.129.2021.02.18.22.26.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Feb 2021 22:26:36 -0800 (PST) Subject: Re: [linux-next:master 10767/11658] drivers/staging/wlan-ng/p80211netdev.c:572:33: sparse: sparse: incorrect type in argument 1 (different address spaces) To: Greg Kroah-Hartman Cc: kbuild-all@lists.01.org, Linux Memory Management List , Pritthijit Nath , Dan Carpenter , kernel test robot References: <202102181635.MjFPiL57-lkp@intel.com> From: Ivan Safonov Message-ID: <34f1b30f-e681-8035-7014-a4ae6c8dc8d9@gmail.com> Date: Fri, 19 Feb 2021 09:26:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <202102181635.MjFPiL57-lkp@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 13F87E0011C5 X-Stat-Signature: 81zow7r5i7scfr7bkrpgfmcuxbqoashu Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf21; identity=mailfrom; envelope-from=""; helo=mail-lj1-f178.google.com; client-ip=209.85.208.178 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1613715996-867190 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/18/21 11:55 AM, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: cd560d8023bf73c94d755908c8d4a0994dd1ec34 > commit: bc4bf94cc2aed9192184782dbb9f884c5d6b9e82 [10767/11658] staging:wlan-ng: use memdup_user instead of kmalloc/copy_from_user > config: i386-randconfig-s001-20210218 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 > reproduce: > # apt-get install sparse > # sparse version: v0.6.3-215-g0fb77bb6-dirty > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=bc4bf94cc2aed9192184782dbb9f884c5d6b9e82 > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout bc4bf94cc2aed9192184782dbb9f884c5d6b9e82 > # save the attached .config to linux build tree > make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Greg, should I fix my patch? Pritthijit Nath has already made a fix for this warning: http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2021-February/150785.html > > "sparse warnings: (new ones prefixed by >>)" >>> drivers/staging/wlan-ng/p80211netdev.c:572:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const [noderef] __user * @@ got char *[usertype] data @@ > drivers/staging/wlan-ng/p80211netdev.c:572:33: sparse: expected void const [noderef] __user * > drivers/staging/wlan-ng/p80211netdev.c:572:33: sparse: got char *[usertype] data > > vim +572 drivers/staging/wlan-ng/p80211netdev.c > > 557 > 558 /* Test the magic, assume ifr is good if it's there */ > 559 if (req->magic != P80211_IOCTL_MAGIC) { > 560 result = -EINVAL; > 561 goto bail; > 562 } > 563 > 564 if (cmd == P80211_IFTEST) { > 565 result = 0; > 566 goto bail; > 567 } else if (cmd != P80211_IFREQ) { > 568 result = -EINVAL; > 569 goto bail; > 570 } > 571 > > 572 msgbuf = memdup_user(req->data, req->len); > 573 if (IS_ERR(msgbuf)) { > 574 result = PTR_ERR(msgbuf); > 575 goto bail; > 576 } > 577 > 578 result = p80211req_dorequest(wlandev, msgbuf); > 579 > 580 if (result == 0) { > 581 if (copy_to_user > 582 ((void __user *)req->data, msgbuf, req->len)) { > 583 result = -EFAULT; > 584 } > 585 } > 586 kfree(msgbuf); > 587 > 588 bail: > 589 /* If allocate,copyfrom or copyto fails, return errno */ > 590 return result; > 591 } > 592 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org >