From: David Hildenbrand <david@redhat.com>
To: Adithya Chandrakasan <adithya.chandrakasan@gmail.com>,
akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org
Subject: Re: This reply comments on the patch to fixes the missing a blank line warning
Date: Fri, 12 Feb 2021 11:14:19 +0100 [thread overview]
Message-ID: <35cbe08d-6c29-c904-1402-de18b787c5b0@redhat.com> (raw)
In-Reply-To: <3512c272-dbec-2c0a-4476-203315341fe2@gmail.com>
On 11.02.21 19:20, Adithya Chandrakasan wrote:
> On 2/11/21 2:36 AM, David Hildenbrand wrote:
>> ^
>>
>> Please create proper patch subjects. Nobody has a glue what you are doing when looking at the subject.
>>
>> "mm/util: fix ??? warning"
>>
>> Which raises the question, what is ???
>>
>> Compiler? static code checker? ... ?
>>
>>
>> Thanks
>>
>> On 11.02.21 08:29, Adithya Chandrakasan wrote:
>>> FILE: mm/util.c:930: WARNING: Missing a blank line after declarations
>>>
>>> Signed-off-by: Adithya Chandrakasan <adithya.chandrakasan@gmail.com>
>>> ---
>>> mm/util.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/mm/util.c b/mm/util.c
>>> index 8c9b7d1e7c49..60286876636d 100644
>>> --- a/mm/util.c
>>> +++ b/mm/util.c
>>> @@ -927,6 +927,7 @@ int get_cmdline(struct task_struct *task, char *buffer, int buflen)
>>> unsigned int len;
>>> struct mm_struct *mm = get_task_mm(task);
>>> unsigned long arg_start, arg_end, env_start, env_end;
>>> +
>>> if (!mm)
>>> goto out;
>>> if (!mm->arg_end)
>>>
>>
>>
> Hi David,
>
> Thanks for feedback. I have fixed the issues in the patch thread with
> change in subject and also log message.
Hi,
Please always send patches via proper mails and versioned.
E.g.,
rm *.patch
git format-patch -1 -v2
git send-email --to ... *.patch
The introducing patch is from 2014. So I wonder how you even get a
checkpatch warning?
a90902531a06a ("proc read mm's {arg,env}_{start,end} with mmap semaphore
taken.")
Anyhow, maybe just call this patch "mm: util.c: minor coding style fix",
that makes it clearer that this is really minor and has been in the code
for a while.
Thanks!
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-02-12 10:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 7:29 [PATCH] The Patch fixes the missing a blank line warning Adithya Chandrakasan
2021-02-11 10:36 ` This reply comments on the patch to " David Hildenbrand
2021-02-11 17:59 ` [PATCH] Staging: mm: util.c: checkpatch.pl coding style warning fix Adithya Chandrakasan
2021-02-11 18:20 ` This reply comments on the patch to fixes the missing a blank line warning Adithya Chandrakasan
2021-02-12 10:14 ` David Hildenbrand [this message]
2021-02-12 10:22 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35cbe08d-6c29-c904-1402-de18b787c5b0@redhat.com \
--to=david@redhat.com \
--cc=adithya.chandrakasan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).