From: Markus Elfring <Markus.Elfring@web.de>
To: Muchun Song <songmuchun@bytedance.com>,
Xiongchun Duan <duanxiongchun@bytedance.com>,
linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [v2] mm/ksm: Fix NULL pointer dereference when KSM zero page is enabled
Date: Tue, 14 Apr 2020 16:17:45 +0200 [thread overview]
Message-ID: <36a7d091-440b-a3db-c93f-713fc7cfbb5c@web.de> (raw)
In-Reply-To: <CAMZfGtVpMK38odpd3Ady_xW0hyMpN89Vwo_WNXBZz0yGaZzFQg@mail.gmail.com>
>>> to crash when we access vma->vm_mm(its offset is 0x40) later in
>>
>> Will another fine-tuning become relevant also for this wording?
>
> Sorry, I don't understand what this means because of my poor English.
Our language knowledge can evolve over time.
> Could you explain it again.
You integrated a few of my suggestions into your message selection. - Thanks.
I wonder why you did not like the following small adjustment possibilities
so far.
to a crash … vm_mm (its …
>> Will any other tags become helpful in such a case?
>
> How about changing
> "following calltrace is captured in kernel 4.19 with KSM zero page"
> to
> "The following calltrace is captured with the following patch applied:
> e86c59b1b12d ("mm/ksm: improve deduplication of zero pages with
> colouring")
> "
> ?
I find it unlikely that such a wording alternative would be more appropriate
while I became just curious for related development consequences around
the usage of a longterm kernel version.
Would you like to reuse the term “call trace”?
Regards,
Markus
next prev parent reply other threads:[~2020-04-14 14:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 7:56 [PATCH v2] mm/ksm: Fix NULL pointer dereference when KSM zero page is enabled Muchun Song
2020-04-14 9:17 ` Markus Elfring
2020-04-14 9:56 ` [External] " Muchun Song
2020-04-14 14:17 ` Markus Elfring [this message]
2020-04-14 14:39 ` [External] Re: [v2] " Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36a7d091-440b-a3db-c93f-713fc7cfbb5c@web.de \
--to=markus.elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=duanxiongchun@bytedance.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).