From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4B6BC433E0 for ; Mon, 25 May 2020 06:55:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7EB7B206B6 for ; Mon, 25 May 2020 06:55:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EB7B206B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F348D8001C; Mon, 25 May 2020 02:55:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE6298000E; Mon, 25 May 2020 02:55:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD3098001C; Mon, 25 May 2020 02:55:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0042.hostedemail.com [216.40.44.42]) by kanga.kvack.org (Postfix) with ESMTP id C381A8000E for ; Mon, 25 May 2020 02:55:08 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5FBFB180AD804 for ; Mon, 25 May 2020 06:55:08 +0000 (UTC) X-FDA: 76854329496.07.ship26_66ffa4baa6d5a X-HE-Tag: ship26_66ffa4baa6d5a X-Filterd-Recvd-Size: 2746 Received: from huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 May 2020 06:55:07 +0000 (UTC) Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 2471DDA1EE3F82EA9BC0; Mon, 25 May 2020 14:55:01 +0800 (CST) Received: from [127.0.0.1] (10.173.220.25) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.487.0; Mon, 25 May 2020 14:54:53 +0800 Subject: Re: [PATCH v2 2/6] arm64: Add level-hinted TLB invalidation helper To: Catalin Marinas CC: , , , , , , , , , , , , , , , , , , , , , , , , References: <20200423135656.2712-1-yezhenyu2@huawei.com> <20200423135656.2712-3-yezhenyu2@huawei.com> <20200522155017.GG26492@gaia> From: Zhenyu Ye Message-ID: <3852291c-37cf-39b6-564d-8b4f50f9d86e@huawei.com> Date: Mon, 25 May 2020 14:54:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20200522155017.GG26492@gaia> Content-Type: text/plain; charset="gbk" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.220.25] X-CFilter-Loop: Reflected X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020/5/22 23:50, Catalin Marinas wrote: > On Thu, Apr 23, 2020 at 09:56:52PM +0800, Zhenyu Ye wrote: >> diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/include/asm/tlbflush.h >> index bc3949064725..5f9f189bc6d2 100644 >> --- a/arch/arm64/include/asm/tlbflush.h >> +++ b/arch/arm64/include/asm/tlbflush.h >> @@ -10,6 +10,7 @@ >> >> #ifndef __ASSEMBLY__ >> >> +#include >> #include >> #include >> #include >> @@ -59,6 +60,35 @@ >> __ta; \ >> }) >> >> +#define TLBI_TTL_MASK GENMASK_ULL(47, 44) >> + >> +#define __tlbi_level(op, addr, level) \ >> + do { \ > > Nitpick: move "do {" on the same line as __tlbi_level() to reduce the > indentation levels of the whole block. > > Reviewed-by: Catalin Marinas > OK.