From: David Hildenbrand <david@redhat.com>
To: SeongJae Park <sj@kernel.org>, akpm@linux-foundation.org
Cc: osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memory_hotplug: return zero from do_migrate_range() for only success
Date: Wed, 15 Feb 2023 14:16:05 +0100 [thread overview]
Message-ID: <388b9a93-423f-33f8-0495-2a4a290fd1aa@redhat.com> (raw)
In-Reply-To: <20230214223236.58430-1-sj@kernel.org>
On 14.02.23 23:32, SeongJae Park wrote:
> do_migrate_range() returns migrate_pages() return value, which zero
> means perfect success, in usual cases. If all pages are failed to be
> isolated, however, it returns isolate_{lru,movalbe}_page() return
> values, or zero if all pfn were invalid, were hugetlb or hwpoisoned. So
> do_migrate_range() returning zero means either perfect success, or
> special cases of isolation total failure.
>
> Actually, the return value is not checked by any caller, so it might be
> better to simply make it a void function. However, there is a TODO for
> checking the return value.
I'd prefer to not add more dead code ;) Let's not return an error instead.
It's still unclear which kind of fatal migration issues we actually care
about and how to really detect them.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2023-02-15 13:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 22:32 [PATCH] mm/memory_hotplug: return zero from do_migrate_range() for only success SeongJae Park
2023-02-15 13:16 ` David Hildenbrand [this message]
2023-02-15 18:03 ` SeongJae Park
2023-02-15 20:00 ` David Hildenbrand
2023-02-15 22:33 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=388b9a93-423f-33f8-0495-2a4a290fd1aa@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).