From: David Hildenbrand <david@redhat.com>
To: sh <sh_def@163.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/page_reporting: use list_entry_is_head() in page_reporting_cycle()
Date: Tue, 29 Dec 2020 10:16:25 +0100 [thread overview]
Message-ID: <3897f709-3bc8-2204-5e85-09790779e292@redhat.com> (raw)
In-Reply-To: <20201222182735.GA1257912@ubuntu-A520I-AC>
On 22.12.20 19:27, sh wrote:
> replace '&next->lru != list' with list_entry_is_head().
> No functional change.
>
> Signed-off-by: sh <sh_def@163.com>
> ---
> mm/page_reporting.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_reporting.c b/mm/page_reporting.c
> index cd8e13d41df4..c50d93ffa252 100644
> --- a/mm/page_reporting.c
> +++ b/mm/page_reporting.c
> @@ -211,7 +211,7 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone,
> }
>
> /* Rotate any leftover pages to the head of the freelist */
> - if (&next->lru != list && !list_is_first(&next->lru, list))
> + if (!list_entry_is_head(next, list, lru) && !list_is_first(&next->lru, list))
> list_rotate_to_front(&next->lru, list);
>
> spin_unlock_irq(&zone->lock);
>
LGTM
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2020-12-29 9:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 18:27 [PATCH] mm/page_reporting: use list_entry_is_head() in page_reporting_cycle() sh
2020-12-29 9:16 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3897f709-3bc8-2204-5e85-09790779e292@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sh_def@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).