From: George Kennedy <george.kennedy@oracle.com>
To: Mike Rapoport <rppt@linux.ibm.com>
Cc: David Hildenbrand <david@redhat.com>,
Andrey Konovalov <andreyknvl@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Dmitry Vyukov <dvyukov@google.com>,
Konrad Rzeszutek Wilk <konrad@darnok.org>,
Will Deacon <will.deacon@arm.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Alexander Potapenko <glider@google.com>,
Marco Elver <elver@google.com>,
Peter Collingbourne <pcc@google.com>,
Evgenii Stepanov <eugenis@google.com>,
Branislav Rankov <Branislav.Rankov@arm.com>,
Kevin Brodsky <kevin.brodsky@arm.com>,
Christoph Hellwig <hch@infradead.org>,
kasan-dev <kasan-dev@googlegroups.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Dhaval Giani <dhaval.giani@oracle.com>
Subject: Re: [PATCH] mm, kasan: don't poison boot memory
Date: Tue, 23 Feb 2021 13:05:05 -0500 [thread overview]
Message-ID: <3a56ba38-ce91-63a6-b57c-f1726aa1b76e@oracle.com> (raw)
In-Reply-To: <20210223154758.GF1741768@linux.ibm.com>
On 2/23/2021 10:47 AM, Mike Rapoport wrote:
> Hi George,
>
> On Tue, Feb 23, 2021 at 09:35:32AM -0500, George Kennedy wrote:
>> On 2/23/2021 5:33 AM, Mike Rapoport wrote:
>>> (re-added CC)
>>>
>>> On Mon, Feb 22, 2021 at 08:24:59PM -0500, George Kennedy wrote:
>>>> On 2/22/2021 4:55 PM, Mike Rapoport wrote:
>>>>> On Mon, Feb 22, 2021 at 01:42:56PM -0500, George Kennedy wrote:
>>>>>> On 2/22/2021 11:13 AM, David Hildenbrand wrote:
>>>>>>> On 22.02.21 16:13, George Kennedy wrote:
>>>>>>>
>>>>>>> The PFN 0xbe453 looks a little strange, though. Do we expect ACPI tables
>>>>>>> close to 3 GiB ? No idea. Could it be that you are trying to map a wrong
>>>>>>> table? Just a guess.
>>>>>>>
>>>>>>>> What would be the correct way to reserve the page so that the above
>>>>>>>> would not be hit?
>>>>>>> I would have assumed that if this is a binary blob, that someone (which
>>>>>>> I think would be acpi code) reserved via memblock_reserve() early during
>>>>>>> boot.
>>>>>>>
>>>>>>> E.g., see drivers/acpi/tables.c:acpi_table_upgrade()->memblock_reserve().
>>>>>> acpi_table_upgrade() gets called, but bails out before memblock_reserve() is
>>>>>> called. Thus, it appears no pages are getting reserved.
>>>>> acpi_table_upgrade() does not actually reserve memory but rather open
>>>>> codes memblock allocation with memblock_find_in_range() +
>>>>> memblock_reserve(), so it does not seem related anyway.
>>>>>
>>>>> Do you have by chance a full boot log handy?
>>>> Hello Mike,
>>>>
>>>> Are you after the console output? See attached.
>>>>
>>>> It includes my patch to set PG_Reserved along with the dump_page() debug
>>>> that David asked for - see: "page:"
>>> So, iBFT is indeed at pfn 0xbe453:
>>>
>>> [ 0.077698] ACPI: iBFT 0x00000000BE453000 000800 (v01 BOCHS BXPCFACP 00000000 00000000)
>>> and it's in E820_TYPE_RAM region rather than in ACPI data:
>>>
>>> [ 0.000000] BIOS-e820: [mem 0x0000000000810000-0x00000000008fffff] ACPI NVS
>>> [ 0.000000] BIOS-e820: [mem 0x0000000000900000-0x00000000be49afff] usable
>>> [ 0.000000] BIOS-e820: [mem 0x00000000be49b000-0x00000000be49bfff] ACPI data
>>>
>>> I could not find anywhere in x86 setup or in ACPI tables parsing the code
>>> that reserves this memory or any other ACPI data for that matter. It could
>>> be that I've missed some copying of the data to statically allocated
>>> initial_tables, but AFAICS any ACPI data that was not marked as such in
>>> e820 tables by BIOS resides in memory that is considered as free.
>>>
>> Close...
>>
>> Applied the patch, see "[ 30.136157] iBFT detected.", but now hit the
>> following (missing iounmap()? see full console output attached):
>>
>> diff --git a/drivers/firmware/iscsi_ibft_find.c
>> b/drivers/firmware/iscsi_ibft_find.c
>> index 64bb945..2e5e040 100644
>> --- a/drivers/firmware/iscsi_ibft_find.c
>> +++ b/drivers/firmware/iscsi_ibft_find.c
>> @@ -80,6 +80,21 @@ static int __init find_ibft_in_mem(void)
>> done:
>> return len;
>> }
>> +
>> +static void __init acpi_find_ibft_region(void)
>> +{
>> + int i;
>> + struct acpi_table_header *table = NULL;
>> +
>> + if (acpi_disabled)
>> + return;
>> +
>> + for (i = 0; i < ARRAY_SIZE(ibft_signs) && !ibft_addr; i++) {
>> + acpi_get_table(ibft_signs[i].sign, 0, &table);
>> + ibft_addr = (struct acpi_table_ibft *)table;
> Can you try adding
>
> acpi_put_table(table);
>
> here?
Mike,
It now crashes here:
[ 0.051019] ACPI: Early table checksum verification disabled
[ 0.056721] ACPI: RSDP 0x00000000BFBFA014 000024 (v02 BOCHS )
[ 0.057874] ACPI: XSDT 0x00000000BFBF90E8 00004C (v01 BOCHS BXPCFACP
00000001 01000013)
[ 0.059590] ACPI: FACP 0x00000000BFBF5000 000074 (v01 BOCHS BXPCFACP
00000001 BXPC 00000001)
[ 0.061306] ACPI: DSDT 0x00000000BFBF6000 00238D (v01 BOCHS BXPCDSDT
00000001 BXPC 00000001)
[ 0.063006] ACPI: FACS 0x00000000BFBFD000 000040
[ 0.063938] ACPI: APIC 0x00000000BFBF4000 000090 (v01 BOCHS BXPCAPIC
00000001 BXPC 00000001)
[ 0.065638] ACPI: HPET 0x00000000BFBF3000 000038 (v01 BOCHS BXPCHPET
00000001 BXPC 00000001)
[ 0.067335] ACPI: BGRT 0x00000000BE49B000 000038 (v01 INTEL EDK2
00000002 01000013)
[ 0.069030] ACPI: iBFT 0x00000000BE453000 000800 (v01 BOCHS BXPCFACP
00000000 00000000)
[ 0.070734] XXX acpi_find_ibft_region:
[ 0.071468] XXX iBFT, status=0
[ 0.072073] XXX about to call acpi_put_table()...
ibft_addr=ffffffffff240000
[ 0.073449] XXX acpi_find_ibft_region(EXIT):
PANIC: early exception 0x0e IP 10:ffffffff9259f439 error 0 cr2
0xffffffffff240004
[ 0.075711] CPU: 0 PID: 0 Comm: swapper Not tainted 5.11.0-34a2105 #8
[ 0.076983] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996),
BIOS 0.0.0 02/06/2015
[ 0.078579] RIP: 0010:find_ibft_region+0x470/0x577
[ 0.079541] Code: f1 40 0f 9e c6 84 c9 0f 95 c1 40 84 ce 75 11 83 e0
07 38 c2 0f 9e c1 84 d2 0f 95 c0 84 c1 74 0a be 04 00 00 00 e8 37 f8 5f
ef <8b> 5b 04 4c 89 fa b8 ff ff 37 00 48 c1 ea 03 48 c1 e0 2a 81 c3 ff
[ 0.083207] RSP: 0000:ffffffff8fe07ca8 EFLAGS: 00010046 ORIG_RAX:
0000000000000000
[ 0.084709] RAX: 0000000000000000 RBX: ffffffffff240000 RCX:
ffffffff815fcf01
[ 0.086109] RDX: dffffc0000000000 RSI: 0000000000000001 RDI:
ffffffffff240004
[ 0.087509] RBP: ffffffff8fe07d60 R08: fffffbfff1fc0f21 R09:
fffffbfff1fc0f21
[ 0.088911] R10: ffffffff8fe07907 R11: fffffbfff1fc0f20 R12:
ffffffff8fe07d38
[ 0.090310] R13: 0000000000000001 R14: 0000000000000001 R15:
ffffffff8fe07e80
[ 0.091716] FS: 0000000000000000(0000) GS:ffffffff92409000(0000)
knlGS:0000000000000000
[ 0.093304] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 0.094435] CR2: ffffffffff240004 CR3: 0000000027630000 CR4:
00000000000006a0
[ 0.095843] Call Trace:
[ 0.096345] ? acpi_table_init+0x3eb/0x428
[ 0.097164] ? dmi_id_init+0x871/0x871
[ 0.097912] ? early_memunmap+0x22/0x27
[ 0.098683] ? smp_scan_config+0x20e/0x230
[ 0.099500] setup_arch+0xd3e/0x181d
[ 0.100221] ? reserve_standard_io_resources+0x3e/0x3e
[ 0.101265] ? __sanitizer_cov_trace_pc+0x21/0x50
[ 0.102203] ? vprintk_func+0xe9/0x200
[ 0.102953] ? printk+0xac/0xd4
[ 0.103589] ? record_print_text.cold.38+0x16/0x16
[ 0.104540] ? write_comp_data+0x2f/0x90
[ 0.105325] ? __sanitizer_cov_trace_pc+0x21/0x50
[ 0.106262] start_kernel+0x6c/0x474
[ 0.106981] x86_64_start_reservations+0x37/0x39
[ 0.107902] x86_64_start_kernel+0x7b/0x7e
[ 0.108722] secondary_startup_64_no_verify+0xb0/0xbb
Added debug to dump out the ibft_addr:
[root@gkennedy-20210107-1202 linux-upwork]# git diff
diff --git a/drivers/firmware/iscsi_ibft_find.c
b/drivers/firmware/iscsi_ibft_find.c
index 2e5e040..a246373 100644
--- a/drivers/firmware/iscsi_ibft_find.c
+++ b/drivers/firmware/iscsi_ibft_find.c
@@ -83,16 +83,22 @@ static int __init find_ibft_in_mem(void)
static void __init acpi_find_ibft_region(void)
{
- int i;
+ int i, status;
struct acpi_table_header *table = NULL;
-
+printk(KERN_ERR "XXX acpi_find_ibft_region:\n");
if (acpi_disabled)
return;
for (i = 0; i < ARRAY_SIZE(ibft_signs) && !ibft_addr; i++) {
- acpi_get_table(ibft_signs[i].sign, 0, &table);
- ibft_addr = (struct acpi_table_ibft *)table;
+ status = acpi_get_table(ibft_signs[i].sign, 0, &table);
+ printk(KERN_ERR "XXX %s, status=%x\n",
ibft_signs[i].sign, status);
+ if (ACPI_SUCCESS(status)) {
+ ibft_addr = (struct acpi_table_ibft *)table;
+ printk(KERN_ERR "XXX about to call
acpi_put_table()... ibft_addr=%llx\n", (u64)ibft_addr);
+ acpi_put_table(table);
+ }
}
+printk(KERN_ERR "XXX acpi_find_ibft_region(EXIT):\n");
}
/*
(END)
George
>
>> + }
>> +}
>> +
next prev parent reply other threads:[~2021-02-23 18:05 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 20:56 [PATCH] mm, kasan: don't poison boot memory Andrey Konovalov
2021-02-18 8:55 ` David Hildenbrand
2021-02-18 19:40 ` Andrey Konovalov
2021-02-18 19:46 ` David Hildenbrand
2021-02-18 20:26 ` Andrey Konovalov
2021-02-19 0:06 ` George Kennedy
2021-02-19 0:09 ` Andrey Konovalov
2021-02-19 16:45 ` George Kennedy
2021-02-19 23:04 ` George Kennedy
2021-02-22 9:52 ` David Hildenbrand
2021-02-22 15:13 ` George Kennedy
2021-02-22 16:13 ` David Hildenbrand
2021-02-22 16:39 ` David Hildenbrand
2021-02-22 17:40 ` Konrad Rzeszutek Wilk
2021-02-22 18:45 ` Mike Rapoport
2021-02-22 18:42 ` George Kennedy
2021-02-22 21:55 ` Mike Rapoport
[not found] ` <9773282a-2854-25a4-9faa-9da5dd34e371@oracle.com>
2021-02-23 10:33 ` Mike Rapoport
[not found] ` <3ef9892f-d657-207f-d4cf-111f98dcb55c@oracle.com>
2021-02-23 15:47 ` Mike Rapoport
2021-02-23 18:05 ` George Kennedy [this message]
2021-02-23 20:09 ` Mike Rapoport
2021-02-23 21:16 ` George Kennedy
2021-02-23 21:32 ` Mike Rapoport
2021-02-23 21:46 ` George Kennedy
2021-02-24 10:37 ` Mike Rapoport
2021-02-24 14:22 ` George Kennedy
2021-02-25 8:53 ` Mike Rapoport
2021-02-25 12:38 ` George Kennedy
2021-02-25 14:57 ` Mike Rapoport
2021-02-25 15:22 ` George Kennedy
2021-02-25 16:06 ` George Kennedy
2021-02-25 16:07 ` Mike Rapoport
2021-02-25 16:31 ` George Kennedy
2021-02-25 17:23 ` David Hildenbrand
2021-02-25 17:41 ` Mike Rapoport
2021-02-25 17:50 ` Mike Rapoport
2021-02-25 17:33 ` George Kennedy
2021-02-26 1:19 ` George Kennedy
2021-02-26 11:17 ` Mike Rapoport
2021-02-26 16:16 ` George Kennedy
2021-02-28 18:08 ` Mike Rapoport
2021-03-01 14:29 ` George Kennedy
2021-03-02 1:20 ` George Kennedy
2021-03-02 9:57 ` Mike Rapoport
2021-02-23 21:26 ` George Kennedy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a56ba38-ce91-63a6-b57c-f1726aa1b76e@oracle.com \
--to=george.kennedy@oracle.com \
--cc=Branislav.Rankov@arm.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=aryabinin@virtuozzo.com \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=dhaval.giani@oracle.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=eugenis@google.com \
--cc=glider@google.com \
--cc=hch@infradead.org \
--cc=kasan-dev@googlegroups.com \
--cc=kevin.brodsky@arm.com \
--cc=konrad@darnok.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pcc@google.com \
--cc=rppt@linux.ibm.com \
--cc=vincenzo.frascino@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).