From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F11F6C7EE23 for ; Thu, 25 May 2023 02:16:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 327726B0074; Wed, 24 May 2023 22:16:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D83D6B0075; Wed, 24 May 2023 22:16:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C634900002; Wed, 24 May 2023 22:16:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 08C4A6B0074 for ; Wed, 24 May 2023 22:16:08 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C36DAC09B4 for ; Thu, 25 May 2023 02:16:07 +0000 (UTC) X-FDA: 80827162374.08.0F42473 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf24.hostedemail.com (Postfix) with ESMTP id AC49D18000A for ; Thu, 25 May 2023 02:16:05 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf24.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684980966; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0glnxf+DFGGRXmqzuQmi13z3HBmRIrdliAa9f71PVYA=; b=CUGZSRpksmwm6QGqxVAXQUshY66tATmB+q3B3Gix+4oO0ZskDFp0HjI1xRnhn59mFn6U/g 27SGclVgEbDjrTLpgl31cjh0BkHAWp8IIvAlZi9Y1Vdo2Vt6/FZ3AzLDdw53dxwnNjHldc zHVfjn2A3esRFcJsEGk8SqQeU6qjpSU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf24.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684980966; a=rsa-sha256; cv=none; b=SZ2Fu9caL1ZwZECmAJzoBbxyR7RDTVr4JCQLkYPWe2Cp7vhb0uKHfCu+6U2cIN04Bfb37G mIFGRj2MNz8fBdlYRKh/ZoSPuAptsMNgvIcB6aVARv7AvkrGcYGqnusr6VzSqw2vSjpV6T vI+Sp0CdWaB+RrYj6OLMJiYYQhkUnRM= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BC3BD1042; Wed, 24 May 2023 19:16:49 -0700 (PDT) Received: from [10.162.43.6] (unknown [10.162.43.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 52CB33F762; Wed, 24 May 2023 19:16:03 -0700 (PDT) Message-ID: <3a777e9c-8a84-7ecb-8b19-606e7692eabe@arm.com> Date: Thu, 25 May 2023 07:46:00 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Anshuman Khandual Subject: Re: [PATCH v4 01/36] mm: Convert page_table_check_pte_set() to page_table_check_ptes_set() To: "Matthew Wilcox (Oracle)" , linux-arch@vger.kernel.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-2-willy@infradead.org> Content-Language: en-US In-Reply-To: <20230315051444.3229621-2-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: acn76jbcjrgy391rqc3ta4c6jcn8dyse X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AC49D18000A X-HE-Tag: 1684980965-93341 X-HE-Meta: U2FsdGVkX1+7Q3MIKjDkhX61jI4/q1k108h+niu38fsbxpwVantQC0LYgULvYnz4EFaF94mxqIsHFKsCT14Vjz4IK0gV8NuGKyyHQ9yG77wMzoXt60CQ2u6Oy9Q8cJH5To0W0aOm6uT6TKe4FImr+8tafzCVZzhA0mEZe2Vu9hVpbwpAFCv/SXfPFFC1ZzAPU/bghJobuOO7tEhnTybrD+Tr7lmKrlU1K5+pRd51mNjrVAmwazRUvSUEflM0C6T05X/4lFfmhPLvGswAhUIFTByLkPMKP9sAAcrUSWeMqT45CgymzlzW867JkSuNkZohFiVORIT0FiFgFiJXFReKFrR1oxT7ZoqWhw+tgiwwpKaFwrlMrv/mp4rwyPZMsztI9hntb0fuwedRmeSqXBVlyKmMT62u7v3/NKfNmat9A2EDxzOJ1TYCy25dQ7cHOtEm7l7gahtmgjFQ4FJrgdBsk1UeEJ5DSZYN9rjF8VfakwDeiEk/yYL5//KoWeuBxO4Wm8Vlx3Ew8RI9jwnrNj6bh5l9EGV+5Qp6MTTlzGOqFDaMyAgXDvqUFhuy9VNc5pqN+1SwU4SbF8iJXhXUksvstt74SXg0FL3/hVA2c4cKasX3pw8BPSk6RylFvKZz5qvIqoqsLlMg+HhEtcqQQbJOfeNXiLyQecg6V9bJWQ+Vfz73i3vHk2gXDbzfxvGexBxdUCtRp+qxCXpSozRNhY6XNuzrE+lZyLgNEbrwiSOzq6Wgl8ZiXnWEWoXlfts3d9Jz6qOFNJmXH00N8TCNYhViEarxJPaTTQSyoN0F2XeGHKxBFXk78a+J6uD4KgCr/GVcYQWrMCFrWL3ZqK10VzADHMfvQA2tV1f9H00H/sMYoA+jp7FQoF6vgnqhkwiT6SzgAwhu4s0D3CEJYeAFUkYhWDKWDnhxYlWDTWw5y8U0B6mm4De9TQQQvwMf7IsHYibksqeEyzlplF+V9PlN7pR 9A4R3yYW FT/Ng7eX3A74wCi/ZkS8gIofK+h1BoRokU1ZKPsT6nQXfbpeWBevlxSK2g3RGDLPlh//gQh+7ukPF4PduhClKkDoM1bLBM2eYAfId89rJPtZup9MXdxD6LjAAzaM6X3UYtDkHa4Ld41QXoTelQnkstiWfkcO6vE14P1G3mKoYD3suK3DH9b/sw6XfMgXhPJi2iPec/QdtsFe5JdtP5P9+e0Nw/vFx8B/tEOsR6X7j3esmO9fRsHNNlvwIrqjRVPtr3jfjUaK4rHxNSVIGNet/zXjpHQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/15/23 10:44, Matthew Wilcox (Oracle) wrote: > Tell the page table check how many PTEs & PFNs we want it to check. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Anshuman Khandual > --- > arch/arm64/include/asm/pgtable.h | 2 +- > arch/riscv/include/asm/pgtable.h | 2 +- > arch/x86/include/asm/pgtable.h | 2 +- > include/linux/page_table_check.h | 14 +++++++------- > mm/page_table_check.c | 14 ++++++++------ > 5 files changed, 18 insertions(+), 16 deletions(-) > > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index 0bd18de9fd97..9428748f4691 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -358,7 +358,7 @@ static inline void __set_pte_at(struct mm_struct *mm, unsigned long addr, > static inline void set_pte_at(struct mm_struct *mm, unsigned long addr, > pte_t *ptep, pte_t pte) > { > - page_table_check_pte_set(mm, addr, ptep, pte); > + page_table_check_ptes_set(mm, addr, ptep, pte, 1); > return __set_pte_at(mm, addr, ptep, pte); > } > > diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h > index ab05f892d317..b516f3b59616 100644 > --- a/arch/riscv/include/asm/pgtable.h > +++ b/arch/riscv/include/asm/pgtable.h > @@ -459,7 +459,7 @@ static inline void __set_pte_at(struct mm_struct *mm, > static inline void set_pte_at(struct mm_struct *mm, > unsigned long addr, pte_t *ptep, pte_t pteval) > { > - page_table_check_pte_set(mm, addr, ptep, pteval); > + page_table_check_ptes_set(mm, addr, ptep, pteval, 1); > __set_pte_at(mm, addr, ptep, pteval); > } > > diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h > index 15ae4d6ba476..1031025730d0 100644 > --- a/arch/x86/include/asm/pgtable.h > +++ b/arch/x86/include/asm/pgtable.h > @@ -1022,7 +1022,7 @@ static inline pud_t native_local_pudp_get_and_clear(pud_t *pudp) > static inline void set_pte_at(struct mm_struct *mm, unsigned long addr, > pte_t *ptep, pte_t pte) > { > - page_table_check_pte_set(mm, addr, ptep, pte); > + page_table_check_ptes_set(mm, addr, ptep, pte, 1); > set_pte(ptep, pte); > } > > diff --git a/include/linux/page_table_check.h b/include/linux/page_table_check.h > index 01e16c7696ec..ba269c7009e4 100644 > --- a/include/linux/page_table_check.h > +++ b/include/linux/page_table_check.h > @@ -20,8 +20,8 @@ void __page_table_check_pmd_clear(struct mm_struct *mm, unsigned long addr, > pmd_t pmd); > void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr, > pud_t pud); > -void __page_table_check_pte_set(struct mm_struct *mm, unsigned long addr, > - pte_t *ptep, pte_t pte); > +void __page_table_check_ptes_set(struct mm_struct *mm, unsigned long addr, > + pte_t *ptep, pte_t pte, unsigned int nr); > void __page_table_check_pmd_set(struct mm_struct *mm, unsigned long addr, > pmd_t *pmdp, pmd_t pmd); > void __page_table_check_pud_set(struct mm_struct *mm, unsigned long addr, > @@ -73,14 +73,14 @@ static inline void page_table_check_pud_clear(struct mm_struct *mm, > __page_table_check_pud_clear(mm, addr, pud); > } > > -static inline void page_table_check_pte_set(struct mm_struct *mm, > +static inline void page_table_check_ptes_set(struct mm_struct *mm, > unsigned long addr, pte_t *ptep, > - pte_t pte) > + pte_t pte, unsigned int nr) > { > if (static_branch_likely(&page_table_check_disabled)) > return; > > - __page_table_check_pte_set(mm, addr, ptep, pte); > + __page_table_check_ptes_set(mm, addr, ptep, pte, nr); > } > > static inline void page_table_check_pmd_set(struct mm_struct *mm, > @@ -138,9 +138,9 @@ static inline void page_table_check_pud_clear(struct mm_struct *mm, > { > } > > -static inline void page_table_check_pte_set(struct mm_struct *mm, > +static inline void page_table_check_ptes_set(struct mm_struct *mm, > unsigned long addr, pte_t *ptep, > - pte_t pte) > + pte_t pte, unsigned int nr) > { > } > > diff --git a/mm/page_table_check.c b/mm/page_table_check.c > index 25d8610c0042..e6f4d40caaa2 100644 > --- a/mm/page_table_check.c > +++ b/mm/page_table_check.c > @@ -184,20 +184,22 @@ void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr, > } > EXPORT_SYMBOL(__page_table_check_pud_clear); > > -void __page_table_check_pte_set(struct mm_struct *mm, unsigned long addr, > - pte_t *ptep, pte_t pte) > +void __page_table_check_ptes_set(struct mm_struct *mm, unsigned long addr, > + pte_t *ptep, pte_t pte, unsigned int nr) > { > + unsigned int i; > + > if (&init_mm == mm) > return; > > - __page_table_check_pte_clear(mm, addr, *ptep); > + for (i = 0; i < nr; i++) > + __page_table_check_pte_clear(mm, addr, ptep[i]); > if (pte_user_accessible_page(pte)) { > - page_table_check_set(mm, addr, pte_pfn(pte), > - PAGE_SIZE >> PAGE_SHIFT, > + page_table_check_set(mm, addr, pte_pfn(pte), nr, > pte_write(pte)); > } > } > -EXPORT_SYMBOL(__page_table_check_pte_set); > +EXPORT_SYMBOL(__page_table_check_ptes_set); > > void __page_table_check_pmd_set(struct mm_struct *mm, unsigned long addr, > pmd_t *pmdp, pmd_t pmd)