From: David Hildenbrand <david@redhat.com>
To: Michal Hocko <mhocko@suse.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Wei Yang <richard.weiyang@linux.alibaba.com>,
Baoquan He <bhe@redhat.com>,
Pankaj Gupta <pankaj.gupta.linux@gmail.com>,
Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH v1 04/11] mm/memory_hotplug: simplify offlining of pages in offline_pages()
Date: Wed, 19 Aug 2020 14:44:09 +0200 [thread overview]
Message-ID: <3a8c7fab-f7f8-faa2-a1e5-a17e22d9bdc0@redhat.com> (raw)
In-Reply-To: <20200819124057.GH5422@dhcp22.suse.cz>
On 19.08.20 14:40, Michal Hocko wrote:
> On Wed 19-08-20 12:11:50, David Hildenbrand wrote:
>> We make sure that we cannot have any memory holes right at the beginning
>> of offline_pages(). We no longer need walk_system_ram_range() and can
>> call __offline_isolated_pages() directly.
>>
>> offlined_pages always corresponds to nr_pages, so we can simplify that.
>
> I would probably fold this into the previous patch as they are dealing
> with the same thing.
Will do, shouldn't harm readability. Thanks!
---
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-08-19 12:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 10:11 [PATCH v1 00/11] mm/memory_hotplug: online_pages()/offline_pages() cleanups David Hildenbrand
2020-08-19 10:11 ` [PATCH v1 01/11] mm/memory_hotplug: inline __offline_pages() into offline_pages() David Hildenbrand
2020-08-19 12:23 ` Michal Hocko
2020-08-19 10:11 ` [PATCH v1 02/11] mm/memory_hotplug: enforce section granularity when onlining/offlining David Hildenbrand
2020-08-19 12:37 ` Michal Hocko
2020-08-19 12:43 ` David Hildenbrand
2020-08-19 12:54 ` Michal Hocko
2020-08-19 10:11 ` [PATCH v1 03/11] mm/memory_hotplug: simplify checking if all pages are isolated in offline_pages() David Hildenbrand
2020-08-19 12:39 ` Michal Hocko
2020-08-31 10:10 ` Pankaj Gupta
2020-08-19 10:11 ` [PATCH v1 04/11] mm/memory_hotplug: simplify offlining of pages " David Hildenbrand
2020-08-19 12:40 ` Michal Hocko
2020-08-19 12:44 ` David Hildenbrand [this message]
2020-08-19 10:11 ` [PATCH v1 05/11] mm/page_alloc: simplify __offline_isolated_pages() David Hildenbrand
2020-08-19 12:48 ` Michal Hocko
2020-08-19 10:11 ` [PATCH v1 06/11] mm/memory_hotplug: drop nr_isolate_pageblock in offline_pages() David Hildenbrand
2020-08-19 12:58 ` Michal Hocko
2020-08-19 10:11 ` [PATCH v1 07/11] mm/page_isolation: simplify return value of start_isolate_page_range() David Hildenbrand
2020-08-19 13:00 ` Michal Hocko
2020-08-19 10:11 ` [PATCH v1 08/11] mm/memory_hotplug: simplify page onlining David Hildenbrand
2020-08-19 13:02 ` Michal Hocko
2020-08-19 10:11 ` [PATCH v1 09/11] mm/page_alloc: drop stale pageblock comment in memmap_init_zone*() David Hildenbrand
2020-08-19 13:05 ` Michal Hocko
2020-08-19 10:11 ` [PATCH v1 10/11] mm: pass migratetype into memmap_init_zone() and move_pfn_range_to_zone() David Hildenbrand
2020-08-19 13:08 ` Michal Hocko
2020-08-19 10:11 ` [PATCH v1 11/11] mm/memory_hotplug: mark pageblocks MIGRATE_ISOLATE while onlining memory David Hildenbrand
2020-08-19 13:16 ` Michal Hocko
2020-08-19 13:19 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a8c7fab-f7f8-faa2-a1e5-a17e22d9bdc0@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=pankaj.gupta.linux@gmail.com \
--cc=richard.weiyang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).