From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36ED0C2BBCA for ; Tue, 15 Dec 2020 19:05:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 86A2122ADC for ; Tue, 15 Dec 2020 19:05:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86A2122ADC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AF2FC6B0036; Tue, 15 Dec 2020 14:05:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AA3516B005D; Tue, 15 Dec 2020 14:05:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 991B16B0068; Tue, 15 Dec 2020 14:05:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0081.hostedemail.com [216.40.44.81]) by kanga.kvack.org (Postfix) with ESMTP id 7EF3D6B0036 for ; Tue, 15 Dec 2020 14:05:28 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8F5D1364B for ; Tue, 15 Dec 2020 19:05:27 +0000 (UTC) X-FDA: 77596445094.30.angle06_1b00b0427425 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 52A54180B3C85 for ; Tue, 15 Dec 2020 19:05:27 +0000 (UTC) X-HE-Tag: angle06_1b00b0427425 X-Filterd-Recvd-Size: 5489 Received: from aserp2130.oracle.com (aserp2130.oracle.com [141.146.126.79]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Dec 2020 19:05:26 +0000 (UTC) Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BFJ05Nn166879; Tue, 15 Dec 2020 19:05:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=rPaA1lXHtSIrJnQXSfEHzf/QB0dDoI9KLHNNF9d2vyk=; b=XxG8yezhuwhvdL/NoipNesCnm3sm5cjA8YlgvbvW1HHxEITZTP0ZyhE82MIDP+GN9/5j /UZJZ7hWT3uni1b4nkheEECeEBHEr1L2SnshTtQVU/iqLCgyI7D+ORP5ghWepy3TfEgC 0m6V/K1enEiivJ1Jiiiq2UvfS1meyUKLdtShxrbkD0aSPeyF2GLlG0llWmfavR8YciAQ ar+LEZmRhmWrMOrGwGdcmluYiQ74ngB7eLg1+QbsEWoR4Hl88lMeQ9Zgq5zyTg3P69Ti /1zZpwj5XBbTcCQjYQY80V+mav+tk0T+ALeAhgWPt2AA+kYasicfoyT8hMUB07BJOemq 7g== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2130.oracle.com with ESMTP id 35ckcbcgye-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 15 Dec 2020 19:05:14 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BFJ1C3e048331; Tue, 15 Dec 2020 19:05:14 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 35d7enf2hf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Dec 2020 19:05:14 +0000 Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0BFJ5AuJ024299; Tue, 15 Dec 2020 19:05:10 GMT Received: from [10.159.136.92] (/10.159.136.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 15 Dec 2020 11:05:09 -0800 Subject: Re: [RFC PATCH v2 0/6] fsdax: introduce fs query to support reflink To: Ruan Shiyang , linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-nvdimm@lists.01.org, linux-mm@kvack.org Cc: linux-fsdevel@vger.kernel.org, linux-raid@vger.kernel.org, darrick.wong@oracle.com, dan.j.williams@intel.com, david@fromorbit.com, hch@lst.de, song@kernel.org, rgoldwyn@suse.de, qi.fuli@fujitsu.com, y-goto@fujitsu.com References: <20201123004116.2453-1-ruansy.fnst@cn.fujitsu.com> <89ab4ec4-e4f0-7c17-6982-4f55bb40f574@oracle.com> From: Jane Chu Organization: Oracle Corporation Message-ID: <3b35604c-57e2-8cb5-da69-53508c998540@oracle.com> Date: Tue, 15 Dec 2020 11:05:07 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9836 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 bulkscore=0 suspectscore=0 adultscore=0 mlxscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012150126 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9836 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 priorityscore=1501 mlxscore=0 suspectscore=0 adultscore=0 phishscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012150126 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/15/2020 3:58 AM, Ruan Shiyang wrote: > Hi Jane >=20 > On 2020/12/15 =E4=B8=8A=E5=8D=884:58, Jane Chu wrote: >> Hi, Shiyang, >> >> On 11/22/2020 4:41 PM, Shiyang Ruan wrote: >>> This patchset is a try to resolve the problem of tracking shared page >>> for fsdax. >>> >>> Change from v1: >>> =C2=A0=C2=A0 - Intorduce ->block_lost() for block device >>> =C2=A0=C2=A0 - Support mapped device >>> =C2=A0=C2=A0 - Add 'not available' warning for realtime device in XFS >>> =C2=A0=C2=A0 - Rebased to v5.10-rc1 >>> >>> This patchset moves owner tracking from dax_assocaite_entry() to pmem >>> device, by introducing an interface ->memory_failure() of struct >>> pagemap.=C2=A0 The interface is called by memory_failure() in mm, and >>> implemented by pmem device.=C2=A0 Then pmem device calls its ->block_= lost() >>> to find the filesystem which the damaged page located in, and call >>> ->storage_lost() to track files or metadata assocaited with this page= . >>> Finally we are able to try to fix the damaged data in filesystem and = do >> >> Does that mean clearing poison? if so, would you mind to elaborate=20 >> specifically which change does that? >=20 > Recovering data for filesystem (or pmem device) has not been done in=20 > this patchset...=C2=A0 I just triggered the handler for the files shari= ng the=20 > corrupted page here. Thanks! That confirms my understanding. With the framework provided by the patchset, how do you envision it to ease/simplify poison recovery from the user's perspective? And how does it help in dealing with page faults upon poisoned dax page? thanks! -jane