linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Vlastimil Babka <vbabka@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Claudio Imbrenda <imbrenda@linux.ibm.com>,
	Linux MM <linux-mm@kvack.org>,
	Randy Dunlap <rdunlap@infradead.org>
Subject: Re: mm/gup: track FOLL_PIN squash-candidate patches are not squashed (yet?)
Date: Fri, 20 Mar 2020 10:49:53 -0700	[thread overview]
Message-ID: <3be1130a-eca8-e9f8-a3c4-6afb492f639e@nvidia.com> (raw)
In-Reply-To: <887429b4-7b36-9f51-5bbd-0ae47c1156f9@suse.cz>

On 3/20/20 10:22 AM, Vlastimil Babka wrote:
> On 3/19/20 7:04 PM, John Hubbard wrote:
>> Hi Andrew,
>>
>> I see the following commits in linux-next. I'm wondering if all is well, because
>> I understood that these were all going to be squashed into the first commit
>> (3d37f4aceb31), yes?
>>
>> (This is the first time I've participated in the "squash" aspect of linux-mm workflow,
>> as you can probably tell.)
> 
> AFAIK Andrew (or his scripts) does the squashing only at the last moment before
> sending patches to Linus. The mmotm import to -next could do it as well I guess,
> but do you expect a benefit e.g. for bisects?


Squashing would only help very slightly in this case, for bisects. That's because
08baf249e844 fixes a build warning. And I don't think it's necessary to do it any
sooner than usual. I just thought it was accidentally overlooked, because I didn't
know that the squashing is done at the last minute.

All is well, then.

thanks,
-- 
John Hubbard
NVIDIA

> 
>> 08baf249e844 mm-gup-track-foll_pin-pages-fix-2-fix <Andrew Morton>
>> 10a9eb3afdf1 mm/gup: fixup for 9947ea2c1e608e32 "mm/gup: track FOLL_PIN pages" <Claudio Imbrenda>
>> b982245014e1 mm/gup: fixup for ce35133be382 mm/gup: track FOLL_PIN pages <John Hubbard>
>> 3d37f4aceb31 mm/gup: track FOLL_PIN pages <John Hubbard>
>>
>>


  reply	other threads:[~2020-03-20 17:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-19 18:04 mm/gup: track FOLL_PIN squash-candidate patches are not squashed (yet?) John Hubbard
2020-03-20 17:22 ` Vlastimil Babka
2020-03-20 17:49   ` John Hubbard [this message]
2020-03-21  0:43     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3be1130a-eca8-e9f8-a3c4-6afb492f639e@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=imbrenda@linux.ibm.com \
    --cc=linux-mm@kvack.org \
    --cc=rdunlap@infradead.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).