From: Yang Shi <yang.shi@linux.alibaba.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@kernel.org>, Yang Shi <shy828301@gmail.com>,
Huang Ying <ying.huang@intel.com>,
Mel Gorman <mgorman@techsingularity.net>,
kirill.shutemov@linux.intel.com, Hugh Dickins <hughd@google.com>,
Shakeel Butt <shakeelb@google.com>,
william.kucharski@oracle.com,
Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [v2 PATCH] mm: vmscan: correct nr_reclaimed for THP
Date: Tue, 21 May 2019 14:54:10 +0800 [thread overview]
Message-ID: <3c2ef3c2-4d39-11c3-acfa-2a809ca72b3c@linux.alibaba.com> (raw)
In-Reply-To: <20190516151012.GA20038@cmpxchg.org>
> [ check_move_unevictable_pages() seems weird. It gets a pagevec from
> find_get_entries(), which, if I understand the THP page cache code
> correctly, might contain the same compound page over and over. It'll
> be !unevictable after the first iteration, so will only run once. So
> it produces incorrect numbers now, but it is probably best to ignore
> it until we figure out THP cache. Maybe add an XXX comment. ]
The commit 5fd4ca2d84b2 ("mm: page cache: store only head pages in
i_pages") changed how THP is stored in page cache, but
find_get_entries() would return base page by calling find_subpage(), so
check_move_unevictable_pages() should just returns the number of base pages.
prev parent reply other threads:[~2019-05-21 6:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 16:23 [v2 PATCH] mm: vmscan: correct nr_reclaimed for THP Yang Shi
2019-05-13 8:09 ` Michal Hocko
[not found] ` <c3c26c7a-748c-6090-67f4-3014bedea2e6@linux.alibaba.com>
2019-05-13 21:45 ` Michal Hocko
2019-05-14 4:36 ` Yang Shi
2019-05-14 6:20 ` Michal Hocko
2019-05-14 20:44 ` Yang Shi
2019-05-16 15:10 ` Johannes Weiner
2019-05-20 9:43 ` Yang Shi
2019-05-21 3:16 ` Yang Shi
2019-05-21 6:54 ` Yang Shi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c2ef3c2-4d39-11c3-acfa-2a809ca72b3c@linux.alibaba.com \
--to=yang.shi@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=shakeelb@google.com \
--cc=shy828301@gmail.com \
--cc=william.kucharski@oracle.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).