From: John Hubbard <jhubbard@nvidia.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>, <gregkh@linuxfoundation.org>,
<surenb@google.com>, <joaodias@google.com>, <willy@infradead.org>
Subject: Re: [PATCH v2] mm: cma: support sysfs
Date: Mon, 8 Feb 2021 21:18:52 -0800 [thread overview]
Message-ID: <3cf67381-9b5a-56ee-2a8f-047955c84128@nvidia.com> (raw)
In-Reply-To: <YCINNpA09FTwr63U@google.com>
On 2/8/21 8:19 PM, Minchan Kim wrote:
> On Mon, Feb 08, 2021 at 05:57:17PM -0800, John Hubbard wrote:
>> On 2/8/21 3:36 PM, Minchan Kim wrote:
>> ...
>>>>> char name[CMA_MAX_NAME];
>>>>> +#ifdef CONFIG_CMA_SYSFS
>>>>> + struct cma_stat *stat;
>>>>
>>>> This should not be a pointer. By making it a pointer, you've added a bunch of pointless
>>>> extra code to the implementation.
>>>
>>> Originally, I went with the object lifetime with struct cma as you
>>> suggested to make code simple. However, Greg KH wanted to have
>>> release for kobj_type since it is consistent with other kboject
>>> handling.
>>
>> Are you talking about the kobj in your new struct cma_stat? That seems
>> like circular logic if so. I'm guessing Greg just wanted kobj methods
>> to be used *if* you are dealing with kobjects. That's a narrower point.
>>
>> I can't imagine that he would have insisted on having additional
>> allocations just so that kobj freeing methods could be used. :)
>
> I have no objection if Greg agree static kobject is okay in this
> case. Greg?
>
What I meant is, no kobject at all in the struct cma_stat member
variable. The lifetime of the cma_stat member is the same as the
containing struct, so no point in putting a kobject into it.
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2021-02-09 5:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 18:01 [PATCH v2] mm: cma: support sysfs Minchan Kim
2021-02-08 21:34 ` John Hubbard
2021-02-08 23:36 ` Minchan Kim
2021-02-09 1:57 ` John Hubbard
2021-02-09 4:19 ` Minchan Kim
2021-02-09 5:18 ` John Hubbard [this message]
2021-02-09 5:27 ` John Hubbard
2021-02-09 6:13 ` Greg KH
2021-02-09 6:27 ` John Hubbard
2021-02-09 6:34 ` John Hubbard
2021-02-09 6:56 ` Greg KH
2021-02-09 15:55 ` Minchan Kim
2021-02-09 17:49 ` Greg KH
2021-02-09 20:11 ` John Hubbard
2021-02-09 21:13 ` Minchan Kim
2021-02-10 6:43 ` Greg KH
2021-02-10 7:12 ` Minchan Kim
2021-02-10 7:16 ` John Hubbard
2021-02-10 7:26 ` Greg KH
2021-02-10 7:50 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cf67381-9b5a-56ee-2a8f-047955c84128@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=joaodias@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=surenb@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).