From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1F28C432BE for ; Thu, 2 Sep 2021 06:25:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 871E0610CD for ; Thu, 2 Sep 2021 06:25:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 871E0610CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 918A28D0002; Thu, 2 Sep 2021 02:25:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C80C8D0001; Thu, 2 Sep 2021 02:25:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 790268D0002; Thu, 2 Sep 2021 02:25:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id 66C638D0001 for ; Thu, 2 Sep 2021 02:25:41 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4250922BE6 for ; Thu, 2 Sep 2021 06:25:40 +0000 (UTC) X-FDA: 78541647240.19.484DD61 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf08.hostedemail.com (Postfix) with ESMTP id 6578530000A9 for ; Thu, 2 Sep 2021 06:25:39 +0000 (UTC) Received: from dggeme703-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4H0W5q39J2z8xdS; Thu, 2 Sep 2021 14:21:19 +0800 (CST) Received: from [10.174.178.75] (10.174.178.75) by dggeme703-chm.china.huawei.com (10.1.199.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.8; Thu, 2 Sep 2021 14:25:34 +0800 Subject: Re: [PATCH 3/6] mm/page_alloc.c: remove obsolete comment in free_pcppages_bulk() To: Mel Gorman CC: , , , , , References: <20210830141051.64090-1-linmiaohe@huawei.com> <20210830141051.64090-4-linmiaohe@huawei.com> <20210831133830.GE4128@techsingularity.net> <884a4b72-95ab-0fca-6c74-d67535048736@huawei.com> <20210901151411.GH4128@techsingularity.net> From: Miaohe Lin Message-ID: <3cff22e0-760b-1a11-6f28-f257317eba7e@huawei.com> Date: Thu, 2 Sep 2021 14:25:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210901151411.GH4128@techsingularity.net> Content-Type: text/plain; charset="iso-8859-15" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.75] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggeme703-chm.china.huawei.com (10.1.199.99) X-CFilter-Loop: Reflected Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=huawei.com; spf=pass (imf08.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6578530000A9 X-Stat-Signature: z71rggdbk57grsc9hwybf3sfsodgcuty X-HE-Tag: 1630563939-664560 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/9/1 23:14, Mel Gorman wrote: > On Wed, Sep 01, 2021 at 03:49:03PM +0800, Miaohe Lin wrote: >> On 2021/8/31 21:38, Mel Gorman wrote: >>> On Mon, Aug 30, 2021 at 10:10:48PM +0800, Miaohe Lin wrote: >>>> It's also confusing now. Remove it. >>>> >>> >>> Why is the whole comment obsolete? >>> >>> The second two paragraphs about "all pages pinned" and pages_scanned is >>> obsolete and can go but the first paragraph is valid. >>> >> >> I think the first paragraph is invalid due to the below statement: >> "Assumes all pages on list are in same zone, and of same order." >> There are NR_PCP_LISTS lists and PAGE_ALLOC_COSTLY_ORDER + 1 + NR_PCP_THP >> orders in pcp. So I think it's obsolete. >> > > Ah. > >> Should I delete this statement in the first paragraph only? >> > > Remove ", and of same order" Will do this in v2. Thanks. >