From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=N2JQ=FI=kvack.org=owner-linux-mm@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,
	USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id EE403C433FE
	for <linux-mm@archiver.kernel.org>; Fri,  4 Dec 2020 17:43:35 +0000 (UTC)
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by mail.kernel.org (Postfix) with ESMTP id 6B7D422A83
	for <linux-mm@archiver.kernel.org>; Fri,  4 Dec 2020 17:43:35 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B7D422A83
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix)
	id 890196B005C; Fri,  4 Dec 2020 12:43:34 -0500 (EST)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id 819376B005D; Fri,  4 Dec 2020 12:43:34 -0500 (EST)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id 6E0596B006E; Fri,  4 Dec 2020 12:43:34 -0500 (EST)
X-Delivered-To: linux-mm@kvack.org
Received: from forelay.hostedemail.com (smtprelay0223.hostedemail.com [216.40.44.223])
	by kanga.kvack.org (Postfix) with ESMTP id 535166B005C
	for <linux-mm@kvack.org>; Fri,  4 Dec 2020 12:43:34 -0500 (EST)
Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
	by forelay03.hostedemail.com (Postfix) with ESMTP id 14B43824999B
	for <linux-mm@kvack.org>; Fri,  4 Dec 2020 17:43:34 +0000 (UTC)
X-FDA: 77556321948.18.point52_1d080cd273c6
Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251])
	by smtpin18.hostedemail.com (Postfix) with ESMTP id C3502100ED3C8
	for <linux-mm@kvack.org>; Fri,  4 Dec 2020 17:43:33 +0000 (UTC)
X-HE-Tag: point52_1d080cd273c6
X-Filterd-Recvd-Size: 3820
Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143])
	by imf07.hostedemail.com (Postfix) with ESMTP
	for <linux-mm@kvack.org>; Fri,  4 Dec 2020 17:43:32 +0000 (UTC)
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
	id <B5fca75430001>; Fri, 04 Dec 2020 09:43:31 -0800
Received: from [10.26.72.142] (172.20.13.39) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 4 Dec
 2020 17:43:23 +0000
Subject: Re: [PATCH] mm/memblock:use a more appropriate order calculation when
 free memblock pages
To: Marek Szyprowski <m.szyprowski@samsung.com>, Qian Cai <qcai@redhat.com>,
	<carver4lio@163.com>, <rppt@kernel.org>
CC: <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>, Hailong Liu <liu.hailong6@zte.com.cn>,
	Stephen Rothwell <sfr@canb.auug.org.au>, Linux Next Mailing List
	<linux-next@vger.kernel.org>, Bartlomiej Zolnierkiewicz
	<b.zolnierkie@samsung.com>, linux-tegra <linux-tegra@vger.kernel.org>
References: <20201203152311.5272-1-carver4lio@163.com>
 <a5bc444ec40a2248009d0894fda61b822d030235.camel@redhat.com>
 <CGME20201204160751eucas1p13cc7aad8c68dd2a495c4bbf422c4228c@eucas1p1.samsung.com>
 <adc36428-05eb-f885-9394-080cc805818f@samsung.com>
From: Jon Hunter <jonathanh@nvidia.com>
Message-ID: <3d709122-0364-5bca-9247-3f212096b389@nvidia.com>
Date: Fri, 4 Dec 2020 17:43:21 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <adc36428-05eb-f885-9394-080cc805818f@samsung.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
	t=1607103811; bh=IgGdlLuQS16IZLAWFCNIGBVZxQ+IIVFfpXGYwQb1klc=;
	h=Subject:To:CC:References:From:Message-ID:Date:User-Agent:
	 MIME-Version:In-Reply-To:Content-Type:Content-Language:
	 Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy;
	b=FVg+MJmjt2AMhdRUox9urOJdfPsfGxCByjMrp+4uu3Dimtf4Y4VONLwIJtOgWp7Ny
	 bK4V2Q8gpRAfwbBi9TcvjLoUSankrGmH4PpXQxlIBJ7ACszcbLpwJxhsRdbdOXqfZE
	 5C9WKJLEvQVyxvG8uPVfGT6CGVDwXYxCOAv+vguJr5f6Wi73F09U4RX+/0zXPtoi4x
	 TVFHPY/TlJrJGPGLvq+hjKh2Uc8omWEWOCKmXjKOjsva1zwvtWT5FpJ8WB+E/o2Ucn
	 cy++evZ3n6CYkMEkKcRAWztAv8u0fj5CWG9OHobpgsQq9ZS5wi30K0bmvtkWrGLoSM
	 KXwn4ItI/GdaA==
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>


On 04/12/2020 16:07, Marek Szyprowski wrote:
> Hi All,
> 
> On 04.12.2020 14:42, Qian Cai wrote:
>> On Thu, 2020-12-03 at 23:23 +0800, carver4lio@163.com wrote:
>>> From: Hailong Liu <liu.hailong6@zte.com.cn>
>>>
>>> When system in the booting stage, pages span from [start, end] of a memblock
>>> are freed to buddy in a order as large as possible (less than MAX_ORDER) at
>>> first, then decrease gradually to a proper order(less than end) in a loop.
>>>
>>> However, *min(MAX_ORDER - 1UL, __ffs(start))* can not get the largest order
>>> in some cases.
>>> Instead, *__ffs(end - start)* may be more appropriate and meaningful.
>>>
>>> Signed-off-by: Hailong Liu <liu.hailong6@zte.com.cn>
>> Reverting this commit on the top of today's linux-next fixed boot crashes on
>> multiple NUMA systems.
> 
> I confirm. Reverting commit 4df001639c84 ("mm/memblock: use a more 
> appropriate order calculation when free memblock pages") on top of linux 
> next-20201204 fixed booting of my ARM32bit test systems.


FWIW, I also confirm that this is causing several 32-bit Tegra platforms
to crash on boot and reverting this fixes the problem.

Jon

-- 
nvpublic