From: Dmitry Osipenko <digetx@gmail.com>
To: Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
gregkh@linuxfoundation.org, surenb@google.com,
joaodias@google.com, jhubbard@nvidia.com, willy@infradead.org
Subject: Re: [PATCH v6] mm: cma: support sysfs
Date: Wed, 24 Mar 2021 15:33:07 +0300 [thread overview]
Message-ID: <3d90177b-e143-03b9-0f78-77740690266f@gmail.com> (raw)
In-Reply-To: <20210324010547.4134370-1-minchan@kernel.org>
24.03.2021 04:05, Minchan Kim пишет:
> +static struct kobject *cma_kobj_root;
This should be a local variable.
> +static struct kobj_type cma_ktype = {
> + .release = cma_kobj_release,
> + .sysfs_ops = &kobj_sysfs_ops,
> + .default_groups = cma_groups
I'd add a comma to the end, for consistency.
> +};
next prev parent reply other threads:[~2021-03-24 12:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 1:05 [PATCH v6] mm: cma: support sysfs Minchan Kim
2021-03-24 2:34 ` John Hubbard
2021-03-24 3:27 ` Minchan Kim
2021-03-24 4:47 ` John Hubbard
2021-03-24 5:44 ` Minchan Kim
2021-03-24 6:26 ` John Hubbard
2021-03-24 6:57 ` Minchan Kim
2021-03-24 7:10 ` John Hubbard
2021-03-24 12:37 ` Dmitry Osipenko
2021-03-24 15:18 ` Minchan Kim
2021-03-24 12:33 ` Dmitry Osipenko [this message]
2021-03-24 15:12 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d90177b-e143-03b9-0f78-77740690266f@gmail.com \
--to=digetx@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jhubbard@nvidia.com \
--cc=joaodias@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=surenb@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).