From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95CC8C433DB for ; Thu, 4 Mar 2021 18:13:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 17F6F64EFE for ; Thu, 4 Mar 2021 18:13:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17F6F64EFE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 92B0C6B0005; Thu, 4 Mar 2021 13:13:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 902736B0006; Thu, 4 Mar 2021 13:13:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A46A6B0007; Thu, 4 Mar 2021 13:13:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0064.hostedemail.com [216.40.44.64]) by kanga.kvack.org (Postfix) with ESMTP id 5CFE96B0005 for ; Thu, 4 Mar 2021 13:13:41 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 820C740D6 for ; Thu, 4 Mar 2021 18:13:40 +0000 (UTC) X-FDA: 77882989800.30.E2CFA3E Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by imf16.hostedemail.com (Postfix) with ESMTP id 94B86801A838 for ; Thu, 4 Mar 2021 18:13:37 +0000 (UTC) Received: by mail-wr1-f47.google.com with SMTP id j2so15847124wrx.9 for ; Thu, 04 Mar 2021 10:13:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LxB9+vPeZCQGgYfmPoWB4CHgIz+gt8MLqthX/gFqZ3U=; b=B2ooff6kakZeG2uBiJu3XKYQ7mywheQeV3oBzlJ2STyJSNdIAk2QMhBwvZsu4O3N/O 5LwKz/RswGJhuTL7bp6d0odZHMCQZhjOiPUAxS19I9pbJyvMzuX7OozP5///hi134tXH vDmeS7FhNIDlYukW6lUCivl9JJ84OoOMSarfoiKcIV65B93YJtzAMOIkol3Vg9wqZ7k/ 9nl9mDe+fcsLZFZB+y+ebYWUDuWcFXbV1/BbRNG4CDezegCVZSgsqNo09aUhoh88ox7G O8TtBi5MuTXQ2ev35FyCcBN1rLJCbtB77800IjFdAIKve3V32ns9/ttNML/KNXvFkJt9 wVmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LxB9+vPeZCQGgYfmPoWB4CHgIz+gt8MLqthX/gFqZ3U=; b=elxBno1IIiqBwUpbtjk4N83adQrDiHVVJkovS/42tHH4zFyKTC+VeOmba6RljlEQ30 JvC5rMbHtB9DlELwmzCR6YZxCnfTgHtkUoWG2FY3L3aQgQJxxFSZ2b1Boc1XTmTEETlx m2z9/qdQLXq6GJk7lSzQbNlur5xaeUekEdJuKyQ12jBiQd3ldtCY0bFvULCg7R8t80s0 pLOR8p888keEFRCnd+gnt56KYSRvhdZqu4DNh4itETcV5UgoMUA5KQ6woewciegTrayJ Lr3iV3N3VHifGjsgnQg27lGz8k6zlUiZwXefjSKDAADCuybvkGE8Axk07jPpjzpfVlhu 6eyg== X-Gm-Message-State: AOAM5325kEHug5ONJES/K4ASurW756YtYcmlgyxfcwJpf5fp5t8Il8T2 No4OI5oG8v/BNejm0BusfAM= X-Google-Smtp-Source: ABdhPJwckwo0GuaE3KN/vJPzU1CQ5l0n3JCR/c2i5MOh6U1hAxklMv0L4htnvQr7tAFHSZXLfbhHzg== X-Received: by 2002:adf:f144:: with SMTP id y4mr5391618wro.408.1614881611301; Thu, 04 Mar 2021 10:13:31 -0800 (PST) Received: from [192.168.1.143] ([170.253.51.130]) by smtp.gmail.com with ESMTPSA id i26sm378258wmb.18.2021.03.04.10.13.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Mar 2021 10:13:30 -0800 (PST) Subject: Re: [PATCH 1/4] userfaultfd.2: Add UFFD_FEATURE_THREAD_ID docs To: Peter Xu Cc: Mike Rapoport , Nadav Amit , linux-kernel@vger.kernel.org, Linux MM Mailing List , Axel Rasmussen , Andrea Arcangeli , Andrew Morton , Michael Kerrisk , linux-man@vger.kernel.org References: <20210304015947.517713-1-peterx@redhat.com> <20210304015947.517713-2-peterx@redhat.com> <20210304155019.GX397383@xz-x1> From: "Alejandro Colomar (man-pages)" Message-ID: <3e96f127-5dd0-28f7-4b86-1bf4e623bd06@gmail.com> Date: Thu, 4 Mar 2021 19:13:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210304155019.GX397383@xz-x1> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 94B86801A838 X-Stat-Signature: tamhdoe9fbhpwu75cwohqq4cbr5rp9fh Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf16; identity=mailfrom; envelope-from=""; helo=mail-wr1-f47.google.com; client-ip=209.85.221.47 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614881617-552636 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Peter, On 3/4/21 4:50 PM, Peter Xu wrote: > On Thu, Mar 04, 2021 at 10:22:18AM +0100, Alejandro Colomar (man-pages) wrote: >>> +.BR UFFD_FEATURE_THREAD_ID >> >> This should use [.B] and not [.BR]. >> .BR is for alternate Bold and Roman. >> .B is for bold. >> >> (There are more appearances of this in the other patches.) > > Yeah I got a bit confused when differenciating those two, since I also see > similar usage, e.g.: > > .BR O_CLOEXEC Yes, these are minor imperfections that got into the manual pages, and we don't remove them due to the churn that it would create (and possibility of introducing other bugs while doing such a big scripted change that couldn't be easily reviewed (thousands of lines)). So as we still have those lines, they tend to confuse. > > I'll fix all of them appeared in current patchset. Let me know if you also > want me to fix all the existing uses of ".BR" too where ".B" would suffice. > Otherwise I won't touch them since I can't say they're wrong either (I think > most of them should generate the same output with either ".BR" or ".B" if > there's only one word?). Our current non-written guidelines are: We are fixing the existing ones as we modify code near them, but leave untouched code that is far from what we are changing, even on the same page. Thanks, Alex -- Alejandro Colomar Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/ http://www.alejandro-colomar.es/