From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B787C433E1 for ; Tue, 7 Jul 2020 14:33:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1AEEF2063A for ; Tue, 7 Jul 2020 14:33:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="XZ1WuhDV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AEEF2063A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B6BEE8D0009; Tue, 7 Jul 2020 10:33:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF4076B0071; Tue, 7 Jul 2020 10:33:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E3248D0009; Tue, 7 Jul 2020 10:33:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0018.hostedemail.com [216.40.44.18]) by kanga.kvack.org (Postfix) with ESMTP id 88AC36B0070 for ; Tue, 7 Jul 2020 10:33:02 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 452B03489 for ; Tue, 7 Jul 2020 14:33:02 +0000 (UTC) X-FDA: 77011521804.30.hole91_2e16c9b26eb5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 1A895180B3C98 for ; Tue, 7 Jul 2020 14:33:02 +0000 (UTC) X-HE-Tag: hole91_2e16c9b26eb5 X-Filterd-Recvd-Size: 4073 Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Jul 2020 14:33:01 +0000 (UTC) Received: by mail-il1-f193.google.com with SMTP id r12so28956843ilh.4 for ; Tue, 07 Jul 2020 07:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=t2REejmbIqx/5hvdnEI6PCmIhL36dOj62WbnFSfaaQ0=; b=XZ1WuhDVQiSrLfIP0FKympvpl4bstkObpCbL6vF76IHkWc88bmgy4outeSIQtQRzkO fvV5SM/sjwKJMxXuPnpmx7ChxWsU8RGUvHXoZwwll69eLf38WeC52qnqs2tizWWzn2nJ PK6WitSB6Rp1aufZLLpbBRtLukXuuH38zejhFnlRXXHkq9ZY20OxAgeoXWukMRHgYoLD nL6JpT+wulFHnOWD2uBPay0hGewQXP88h2iyz+nRS+9K3Vsl4WhgES0M+fVauNW4LEZr cZGE9iCQAptiNRJCYPXcPYgzRoYPjcX7KKW6MRmTdD4zIkpnbzPpyEygbBA5YgeLvLJM bIXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=t2REejmbIqx/5hvdnEI6PCmIhL36dOj62WbnFSfaaQ0=; b=KNx5F/Fovvh46VlFWmiwqipd728ruJjWBsMYEae6ovTE92wIiDKtbaP9/wbUnHLOAl oHHgmzunr2E9XmzAuuMjY+SvHH2kKHZK3RI+7Z8Yi2+YpB+BpoMDEn8plgeLM+4VxuVC YyfvccJCthlaYk6dSDKjs/33DHywx+Benj1WQuolO+YPv5Cj5V6XLCNKw76TxiSMhc2h LX4tt9WF/axhWgQKt9pCqVnQjibJFvyO48vJua1wwgC2ZJ3FYy6VLmfFQiTzuKN8z4GH 3BUqqmkPK9L3TwoekY5j/J+CA9cqUEnkSr0mkVQRopmMtKpHWBBDhOEEd6qUWobMWVca enLw== X-Gm-Message-State: AOAM531oXOGqhxL45ADFPyLkcibKU0PMwtbEkAjv9uqY0gPZHlaN37Jz 7YnSJNNKaSDBmFb2NGDAKqQWRw== X-Google-Smtp-Source: ABdhPJzexj9+QX9mdPcyCoEq+eUXGvYhTdzOtduCkU5WgZNqqvlj/pcwEI8lt/jRRuhiaNbafQfRuA== X-Received: by 2002:a05:6e02:f85:: with SMTP id v5mr29994311ilo.31.1594132380754; Tue, 07 Jul 2020 07:33:00 -0700 (PDT) Received: from [192.168.1.58] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id z78sm13494303ilk.72.2020.07.07.07.32.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jul 2020 07:33:00 -0700 (PDT) Subject: Re: [PATCH 07/15] mm: add support for async page locking To: =?UTF-8?Q?Andreas_Gr=c3=bcnbacher?= Cc: io-uring@vger.kernel.org, Linux FS-devel Mailing List , Linux Kernel Mailing List , Linux-MM , Andrew Morton , Johannes Weiner References: <20200618144355.17324-1-axboe@kernel.dk> <20200618144355.17324-8-axboe@kernel.dk> From: Jens Axboe Message-ID: <3eb94b6c-eebd-8c0d-fe29-365df50b8949@kernel.dk> Date: Tue, 7 Jul 2020 08:32:59 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Rspamd-Queue-Id: 1A895180B3C98 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/7/20 5:32 AM, Andreas Gr=C3=BCnbacher wrote: >> @@ -2131,6 +2166,11 @@ ssize_t generic_file_buffered_read(struct kiocb= *iocb, >> } >> >> readpage: >> + if (iocb->ki_flags & IOCB_NOWAIT) { >> + unlock_page(page); >> + put_page(page); >> + goto would_block; >> + } >=20 > This hunk should have been part of "mm: allow read-ahead with > IOCB_NOWAIT set" ... It probably should have... Oh well, it's been queued up multiple weeks at this point, not worth rebasing to move this hunk. --=20 Jens Axboe