From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8509C432C0 for ; Sun, 17 Nov 2019 10:45:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 337E820727 for ; Sun, 17 Nov 2019 10:45:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B5YitETa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 337E820727 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7EDC26B0003; Sun, 17 Nov 2019 05:45:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 79E326B0006; Sun, 17 Nov 2019 05:45:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B3E26B0007; Sun, 17 Nov 2019 05:45:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0217.hostedemail.com [216.40.44.217]) by kanga.kvack.org (Postfix) with ESMTP id 552C76B0003 for ; Sun, 17 Nov 2019 05:45:53 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id E7EC7181AEF15 for ; Sun, 17 Nov 2019 10:45:52 +0000 (UTC) X-FDA: 76165438944.14.sand32_5062dffc3113c X-HE-Tag: sand32_5062dffc3113c X-Filterd-Recvd-Size: 9054 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Sun, 17 Nov 2019 10:45:52 +0000 (UTC) Received: by mail-pl1-f194.google.com with SMTP id o9so7918827plk.6 for ; Sun, 17 Nov 2019 02:45:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=4ORcz+bx6CmjhRirtnOqR+mHH7rxyxlrSDROFxIw33s=; b=B5YitETaZCZxQoqGdjBo6Mz29gJA2h70R8VI19tgbhPL6u22OWGrs3719BET6hCL3G Y/u9Daz7Y/xp0LbmnTQr9f/dbyBbUlawdi2uAjjc4X/Est4fb8MWOuJFCUpHh2xJsZPW 4+Ki01qy/9R7EqJsBhQiuGaK8zHWksFk9y/hRJDVKm6dgwRzqeFohTj4XEr4TbN6ady6 MmMb1+uajwyj1OcRvFvFjX58mwosbDSpqghcgVmVj8Tahlu+N8EhSImVMrtp3chLyHJ7 nwNonApZuBwFubL8sQ2S5XT6h/4SPz9edldTe20VEktOe7guzu31bQE7aW3W22RL/iZX P75Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=4ORcz+bx6CmjhRirtnOqR+mHH7rxyxlrSDROFxIw33s=; b=OmBNU1OT2wDguG1u82VOZxb1HJqsKB4GsUwFg7/Rd5NulS23MU29tDanEwt8+gn3HI 9vRYyUqfe3u7qR4drqcEwYw+lImZ6mktPbDUgPNacXo9KYQilbY7ZVLKdCZVW+u/cxVo +2QmwmtY6Ef72j9GNcNX5hEo3PlSLLX9xm4NFQkA2fHvaFaj3bEcnHfaPj1igm2EmAF1 uydNreunmgLStF3tDCDY3W7I44k39B/4wzd5PwlClTSNPh/myqHYq+2Qh1wOVmQOBYl0 zjGwYiGn+J8nVGBvPvEJ4t2FOTBnhY6szBrqml++NlEMyTe1ZeydhDvJumAE2qFXmvFz w4Cg== X-Gm-Message-State: APjAAAUDnD25YyA0BJaYY/FvaNF8C4EuZ3jpka2ypyyAsDbjM/68/aTc e9zUTakKQXybrhPNCs2xIA== X-Google-Smtp-Source: APXvYqxc5KWH6y2CHBoIG+toaMImgAqayT5EAdvMPy5n/R/cWxIjLVh6OftEKu9M35W7orloP8zk9A== X-Received: by 2002:a17:902:8bc8:: with SMTP id r8mr24729857plo.189.1573987551234; Sun, 17 Nov 2019 02:45:51 -0800 (PST) Received: from [172.24.28.130] ([203.100.54.194]) by smtp.gmail.com with ESMTPSA id r28sm3877658pgk.75.2019.11.17.02.45.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Nov 2019 02:45:50 -0800 (PST) Subject: Re: [PATCH v8 5/9] hugetlb: disable region_add file_region coalescing To: Mina Almasry , mike.kravetz@oracle.com Cc: shuah@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, cgroups@vger.kernel.org, aneesh.kumar@linux.vnet.ibm.com References: <20191030013701.39647-1-almasrymina@google.com> <20191030013701.39647-5-almasrymina@google.com> From: Wenkuan Wang Message-ID: <3ee3b463-97b4-c499-e6ac-3a3c25547c57@gmail.com> Date: Sun, 17 Nov 2019 18:45:46 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191030013701.39647-5-almasrymina@google.com> Content-Type: multipart/alternative; boundary="------------29CF3FD91D78A4108B9B4D06" Content-Language: en-US X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This is a multi-part message in MIME format. --------------29CF3FD91D78A4108B9B4D06 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/30/19 9:36 AM, Mina Almasry wrote: > +} > + > /* Must be called with resv->lock held. Calling this with count_only =3D= =3D true > * will count the number of pages to be added but will not modify the li= nked > - * list. > + * list. If regions_needed !=3D NULL and count_only =3D=3D true, then = regions_needed > + * will indicate the number of file_regions needed in the cache to car= ry out to > + * add the regions for this range. > */ > static long add_reservation_in_range(struct resv_map *resv, long f, lon= g t, Hi=C2=A0 Mina, Would you please share which tree this patch set used? this patch 5/9 can= 't be applied with Linus's tree and add_reservation_in_range can't be fou= nd. Thanks Wenkuan > - bool count_only) > + long *regions_needed, bool count_only) > { > - long chg =3D 0; > + long add =3D 0; > struct list_head *head =3D &resv->regions; > + long last_accounted_offset =3D f; > struct file_region *rg =3D NULL, *trg =3D NULL, *nrg =3D NULL; > - /* Locate the region we are before or in. */ > - list_for_each_entry (rg, head, link) > - if (f <=3D rg->to) > - break; --------------29CF3FD91D78A4108B9B4D06 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 PGh0bWw+CiAgPGhlYWQ+CiAgICA8bWV0YSBodHRwLWVxdWl2PSJDb250ZW50LVR5cGUiIGNv bnRlbnQ9InRleHQvaHRtbDsgY2hhcnNldD1VVEYtOCI+CiAgPC9oZWFkPgogIDxib2R5IHRl eHQ9IiMwMDAwMDAiIGJnY29sb3I9IiNGRkZGRkYiPgogICAgPHA+PGJyPgogICAgPC9wPgog ICAgPGRpdiBjbGFzcz0ibW96LWNpdGUtcHJlZml4Ij5PbiAxMC8zMC8xOSA5OjM2IEFNLCBN aW5hIEFsbWFzcnkKICAgICAgd3JvdGU6PGJyPgogICAgPC9kaXY+CiAgICA8YmxvY2txdW90 ZSB0eXBlPSJjaXRlIgogICAgICBjaXRlPSJtaWQ6MjAxOTEwMzAwMTM3MDEuMzk2NDctNS1h bG1hc3J5bWluYUBnb29nbGUuY29tIj4KICAgICAgPHByZSBjbGFzcz0iZGlmZnMiPjxkaXYg Y2xhc3M9ImFkZGxpbmUiIHRpdGxlPSJiL21tL2h1Z2V0bGIuYzoyNjYiPit9IDwvZGl2Pjxk aXYgY2xhc3M9ImFkZGxpbmUiIHRpdGxlPSJiL21tL2h1Z2V0bGIuYzoyNjciPisgPC9kaXY+ PGRpdiBjbGFzcz0ic3RlYWR5bGluZSIgdGl0bGU9Im9sZDogYS9tbS9odWdldGxiLmM6MjQ3 LCBuZXc6IGIvbW0vaHVnZXRsYi5jOjI2OCI+IC8qIE11c3QgYmUgY2FsbGVkIHdpdGggcmVz di0mZ3Q7bG9jayBoZWxkLiBDYWxsaW5nIHRoaXMgd2l0aCBjb3VudF9vbmx5ID09IHRydWUg PC9kaXY+PGRpdiBjbGFzcz0ic3RlYWR5bGluZSIgdGl0bGU9Im9sZDogYS9tbS9odWdldGxi LmM6MjQ4LCBuZXc6IGIvbW0vaHVnZXRsYi5jOjI2OSI+ICAqIHdpbGwgY291bnQgdGhlIG51 bWJlciBvZiBwYWdlcyB0byBiZSBhZGRlZCBidXQgd2lsbCBub3QgbW9kaWZ5IHRoZSBsaW5r ZWQgPC9kaXY+PGRpdiBjbGFzcz0iZGVsbGluZSIgdGl0bGU9ImEvbW0vaHVnZXRsYi5jOjI0 OSI+LSAqIGxpc3QuIDwvZGl2PjxkaXYgY2xhc3M9ImFkZGxpbmUiIHRpdGxlPSJiL21tL2h1 Z2V0bGIuYzoyNzAiPisgKiBsaXN0LiBJZiByZWdpb25zX25lZWRlZCAhPSBOVUxMIGFuZCBj b3VudF9vbmx5ID09IHRydWUsIHRoZW4gcmVnaW9uc19uZWVkZWQgPC9kaXY+PGRpdiBjbGFz cz0iYWRkbGluZSIgdGl0bGU9ImIvbW0vaHVnZXRsYi5jOjI3MSI+KyAqIHdpbGwgaW5kaWNh dGUgdGhlIG51bWJlciBvZiBmaWxlX3JlZ2lvbnMgbmVlZGVkIGluIHRoZSBjYWNoZSB0byBj YXJyeSBvdXQgdG8gPC9kaXY+PGRpdiBjbGFzcz0iYWRkbGluZSIgdGl0bGU9ImIvbW0vaHVn ZXRsYi5jOjI3MiI+KyAqIGFkZCB0aGUgcmVnaW9ucyBmb3IgdGhpcyByYW5nZS4gPC9kaXY+ PGRpdiBjbGFzcz0ic3RlYWR5bGluZSIgdGl0bGU9Im9sZDogYS9tbS9odWdldGxiLmM6MjUw LCBuZXc6IGIvbW0vaHVnZXRsYi5jOjI3MyI+ICAqLyA8L2Rpdj48ZGl2IGNsYXNzPSJzdGVh ZHlsaW5lIiB0aXRsZT0ib2xkOiBhL21tL2h1Z2V0bGIuYzoyNTEsIG5ldzogYi9tbS9odWdl dGxiLmM6Mjc0Ij4gc3RhdGljIGxvbmcgYWRkX3Jlc2VydmF0aW9uX2luX3JhbmdlKHN0cnVj dCByZXN2X21hcCAqcmVzdiwgbG9uZyBmLCBsb25nIHQsIDwvZGl2PjwvcHJlPgogICAgPC9i bG9ja3F1b3RlPgogICAgPGJyPgogICAgPHA+SGnCoCBNaW5hLDwvcD4KICAgIDxwPldvdWxk IHlvdSBwbGVhc2Ugc2hhcmUgd2hpY2ggdHJlZSB0aGlzIHBhdGNoIHNldCB1c2VkPyB0aGlz IHBhdGNoCiAgICAgIDUvOSBjYW4ndCBiZSBhcHBsaWVkIHdpdGggTGludXMncyB0cmVlIGFu ZAogICAgICBhZGRfcmVzZXJ2YXRpb25faW5fcmFuZ2UgY2FuJ3QgYmUgZm91bmQuPGJyPgog ICAgICA8YnI+CiAgICAgIFRoYW5rczxicj4KICAgICAgV2Vua3Vhbjxicj4KICAgIDwvcD4K ICAgIDxwPjxicj4KICAgIDwvcD4KICAgIDxibG9ja3F1b3RlIHR5cGU9ImNpdGUiCiAgICAg IGNpdGU9Im1pZDoyMDE5MTAzMDAxMzcwMS4zOTY0Ny01LWFsbWFzcnltaW5hQGdvb2dsZS5j b20iPgogICAgICA8cHJlIGNsYXNzPSJkaWZmcyI+PGRpdiBjbGFzcz0iZGVsbGluZSIgdGl0 bGU9ImEvbW0vaHVnZXRsYi5jOjI1MiI+LSAgICAgICAgICAgICAgICAgICAgIGJvb2wgY291 bnRfb25seSkgPC9kaXY+PGRpdiBjbGFzcz0iYWRkbGluZSIgdGl0bGU9ImIvbW0vaHVnZXRs Yi5jOjI3NSI+KyAgICAgICAgICAgICAgICAgICAgIGxvbmcgKnJlZ2lvbnNfbmVlZGVkLCBi b29sIGNvdW50X29ubHkpIDwvZGl2PjxkaXYgY2xhc3M9InN0ZWFkeWxpbmUiIHRpdGxlPSJv bGQ6IGEvbW0vaHVnZXRsYi5jOjI1MywgbmV3OiBiL21tL2h1Z2V0bGIuYzoyNzYiPiB7IDwv ZGl2PjxkaXYgY2xhc3M9ImRlbGxpbmUiIHRpdGxlPSJhL21tL2h1Z2V0bGIuYzoyNTQiPi0g ICAgbG9uZyBjaGcgPSAwOyA8L2Rpdj48ZGl2IGNsYXNzPSJhZGRsaW5lIiB0aXRsZT0iYi9t bS9odWdldGxiLmM6Mjc3Ij4rICAgIGxvbmcgYWRkID0gMDsgPC9kaXY+PGRpdiBjbGFzcz0i c3RlYWR5bGluZSIgdGl0bGU9Im9sZDogYS9tbS9odWdldGxiLmM6MjU1LCBuZXc6IGIvbW0v aHVnZXRsYi5jOjI3OCI+ICAgICBzdHJ1Y3QgbGlzdF9oZWFkICpoZWFkID0gJmFtcDtyZXN2 LSZndDtyZWdpb25zOyA8L2Rpdj48ZGl2IGNsYXNzPSJhZGRsaW5lIiB0aXRsZT0iYi9tbS9o dWdldGxiLmM6Mjc5Ij4rICAgIGxvbmcgbGFzdF9hY2NvdW50ZWRfb2Zmc2V0ID0gZjsgPC9k aXY+PGRpdiBjbGFzcz0ic3RlYWR5bGluZSIgdGl0bGU9Im9sZDogYS9tbS9odWdldGxiLmM6 MjU2LCBuZXc6IGIvbW0vaHVnZXRsYi5jOjI4MCI+ICAgICBzdHJ1Y3QgZmlsZV9yZWdpb24g KnJnID0gTlVMTCwgKnRyZyA9IE5VTEwsICpucmcgPSBOVUxMOyA8L2Rpdj48ZGl2IGNsYXNz PSJzdGVhZHlsaW5lIiB0aXRsZT0ib2xkOiBhL21tL2h1Z2V0bGIuYzoyNTcsIG5ldzogYi9t bS9odWdldGxiLmM6MjgxIj4gIDwvZGl2PjxkaXYgY2xhc3M9ImRlbGxpbmUiIHRpdGxlPSJh L21tL2h1Z2V0bGIuYzoyNTgiPi0gICAgLyogTG9jYXRlIHRoZSByZWdpb24gd2UgYXJlIGJl Zm9yZSBvciBpbi4gKi8gPC9kaXY+PGRpdiBjbGFzcz0iZGVsbGluZSIgdGl0bGU9ImEvbW0v aHVnZXRsYi5jOjI1OSI+LSAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5IChyZywgaGVhZCwgbGlu aykgPC9kaXY+PGRpdiBjbGFzcz0iZGVsbGluZSIgdGl0bGU9ImEvbW0vaHVnZXRsYi5jOjI2 MCI+LSAgICAgICAgaWYgKGYgJmx0Oz0gcmctJmd0O3RvKSA8L2Rpdj48ZGl2IGNsYXNzPSJk ZWxsaW5lIiB0aXRsZT0iYS9tbS9odWdldGxiLmM6MjYxIj4tICAgICAgICAgICAgYnJlYWs7 IDwvZGl2PjwvcHJlPgogICAgPC9ibG9ja3F1b3RlPgogIDwvYm9keT4KPC9odG1sPgo= --------------29CF3FD91D78A4108B9B4D06--