From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EA0FC4338F for ; Tue, 27 Jul 2021 13:07:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 318A261351 for ; Tue, 27 Jul 2021 13:07:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 318A261351 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B7F906B0036; Tue, 27 Jul 2021 09:07:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B30606B005D; Tue, 27 Jul 2021 09:07:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1EB08D0001; Tue, 27 Jul 2021 09:07:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0211.hostedemail.com [216.40.44.211]) by kanga.kvack.org (Postfix) with ESMTP id 8533C6B0036 for ; Tue, 27 Jul 2021 09:07:56 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2B6B41838A439 for ; Tue, 27 Jul 2021 13:07:56 +0000 (UTC) X-FDA: 78408395352.05.5A02ACC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id A37F1801E4C3 for ; Tue, 27 Jul 2021 13:07:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627391275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w27FqEEzIo3p1pqQTsABPQPt0pRYrqGioLXGPQQlu9I=; b=jG1x4TagE7gckZg+cEs2rMFv14ASHFAsfumQpLdtMNfEqfF4Q6OSxJxckcTkBFZLaLOZhT 3ZCe0gNcWkgz4G0iShprNkPhECguBbYoBs7QhVn73QHDzv+KeINe50Q9obd8bjn3sJPLMv yUAxF2C9dEuOjUADbdH5IsWQtNTBNzo= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-346-vVEO43HJPFCG1T3QDMVnrQ-1; Tue, 27 Jul 2021 09:07:46 -0400 X-MC-Unique: vVEO43HJPFCG1T3QDMVnrQ-1 Received: by mail-wr1-f69.google.com with SMTP id n1-20020a5d59810000b029013cd60e9baaso5985263wri.7 for ; Tue, 27 Jul 2021 06:07:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=w27FqEEzIo3p1pqQTsABPQPt0pRYrqGioLXGPQQlu9I=; b=JuRIjRpoVCZTmEPZy0b8b22UJGNbUHGSD12dTeMZjIuzjqbEVhYvDc0tcojVnWhNyA 33yB2RTGZvNce6Ffw7utOiW4Np1y6Cn0PePGg6GgSg4rII9Ju/OCFURgf7GLPm82xDBC fVIaFW9O0/9RqcrfH2tAXaaRxDa+bY4FjUxgQa/EP/YiLG29GmKPAHjOIHJS+BOTFyme rxnovV/2k8OVflVYOWTQedrArvgzpglseQ7FS2BqxNECq7U6EeQhryLreVP/3dsT557E OpJzw4xu6FhXNyzwmDmZQsI9U7N8jwtdzmE914pq4ksDlEoXN2zMIY9+8BVDt9NWH3dB arkg== X-Gm-Message-State: AOAM533sHaCsT6VIrd0jsW1tx5eKAu8lF893WSFFYS34th3Yo0FURjOv 1wX3xjSNl9TNR9ERiVSYuULmT50TsH3qbcEc+7W6i4KMWPDm8zMHKwUbUr59I5mUICO4H7wZ63w yn6SYWvAa1oY= X-Received: by 2002:a1c:f206:: with SMTP id s6mr21529349wmc.102.1627391264940; Tue, 27 Jul 2021 06:07:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWjpyUyo8S8+eNmr9lyosQnP8ZTHZMsxVPWiLQeiNi7RY4xegkDTqMqM3ie4KoWW69mMgsxQ== X-Received: by 2002:a1c:f206:: with SMTP id s6mr21529328wmc.102.1627391264724; Tue, 27 Jul 2021 06:07:44 -0700 (PDT) Received: from [192.168.3.132] (p4ff23c36.dip0.t-ipconnect.de. [79.242.60.54]) by smtp.gmail.com with ESMTPSA id v15sm2936674wmj.39.2021.07.27.06.07.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jul 2021 06:07:44 -0700 (PDT) Subject: Re: [linux-next:master 3368/3379] mm/memory_hotplug.c:748:33: error: no member named 'cma_pages' in 'struct zone' To: kernel test robot Cc: clang-built-linux@googlegroups.com, kbuild-all@lists.01.org, Linux Memory Management List , Mark Brown , Andrew Morton References: <202107272115.MJoFlUGY-lkp@intel.com> From: David Hildenbrand Organization: Red Hat Message-ID: <4544731a-8a0c-ca5d-c54a-f99a3e8fe078@redhat.com> Date: Tue, 27 Jul 2021 15:07:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <202107272115.MJoFlUGY-lkp@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jG1x4Tag; spf=none (imf06.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A37F1801E4C3 X-Stat-Signature: 8hoj7qote8qdcn7wedw8zhbfypqixtuk X-HE-Tag: 1627391275-40964 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 27.07.21 15:05, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 2265c5286967c58db9a99ed1b74105977507e690 > commit: 2f10893f9329c568c5090f01d115230471320389 [3368/3379] mm/memory_hotplug: introduce "auto-movable" online policy > config: x86_64-randconfig-a014-20210726 (attached as .config) > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project c658b472f3e61e1818e1909bf02f3d65470018a5) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install x86_64 cross compiling tool for clang build > # apt-get install binutils-x86-64-linux-gnu > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2f10893f9329c568c5090f01d115230471320389 > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout 2f10893f9329c568c5090f01d115230471320389 > # save the attached .config to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=x86_64 SHELL=/bin/bash > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > >>> mm/memory_hotplug.c:748:33: error: no member named 'cma_pages' in 'struct zone' > stats->movable_pages += zone->cma_pages; > ~~~~ ^ > mm/memory_hotplug.c:750:38: error: no member named 'cma_pages' in 'struct zone' > stats->kernel_early_pages -= zone->cma_pages; > ~~~~ ^ > 2 errors generated. > > > vim +748 mm/memory_hotplug.c > > 737 > 738 static void auto_movable_stats_account_zone(struct auto_movable_stats *stats, > 739 struct zone *zone) > 740 { > 741 if (zone_idx(zone) == ZONE_MOVABLE) { > 742 stats->movable_pages += zone->present_pages; > 743 } else { > 744 /* > 745 * CMA pages (never on hotplugged memory) behave like > 746 * ZONE_MOVABLE. > 747 */ > > 748 stats->movable_pages += zone->cma_pages; > 749 stats->kernel_early_pages += zone->present_early_pages; > 750 stats->kernel_early_pages -= zone->cma_pages; > 751 } > 752 } > 753 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org > Already reported on mmtom: https://lkml.kernel.org/r/5394da5e-29f0-ff7d-e614-e2805400a8bb@redhat.com diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index bfdaa28eb86f..fa1a0afd32ba 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -741,13 +741,15 @@ static void auto_movable_stats_account_zone(struct auto_movable_stats *stats, if (zone_idx(zone) == ZONE_MOVABLE) { stats->movable_pages += zone->present_pages; } else { + stats->kernel_early_pages += zone->present_early_pages; +#ifdef CONFIG_CMA /* * CMA pages (never on hotplugged memory) behave like * ZONE_MOVABLE. */ stats->movable_pages += zone->cma_pages; - stats->kernel_early_pages += zone->present_early_pages; stats->kernel_early_pages -= zone->cma_pages; +#endif /* CONFIG_CMA */ } } struct auto_movable_group_stats { -- Thanks, David / dhildenb