From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E852CC433FE for ; Tue, 8 Dec 2020 00:45:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9483023A04 for ; Tue, 8 Dec 2020 00:45:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9483023A04 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0C5968D0002; Mon, 7 Dec 2020 19:45:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0761A8D0001; Mon, 7 Dec 2020 19:45:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECD868D0002; Mon, 7 Dec 2020 19:45:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0137.hostedemail.com [216.40.44.137]) by kanga.kvack.org (Postfix) with ESMTP id D7B2E8D0001 for ; Mon, 7 Dec 2020 19:45:22 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 9FD5C180AD804 for ; Tue, 8 Dec 2020 00:45:22 +0000 (UTC) X-FDA: 77568271284.07.hate34_3c017cc273e2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 7E71C1803F9A4 for ; Tue, 8 Dec 2020 00:45:22 +0000 (UTC) X-HE-Tag: hate34_3c017cc273e2 X-Filterd-Recvd-Size: 4521 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Tue, 8 Dec 2020 00:45:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Sender: Reply-To:Cc:Content-ID:Content-Description; bh=z4nhkVHGdLgG6UYZT44p/Vv/98uc1oAVtyG19MrBtHI=; b=rSB/G5i9meD+pjqI0BSJN9sm/P A1y/vuxsjMB69CPlBoFKYooG4t7918SnhULpt/wQYY5i7ZFZHqtbkwjV2QVj9Q93MqbDP/q4xLehh 4IpoK9OticNmftDiPn6fw2K4CUNigZ+UDXEuJM7SRdA/h2HytRJpQB/yVGouWtGx+X+s52XGQ53AP eclNimY47xF7HzoBgZPh+S4KQcmn7qHg83fShdAMEsLbdM6aQZCFQgfH7eiSx2cigtzxwkWK1wWfD iqcfRXZ+kysLmgqQI93e8wrDDAKhGIMHtMnf29ZuB2/Qlo+D7Gp4fidyXwqSh/3EyJcD6XkNMnkyB A8BfzBmQ==; Received: from [2601:1c0:6280:3f0::1494] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmR80-0008Ad-GI; Tue, 08 Dec 2020 00:45:16 +0000 Subject: Re: [patch 01/12] zlib: export S390 symbols for zlib modules To: Zaslonko Mikhail , Andrew Morton , borntraeger@de.ibm.com, gor@linux.ibm.com, hca@linux.ibm.com, iii@linux.ibm.com, linux-mm@kvack.org, lkp@intel.com, mm-commits@vger.kernel.org, torvalds@linux-foundation.org References: <20201206061438.EIlu-Bvu8%akpm@linux-foundation.org> <13e195ba-413a-ebba-ea90-c3a15ad514ea@linux.ibm.com> From: Randy Dunlap Message-ID: <45544373-754c-ad37-e020-f4864b963852@infradead.org> Date: Mon, 7 Dec 2020 16:45:09 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <13e195ba-413a-ebba-ea90-c3a15ad514ea@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/7/20 1:03 AM, Zaslonko Mikhail wrote: > Hello, > > should we probably put these to lib/zlib_dfltcc/dfltcc_syms.c along with the other EXPORT_SYMBOL statements? Hi, I didn't know about that file. :) That change makes sense. At least that's how some modules used to do it. Not so much nowadays, but this one might as well consistent within itself. Do you want to fix it or should I? Thanks. > Reviewed-by: Mikhail Zaslonko > > On 06.12.2020 07:14, Andrew Morton wrote: >> From: Randy Dunlap >> Subject: zlib: export S390 symbols for zlib modules >> >> Fix build errors when ZLIB_INFLATE=m and ZLIB_DEFLATE=m and ZLIB_DFLTCC=y >> by exporting the 2 needed symbols in dfltcc_inflate.c. >> >> Fixes these build errors: >> >> ERROR: modpost: "dfltcc_inflate" [lib/zlib_inflate/zlib_inflate.ko] undefined! >> ERROR: modpost: "dfltcc_can_inflate" [lib/zlib_inflate/zlib_inflate.ko] undefined! >> >> Link: https://lkml.kernel.org/r/20201123191712.4882-1-rdunlap@infradead.org >> Fixes: 126196100063 ("lib/zlib: add s390 hardware support for kernel zlib_inflate") >> Signed-off-by: Randy Dunlap >> Reported-by: kernel test robot >> Acked-by: Ilya Leoshkevich >> Cc: Mikhail Zaslonko >> Cc: Heiko Carstens >> Cc: Vasily Gorbik >> Cc: Christian Borntraeger >> Signed-off-by: Andrew Morton >> --- >> >> lib/zlib_dfltcc/dfltcc_inflate.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> --- a/lib/zlib_dfltcc/dfltcc_inflate.c~zlib-export-s390-symbols-for-zlib-modules >> +++ a/lib/zlib_dfltcc/dfltcc_inflate.c >> @@ -4,6 +4,7 @@ >> #include "dfltcc_util.h" >> #include "dfltcc.h" >> #include >> +#include >> #include >> >> /* >> @@ -29,6 +30,7 @@ int dfltcc_can_inflate( >> return is_bit_set(dfltcc_state->af.fns, DFLTCC_XPND) && >> is_bit_set(dfltcc_state->af.fmts, DFLTCC_FMT0); >> } >> +EXPORT_SYMBOL(dfltcc_can_inflate); >> >> static int dfltcc_was_inflate_used( >> z_streamp strm >> @@ -147,3 +149,4 @@ dfltcc_inflate_action dfltcc_inflate( >> return (cc == DFLTCC_CC_OP1_TOO_SHORT || cc == DFLTCC_CC_OP2_TOO_SHORT) ? >> DFLTCC_INFLATE_BREAK : DFLTCC_INFLATE_CONTINUE; >> } >> +EXPORT_SYMBOL(dfltcc_inflate); >> _ >> -- ~Randy Reported-by: Randy Dunlap