From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0564C6FD1D for ; Mon, 20 Mar 2023 15:01:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FF626B0074; Mon, 20 Mar 2023 11:01:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AF3A6B0078; Mon, 20 Mar 2023 11:01:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 350976B007B; Mon, 20 Mar 2023 11:01:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 22C026B0074 for ; Mon, 20 Mar 2023 11:01:49 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C09541C6614 for ; Mon, 20 Mar 2023 15:01:47 +0000 (UTC) X-FDA: 80589591054.25.89CB011 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 6DF64C0022 for ; Mon, 20 Mar 2023 15:01:45 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SXlk5dfi; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679324505; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RRLo27GlsnaXOlM604FxZs8z99IITo0Vh+vZehLWrQY=; b=M3ShW3DWEFoh5XB9GrI++jQnfDUi3SRWYc82G+FTHx3ojqgzcEDUtrEDc++3XOQoBKQZA+ B8qE986/HY0f6n3g30G0KLSz499i/exBJoogSZAhDvJuHfi9jxW8Q82IB05/FaxgnC3Ra7 3LYAQzZUPJ8uS+rnw5HmFbRKfKm3sao= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SXlk5dfi; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679324505; a=rsa-sha256; cv=none; b=1H2LYTsZnNVDNL3FVB2Z75xkZhmJT0KSvxIxKER3dcaIyyCspNcVrSz6JRk5n22B6jQ2ZZ U/Hd5lXl5WPILei9dEgFC302UDz4aCmWa+GAWDGm+gilubsCY7+wzWSvZXA4f2oFDePWJ4 hlNtSzGevSo5/vNlp3rQDKeB+cyuBhE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679324504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RRLo27GlsnaXOlM604FxZs8z99IITo0Vh+vZehLWrQY=; b=SXlk5dfibTlHiVDq6t/g0fiSsDGdYmfNsTqt+SuwxBsScZPjV52t1Imu6FFlbe83dwXFNb Dt4IHb2BaP64YkS9ma3ehv4T+uulL5R3zs0pZMyGAFbu5piUtUP8VkFUQdGdP0uWfJQcCP WgAscB5qoYepFaJPF90IA1dkfRgNphE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-9ZcMzTlMPbq0QdbxyIHbnQ-1; Mon, 20 Mar 2023 11:01:42 -0400 X-MC-Unique: 9ZcMzTlMPbq0QdbxyIHbnQ-1 Received: by mail-wm1-f72.google.com with SMTP id j13-20020a05600c190d00b003ed26189f44so8575886wmq.8 for ; Mon, 20 Mar 2023 08:01:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679324501; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RRLo27GlsnaXOlM604FxZs8z99IITo0Vh+vZehLWrQY=; b=jz8HMgN+3O5/SuEjWRij0MpNJ4i8LYIpsPFfMIFk+nQ5qP7KoCsPrVuVStZGZvpEbK RznfdDHensvmqb8U3edL3Yvjwb4kls69rno8aFwpW5hruc9zipKZjjrREzdiTpFgKlw1 ddr/HjviCYfYJjMuix3vPcobD6aUvbzdjbDW2/PhSttNNbzRTvvBTnja/d9T1YGwQR1O Cxl7zG/CzCqNM612Uhoi+huMFbjMDLThGwOWTyaW3CyE+KZQv84yzGydCy/SepcwINDk 0/bs/UptNrn+kkN9KAfEeWSc+1oeSUoIez8UtkL51GOCMgpz9H8XbBBNMtDezSrIEh/A FGyw== X-Gm-Message-State: AO0yUKUE2n7RhByQobzQsK+MTpxIvhlXIRuDZnH2I8mKUmkFgTWkWDd3 67c6wbkm0p35uABC2E/DAhfJeznoKnsY7mWDDWTp7/tppI5xr3F76dx9P1rQIxajciC7VoR2n4N u0FjyvY2N3qE= X-Received: by 2002:a05:600c:a4c:b0:3dc:d5c:76d9 with SMTP id c12-20020a05600c0a4c00b003dc0d5c76d9mr35551087wmq.0.1679324501084; Mon, 20 Mar 2023 08:01:41 -0700 (PDT) X-Google-Smtp-Source: AK7set+Rv9ADJ0RLrT3u7b/PN3mJMTqyoZ1JFg/0Z64iMZgTe0nU39Ivpjcl6439Qs4YPquJhUtMqw== X-Received: by 2002:a05:600c:a4c:b0:3dc:d5c:76d9 with SMTP id c12-20020a05600c0a4c00b003dc0d5c76d9mr35551066wmq.0.1679324500767; Mon, 20 Mar 2023 08:01:40 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:4100:a064:1ded:25ec:cf2f? (p200300cbc7024100a0641ded25eccf2f.dip0.t-ipconnect.de. [2003:cb:c702:4100:a064:1ded:25ec:cf2f]) by smtp.gmail.com with ESMTPSA id f1-20020a1c6a01000000b003edcc2223c6sm5981913wmc.28.2023.03.20.08.01.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 08:01:40 -0700 (PDT) Message-ID: <460b50d3-579c-5dfa-7c1b-531cc9b1c2d5@redhat.com> Date: Mon, 20 Mar 2023 16:01:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 2/2] selftests/mm: Smoke test UFFD_FEATURE_WP_UNPOPULATED To: Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Nadav Amit , Axel Rasmussen , Paul Gofman , Muhammad Usama Anjum , Mike Rapoport , Andrea Arcangeli , Andrew Morton References: <20230309223711.823547-1-peterx@redhat.com> <20230309223711.823547-3-peterx@redhat.com> <4ab36009-51c0-6583-4948-b267f8fbf32a@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 5enyq1t17um4m11aq8i4w3gggr4gd1bw X-Rspamd-Queue-Id: 6DF64C0022 X-HE-Tag: 1679324505-154374 X-HE-Meta: U2FsdGVkX18SwEHHpft9USOP6F3xPhks7MLvpHDM63Zb4VoWpuDb9UnChIJlMETnZ8dJAzgzmG3SVCIl8ICMGffSAebQJU+nm2tumKB34HBgJT1zhKy2A5mOLvYs6OieH8GnFJ5P9cGDkFjJtQqd3AT0uOArwm7dZ+hqyUmuaOOK1fomWYLkn8DVUt9S2v28QRJR5c8hSJV6/i3bGZ2fMpeXMU1DFcdZGxAYgD04oRoP2UM+DOiFZOhoHR0oxzZFrD0o+BAaLf1IN2YDNf4iXqVZ4qYgBhrqyjh6s/RNKBWp7yYnQGC730mBdqnigYMP7Vm/DyUpcypcIPsQaI31IOaxT5NZcpF95FQOodwO2wUcsOADuqbqz69LEB5r2cXUgZWOyLCISmfk1XLTFRljLd9t8Wa/oUV1g/jUDKDSEwE2Bb/gf02lM5MmH1ZgaOepM40sDg3Ykh/TguGF69LaipjjmzmXfrJgLnnjAvcIPQlsrpb2+cKlUXzPVmmb0b5dbG1AMIeKtijWTeGGsgCmMTXXWga/PJNi0l1N96qdRFiJhbgS+HGCoowu6Ciqsx+t4iWYYe68lwZ5ElHMxA5MEKxaufug6z/oAmbPy13XVkSqZqvGYT/NRah7xnHt4QZdlLzUrAzTptLOOAFDMob1UO6B2M+b2ASipI5WqxQaXzggmTGnsm3uiredHJccRPdBlPIr6kMYZG6Ng2/yVCaTF+UkO+LKDIr+cleSPc3jAwDBkwpuWJUFbeIRMyKyU09l1JzJWQVSH6m2cqpKezQsehNetftwQQWnOa4MShvYoaBQX0un3I1TVAdZUJwW9JANyBLkJ9/NHvkoaPRLMQrNMubgP75iJyWXNNGXSaYtEDAxeNyFpO4Pr5GuLYAHVIBKDi6ZU1rviRB/IjxuJO+tll1/Y43h3nTI6XntsGq8p3euv3SoUdpmAo7DJVNDgCtg8gLwyCK8qxCiIyh5N3A +0D4rt8S LRIb2dO7IcDX8ozCaeAe/CZvXwoX5FwQN9ZMEVR61kd7Kf1Pv3oun6kZRJTpST4wv2/2B8pD5GMBvcBVigXLtoLoHglSuNlYISo9jvRkvr11QAxkdRPyy7+gnozE4qt7iJcYoi84LjdpW34Hr3i9b6azH6x8itYypmKgg+zEvg/BV6FQghbrtUdvWvsieScKDe7EkG3cu51PeXqu9iIwIbQ/fOxSVNk2CAYNh5mNmK/nRzbdZ9LKdND1CH2s8XuOoqA1TN3aAsWGfA5f9II4WRuHBuMaOrDASF+KX+UP6hkV6RVQV70Ut2s+qETAu3UkrPuINDjuupuu2T8Esw+BRdzINSGHmzreJ57OIgaRLD3sMWORJCCW5XiJQ2PhdeAWs5Zx02rMWBTTtvvO40ScSN6ArlQa7inilV/1iPUqML60hmB0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20.03.23 15:43, Peter Xu wrote: > On Mon, Mar 20, 2023 at 11:25:43AM +0100, David Hildenbrand wrote: >> On 09.03.23 23:37, Peter Xu wrote: >>> Enable it by default on the stress test, and add some smoke tests for the >>> pte markers on anonymous. >> >> Would it make sense to make kernel support optional and test both paths -- >> once with the feature enabled (if available on the kernel we're testing) and >> once with the feature disabled? > > Yeah, I think the current uffd selftest is not friendly to old kernels so I > made it simple - IOW the test should fail already on old kernels AFAIK. > Maybe I can prepare some patches this week or next to cleanup some parts of > it. Some people to tend to run upstream selftests on older kernels, but I guess this is not high priority. Can always be added on top. -- Thanks, David / dhildenb