From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82B9AC43141 for ; Thu, 21 Nov 2019 22:25:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 440FB206D7 for ; Thu, 21 Nov 2019 22:25:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="QiiyQjBd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 440FB206D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CF7226B039D; Thu, 21 Nov 2019 17:25:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CA8066B039E; Thu, 21 Nov 2019 17:25:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6F9F6B039F; Thu, 21 Nov 2019 17:25:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0238.hostedemail.com [216.40.44.238]) by kanga.kvack.org (Postfix) with ESMTP id A0EEA6B039D for ; Thu, 21 Nov 2019 17:25:16 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 55ADB180AD837 for ; Thu, 21 Nov 2019 22:25:16 +0000 (UTC) X-FDA: 76181716632.01.cry82_10d5d7ebd2c0f X-HE-Tag: cry82_10d5d7ebd2c0f X-Filterd-Recvd-Size: 5429 Received: from hqemgate14.nvidia.com (hqemgate14.nvidia.com [216.228.121.143]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 Nov 2019 22:25:15 +0000 (UTC) Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 21 Nov 2019 14:25:17 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Thu, 21 Nov 2019 14:25:13 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Thu, 21 Nov 2019 14:25:13 -0800 Received: from [10.2.168.213] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 21 Nov 2019 22:25:13 +0000 Subject: Re: [PATCH v7 05/24] mm: devmap: refactor 1-based refcounting for ZONE_DEVICE pages To: Dan Williams CC: Christoph Hellwig , Andrew Morton , Al Viro , Alex Williamson , Benjamin Herrenschmidt , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Christoph Hellwig , Daniel Vetter , Dave Chinner , David Airlie , "David S . Miller" , Ira Weiny , Jan Kara , Jason Gunthorpe , Jens Axboe , Jonathan Corbet , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Magnus Karlsson , Mauro Carvalho Chehab , Michael Ellerman , Michal Hocko , Mike Kravetz , Paul Mackerras , Shuah Khan , Vlastimil Babka , , Maling list - DRI developers , KVM list , , Linux Doc Mailing List , linux-fsdevel , , "Linux-media@vger.kernel.org" , linux-rdma , linuxppc-dev , Netdev , Linux MM , LKML References: <20191121071354.456618-1-jhubbard@nvidia.com> <20191121071354.456618-6-jhubbard@nvidia.com> <20191121080555.GC24784@lst.de>

From: John Hubbard X-Nvconfidentiality: public Message-ID: <461d6611-0cfb-dd13-f827-0db1ff8a9f2d@nvidia.com> Date: Thu, 21 Nov 2019 14:22:24 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1574375117; bh=D/eKIo+FJi5bpXqwJfXr6PJt8uCFLnCZclyeodxgmoA=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=QiiyQjBd99PA4tfLyLMiUlQLWaGQU2+co6FamS71fAjNe7NqeNYDH8w7d2wRbOpAp FO2FB4fRVvM6b8p6VFBEfZcwYG6pgVEpA9JmE6+ROgRRGxXCqZY/+YxPczpJznwImd p6u80IPFPE4x/PJetPMB9IpPtmHNp690Ig3KD/FI3Pg1Spw0uK9yY10oBbvhOlh90u VDHu/ArBa3unFu4nkBBDe7Ce1Uz+1D/XrvQ7tfArBFBClI1tdcdtAK+LKBrbmv90AQ ydolBZYKkzfeBhYUC0ZjSrXWwqBfaUR0ElhSrvf057yQhGgjhUwUU8jj5KSdyTH5QE YNZVYalLmeVQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/21/19 8:59 AM, Dan Williams wrote: > On Thu, Nov 21, 2019 at 12:57 AM John Hubbard wrote: >> >> On 11/21/19 12:05 AM, Christoph Hellwig wrote: >>> So while this looks correct and I still really don't see the major >>> benefit of the new code organization, especially as it bloats all >>> put_page callers. >>> >>> I'd love to see code size change stats for an allyesconfig on this >>> commit. >>> >> >> Right, I'm running that now, will post the results. (btw, if there is >> a script and/or standard format I should use, I'm all ears. I'll dig >> through lwn...) >> > > Just run: > > size vmlinux > Beautiful. I thought it would involve a lot more. Here's results: linux.git (Linux 5.4-rc8+): ============================================== text data bss dec hex filename 227578032 213267935 76877984 517723951 1edbd72f vmlinux With patches 4 and 5 applied to linux.git: ========================================== text data bss dec hex filename 229698560 213288379 76853408 519840347 1efc225b vmlinux Analysis: ========= This increased the size of text by 0.93%. Which is a measurable bloat, so the inlining really is undesirable here, yes. I'll do it differently. thanks, -- John Hubbard NVIDIA