From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47BB7C433EF for ; Fri, 28 Jan 2022 11:22:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD7726B0071; Fri, 28 Jan 2022 06:22:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A87DC6B0072; Fri, 28 Jan 2022 06:22:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94F0C6B0073; Fri, 28 Jan 2022 06:22:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0157.hostedemail.com [216.40.44.157]) by kanga.kvack.org (Postfix) with ESMTP id 818736B0071 for ; Fri, 28 Jan 2022 06:22:04 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3FA29181DA094 for ; Fri, 28 Jan 2022 11:22:04 +0000 (UTC) X-FDA: 79079456568.24.3AB5066 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf04.hostedemail.com (Postfix) with ESMTP id B688040031 for ; Fri, 28 Jan 2022 11:22:03 +0000 (UTC) Received: by mail-lf1-f42.google.com with SMTP id z19so11019735lfq.13 for ; Fri, 28 Jan 2022 03:22:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=Vvp4f8p4kJgg8RYCX/3wsqIxKNWP+tFC5nwJxihACm0=; b=n+TaXA2TQr+391SxSP/W6CjVk+2AurlJiYBG3Ujsuzr6ZvwZUaVsESp8vJmzlUq7E/ C+mWzJdmhRdVLglrWLOlNWCzYA0VmVif35hQvQ/+gq63Ko2kgDX9sxWPxl4yo0rqe4wN GR7QoW0cL8Y+AZvVMl+B68M13bhbd8pEHqkBBR2bi2eHHP9imlvMDrUuwc7Tcmtj3Z0M 1uOw2LQWmAreUiuHCIbyRH2qI+8MAbPi24ckMIQgcTzXek9plvt3V7f0t8MxpF+fW1FR q24VB7pR9cQRt4hKoXarsAj5jTpTLIbkEBedHK50DEcwqQEtVcfGV3fk8a7iFdSn6vpN a6cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=Vvp4f8p4kJgg8RYCX/3wsqIxKNWP+tFC5nwJxihACm0=; b=xHk53S15UvBPs8n3J+ZWGTYBFJ8AsjXrggWxAu2+qDYiaNHUM7rkl+G+pi+lIVkweL IbXIV7xX9ppdaCVVeiX481LYrGs5u2WWLSl4arBRygefpNMzYwJN6x17XorUXg/5mUOn AaLyIWJz8sr4VY9eDn8wST8VmOhWZMSkiqAimGXsbY2p/NscLGuZy0XNXhfawUFxDl5Y h4qiMZSUuV4Ve5xhNy9uMAGrQnlwxLh2LbJQWP0pyghmSWgp7fsp+YejPxuxhv2efFsb kfe8TDSIu3sw02CI5xjLBlyzO3TuaO8ZpMDTmphzSkUz6+V97gIrA1y5lwnjUQZbNTQC fO9Q== X-Gm-Message-State: AOAM532Le1/DmHamullICGCZzk8UKrzXXyY9z86t0mGWuFKmawrdlKPd H4DtHGhWyw16ysD26mGtAs4= X-Google-Smtp-Source: ABdhPJwuE6zDiUEvL/Y8p7G3dV6j4q1w9Z3XuqS9tg6dNyEwXVv9IBZUu8Ci7UMujF2vhAJ6wGSMQA== X-Received: by 2002:a05:6512:3984:: with SMTP id j4mr5972535lfu.388.1643368922164; Fri, 28 Jan 2022 03:22:02 -0800 (PST) Received: from ?IPv6:2a00:f41:80ea:4a21:823:c5ac:f37f:2677? ([2a00:f41:80ea:4a21:823:c5ac:f37f:2677]) by smtp.gmail.com with ESMTPSA id b12sm1692675lfj.228.2022.01.28.03.22.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jan 2022 03:22:01 -0800 (PST) Message-ID: <48499a57afb3d27df26b39aa4255b4ba583c1148.camel@gmail.com> Subject: Re: [PATCH 07/16] tools/include: Add io.h stub From: Karolina Drobnik To: Matthew Wilcox Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mike.rapoport@gmail.com, linux-kernel@vger.kernel.org Date: Fri, 28 Jan 2022 12:21:59 +0100 In-Reply-To: References: <2d9aa000afe81b45157617664134b871207c2067.1643206612.git.karolinadrobnik@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: B688040031 X-Stat-Signature: fwr5qk81j39g7poamd4h3nt5h893xnjf Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=n+TaXA2T; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of karolinadrobnik@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=karolinadrobnik@gmail.com X-Rspam-User: nil X-HE-Tag: 1643368923-605457 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.021735, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 2022-01-27 at 14:09 +0000, Matthew Wilcox wrote: > On Thu, Jan 27, 2022 at 02:21:25PM +0100, Karolina Drobnik wrote: > > Add a dummy io.h header. >=20 > Rather begs the question of what memblock.c needs from linux/io.h. >=20 > Wouldn't it be better to: >=20 > +++ b/mm/memblock.c > @@ -18,7 +18,6 @@ > =C2=A0#include >=20 > =C2=A0#include > -#include >=20 > =C2=A0#include "internal.h" >=20 That was something I considered in the very beginning, but didn't have a chance to verify it works for all architectures. I can take a look after I'm finished with other v2 changes. > (allmodconfig on x86-64 builds fine with this; I have not done an > extended sweep of other arches / build options).