From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ED35C433ED for ; Wed, 12 May 2021 13:12:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 99433613CF for ; Wed, 12 May 2021 13:12:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99433613CF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C35076B0036; Wed, 12 May 2021 09:12:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE5306B006E; Wed, 12 May 2021 09:12:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5ED46B0070; Wed, 12 May 2021 09:12:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0089.hostedemail.com [216.40.44.89]) by kanga.kvack.org (Postfix) with ESMTP id 896DB6B0036 for ; Wed, 12 May 2021 09:12:35 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 22D83A2D5 for ; Wed, 12 May 2021 13:12:35 +0000 (UTC) X-FDA: 78132618270.31.43A42AE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf01.hostedemail.com (Postfix) with ESMTP id F0FD2500153D for ; Wed, 12 May 2021 13:12:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620825153; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xkUtsmXhTln8ZuCPuyfmYtBmjG5e9wQzlcCwa1mE9Fg=; b=hIJS1Va3Gm4e1Pc/x8mHHeEgDo0xwprFOpxfLtk0IReJzXEPXuNEujtpzdmEBcUXUhaP0F UBoqE97poFXLzQ5EYAdp01ocjHU0AtOY5u+NpJFQa58DEm+wnP3vfKhCKMqUsZ7NtfocNX uZt+K573cCTx4bGu3AWxlOuTe8yJxRQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-299-RvIhEIZkNPSeiEIZWt4B0Q-1; Wed, 12 May 2021 09:12:29 -0400 X-MC-Unique: RvIhEIZkNPSeiEIZWt4B0Q-1 Received: by mail-wm1-f70.google.com with SMTP id o10-20020a05600c4fcab029014ae7fdec90so1404629wmq.5 for ; Wed, 12 May 2021 06:12:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=xkUtsmXhTln8ZuCPuyfmYtBmjG5e9wQzlcCwa1mE9Fg=; b=ksUpxMr4Mp2Z96lftPtowMSiMTwTEBv35ZZpDKV0JtYvwCZ6+QViyF04O4RuQpHteX SIQeLKRg+gYi04TmIUDLI7td6clLX6yCfPSNO+HPgZtLgx7TVB7eZMULBcIQRmCWRvNq 8Bn1CNQFwv3JhlwFWxCrCxsfOv70Ntt1+KUPiEUQ54N2Ck4iW/n3WyPOwXzsGV/GWkau Qq3KCAwmxW/6XnaU+BXv+q6+e9PSb+/SRaU4I/00iyvgwI+aLrTn9bmuUh+wcmGi/CXu kj5U2QIqxVtnvbM4GLoewyhNUuRfD21yWIYrAAR48Re4EEsWI5b/AXous3XO4+uLnhQ8 gC1A== X-Gm-Message-State: AOAM530DoLzaGjamV2RG9lWjywbwXfJ35GB8850B+LWT5Y/WHN+wU95s VWGL+XI2R6f/aFqwUoLpEizJMdGw6rZNAQn5DRgNaIq8e+kJd78ytZVQnE9H7lSFfTX1bDisFtO RBQaXt8iAGfQ8RWCR8yuBj18mktMracl4OBm1Z4hx4XMBcjYR7qjf2Iwr+QA= X-Received: by 2002:adf:cc85:: with SMTP id p5mr44985788wrj.75.1620825148672; Wed, 12 May 2021 06:12:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyN/bKM7tb3kGzV/c5fUH9I6/yF7gfmWH2UTCxgDB167HFBRdbQPq3VIR//MAPGfKngYzQmzw== X-Received: by 2002:adf:cc85:: with SMTP id p5mr44985731wrj.75.1620825148402; Wed, 12 May 2021 06:12:28 -0700 (PDT) Received: from [192.168.3.132] (p5b0c65ab.dip0.t-ipconnect.de. [91.12.101.171]) by smtp.gmail.com with ESMTPSA id z5sm1439367wrn.69.2021.05.12.06.12.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 May 2021 06:12:27 -0700 (PDT) Subject: Re: [PATCH v1 2/3] binfmt: remove in-tree usage of MAP_EXECUTABLE To: linux-kernel@vger.kernel.org, Andrew Morton Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Alexander Viro , Peter Zijlstra , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Kees Cook , "Eric W. Biederman" , Greg Ungerer , Mike Rapoport , Catalin Marinas , Kevin Brodsky , Michal Hocko , Feng Tang , Don Zickus , x86@kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20210421093453.6904-1-david@redhat.com> <20210421093453.6904-3-david@redhat.com> From: David Hildenbrand Organization: Red Hat Message-ID: <49a8cb62-e26d-a351-937e-6fb62a6f4a2e@redhat.com> Date: Wed, 12 May 2021 15:12:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210421093453.6904-3-david@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: F0FD2500153D Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hIJS1Va3; spf=none (imf01.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam04 X-Stat-Signature: a6c1e1sfkuekan7kgjwo74yy3u8gz94n Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf01; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620825150-371377 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.04.21 11:34, David Hildenbrand wrote: > Ever since commit e9714acf8c43 ("mm: kill vma flag VM_EXECUTABLE and > mm->num_exe_file_vmas"), VM_EXECUTABLE is gone and MAP_EXECUTABLE is > essentially completely ignored. Let's remove all usage of > MAP_EXECUTABLE. > > Signed-off-by: David Hildenbrand [...] > +++ b/fs/binfmt_aout.c > @@ -222,7 +222,7 @@ static int load_aout_binary(struct linux_binprm * bprm) > > error = vm_mmap(bprm->file, N_TXTADDR(ex), ex.a_text, > PROT_READ | PROT_EXEC, > - MAP_FIXED | MAP_PRIVATE | MAP_DENYWRITE | MAP_EXECUTABLE, > + MAP_FIXED | MAP_PRIVATE | MAP_DENYWRITE; As reported by kernel test robot, this line should end with a "," > fd_offset); > > if (error != N_TXTADDR(ex)) > @@ -230,7 +230,7 @@ static int load_aout_binary(struct linux_binprm * bprm) > > error = vm_mmap(bprm->file, N_DATADDR(ex), ex.a_data, > PROT_READ | PROT_WRITE | PROT_EXEC, > - MAP_FIXED | MAP_PRIVATE | MAP_DENYWRITE | MAP_EXECUTABLE, > + MAP_FIXED | MAP_PRIVATE | MAP_DENYWRITE; > fd_offset + ex.a_text); dito @Andrew, I think this resides your tree. Can you fix that up or shall I resend the series, or only this individual patch? -- Thanks, David / dhildenb