From: William Kucharski <william.kucharski@oracle.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Matthew Wilcox <willy@infradead.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
Song Liu <songliubraving@fb.com>,
Bob Kasten <robert.a.kasten@intel.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Chad Mynhier <chad.mynhier@oracle.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Johannes Weiner <jweiner@fb.com>
Subject: Re: [PATCH v5 2/2] mm,thp: Add experimental config option RO_EXEC_FILEMAP_HUGE_FAULT_THP
Date: Tue, 3 Sep 2019 21:23:34 -0600 [thread overview]
Message-ID: <4AB1ABA7-B659-41B7-8364-132AD3608FA6@oracle.com> (raw)
In-Reply-To: <20190903191528.GC14028@dhcp22.suse.cz>
> On Sep 3, 2019, at 1:15 PM, Michal Hocko <mhocko@kernel.org> wrote:
>
> Then I would suggest mentioning all this in the changelog so that the
> overall intention is clear. It is also up to you fs developers to find a
> consensus on how to move forward. I have brought that up mostly because
> I really hate seeing new config options added due to shortage of
> confidence in the code. That really smells like working around standard
> code quality inclusion process.
I do mention a good deal of this in the blurb in part [0/2] of the patch,
though I don't cover the readpage/readpages() debate. Ideally readpage()
should do just that, read a page, based on the size of the page passed,
and not assume "page" means "PAGESIZE."
I can also make the "help" text for the option more descriptive if
desired.
Thanks for your comments!
prev parent reply other threads:[~2019-09-04 3:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 9:23 [PATCH v5 0/2] mm,thp: Add filemap_huge_fault() for THP William Kucharski
2019-09-02 9:23 ` [PATCH v5 1/2] mm: Allow the page cache to allocate large pages William Kucharski
2019-09-03 11:57 ` Michal Hocko
2019-09-03 12:11 ` Matthew Wilcox
2019-09-03 12:19 ` Michal Hocko
2019-09-03 16:28 ` Matthew Wilcox
2019-09-03 19:18 ` Michal Hocko
2019-09-04 3:30 ` William Kucharski
2019-09-04 8:28 ` Michal Hocko
2019-09-02 9:23 ` [PATCH v5 2/2] mm,thp: Add experimental config option RO_EXEC_FILEMAP_HUGE_FAULT_THP William Kucharski
2019-09-03 12:14 ` Michal Hocko
2019-09-03 12:22 ` Matthew Wilcox
2019-09-03 12:51 ` Michal Hocko
2019-09-03 15:10 ` Matthew Wilcox
2019-09-03 19:15 ` Michal Hocko
2019-09-04 3:23 ` William Kucharski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB1ABA7-B659-41B7-8364-132AD3608FA6@oracle.com \
--to=william.kucharski@oracle.com \
--cc=chad.mynhier@oracle.com \
--cc=dave.hansen@linux.intel.com \
--cc=jweiner@fb.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=robert.a.kasten@intel.com \
--cc=songliubraving@fb.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).