From: Joe Perches <joe@perches.com>
To: Kirill Tkhai <ktkhai@virtuozzo.com>,
Markus Elfring <Markus.Elfring@web.de>,
Andrew Morton <akpm@linux-foundation.org>,
Muchun Song <songmuchun@bytedance.com>,
Xiongchun Duan <duanxiongchun@bytedance.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
David Hildenbrand <david@redhat.com>,
Yang Shi <yang.shi@linux.alibaba.com>
Subject: Re: [PATCH v4] mm/ksm: Fix NULL pointer dereference when KSM zero page is enabled
Date: Thu, 16 Apr 2020 13:05:54 -0700 [thread overview]
Message-ID: <4a40bfcf1c964bbb9b68a8b7c467a5a770907e4a.camel@perches.com> (raw)
In-Reply-To: <e620f913-d0fb-7d48-b6b2-d4c6b433b563@virtuozzo.com>
On Thu, 2020-04-16 at 14:20 +0300, Kirill Tkhai wrote:
> On 16.04.2020 09:14, Markus Elfring wrote:
> > …
> > > > +++ b/mm/ksm.c
> > > > @@ -2112,8 +2112,15 @@ static void cmp_and_merge_page(struct page *page, struct rmap_item *rmap_item)
> > …
> > > > + if (vma)
> > > > + err = try_to_merge_one_page(vma, page,
> > > > + ZERO_PAGE(rmap_item->address));
> > > > + else
> > > > + /**
> > > > + * If the vma is out of date, we do not need to
> > > > + * continue.
trivia:
It's generally better to not use "/**" as that's used for kernel-doc
and this could be a single line like
+ /* If the vma is out of date, no need to continue */
> > > It's conventional to put braces around multi-line blocks such as this.
true
> > Are there different views to consider around the usage of single statements
> > together with curly brackets in if branches?
no
next prev parent reply other threads:[~2020-04-16 20:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 2:50 [PATCH v4] mm/ksm: Fix NULL pointer dereference when KSM zero page is enabled Muchun Song
2020-04-16 2:58 ` Andrew Morton
2020-04-16 6:14 ` Markus Elfring
2020-04-16 11:20 ` Kirill Tkhai
2020-04-16 20:05 ` Joe Perches [this message]
2020-04-16 6:00 ` Markus Elfring
2020-04-16 11:21 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a40bfcf1c964bbb9b68a8b7c467a5a770907e4a.camel@perches.com \
--to=joe@perches.com \
--cc=Markus.Elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=duanxiongchun@bytedance.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=songmuchun@bytedance.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).