From: David Hildenbrand <david@redhat.com>
To: Miaohe Lin <linmiaohe@huawei.com>,
akpm@linux-foundation.org, mike.kravetz@oracle.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/hugetlb: use some helper functions to cleanup code
Date: Wed, 10 Feb 2021 09:35:13 +0100 [thread overview]
Message-ID: <4bb381fc-eae5-effd-214d-8d62e66da272@redhat.com> (raw)
In-Reply-To: <20210210065346.21958-1-linmiaohe@huawei.com>
On 10.02.21 07:53, Miaohe Lin wrote:
> We could use pages_per_huge_page to get the number of pages per hugepage,
> use get_hstate_idx to calculate hstate index, and use hstate_is_gigantic
> to check if a hstate is gigantic to make code more succinct.
>
Another suggestion, please collect and group your cleanups for a
subsystem and send them in a single cleanup patch series where possible.
Again, makes life easier for reviewers and maintainers.
Thanks!
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-02-10 8:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 6:53 [PATCH] mm/hugetlb: use some helper functions to cleanup code Miaohe Lin
2021-02-10 8:35 ` David Hildenbrand [this message]
2021-02-10 8:51 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bb381fc-eae5-effd-214d-8d62e66da272@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).