From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1E1BC678D4 for ; Wed, 1 Mar 2023 23:39:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 455786B0078; Wed, 1 Mar 2023 18:39:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 404BA6B007B; Wed, 1 Mar 2023 18:39:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F3A06B007D; Wed, 1 Mar 2023 18:39:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1BE336B0078 for ; Wed, 1 Mar 2023 18:39:31 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DAE1A140337 for ; Wed, 1 Mar 2023 23:39:30 +0000 (UTC) X-FDA: 80521948500.28.C893952 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf18.hostedemail.com (Postfix) with ESMTP id B194B1C000A for ; Wed, 1 Mar 2023 23:39:28 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=M8aeZF+K; spf=pass (imf18.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677713969; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/tVo57dTKDbe9oIYhZ1AXrz0gnvuKQwnJzuFrK+2aA4=; b=kb0qEyLbn5UGgaI+BwqmgVudBTDoEo57tXpCSfm6ohrIksCXWzgy+lQDZoAdiXJxXYVKzZ nTik85i8jZxJDrw3njm+VKOJ4zH77rreSQFo2RQRP3Pg88+bKJqGPWPZdtdrgH8M6+7vub SK5pMcyW0SYOUEjUIg+BOsg/YV1xxRM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=M8aeZF+K; spf=pass (imf18.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677713969; a=rsa-sha256; cv=none; b=aySA87gplNjXBxvEhvbcmpda0UucBN+Csn6WSbQVphiPARN+9S1yi1h18iWsD4HaNlCrSc H4/Iw3zMFs96Ny1EqX6t38KQDK5pysPPa4QNynZFftOTdUF37FcPQQZGphao3NKrETI+QW f1q0j6vuIh93/AEdWnZJUqXvuB1PGXM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677713968; x=1709249968; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=+dcuSCOUvlfWlgKnuNOG5M7WjDU7LQAEWia+60P3lYo=; b=M8aeZF+KsRWIAtk+m4Wc7plygwUrOAEsNKbK+j9d57HBnaZy4ZtxlHdb FabYA73WAnnNBG9wBG0rOTFDzKBRZqJ1QyL1euGrZGL0pCO5oZ7zkB/3l jw35q337qIFAPiuA464xthpDnpQbiPGc3uAPKe/l78x4KgUHag7SuP3ed Xrse+UkTgzKtRhjnH4mgCkhFGn8TOe0BDnVp++zau5b7FgeLWCdkx9pBZ 16U1GLdJCtB1kv/zR/p+ttIy8jEbwVp/0P1qszFt0HSfxypUmZ8jB6DSk Q0eOXvfXhbajOtLSJqE8oQyUJ7zeM4/wnpJsTvJUWQLq2d0vA+c2CxSIy Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10636"; a="420819154" X-IronPort-AV: E=Sophos;i="5.98,225,1673942400"; d="scan'208";a="420819154" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2023 15:39:23 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10636"; a="738827318" X-IronPort-AV: E=Sophos;i="5.98,225,1673942400"; d="scan'208";a="738827318" Received: from asaha3-mobl1.amr.corp.intel.com (HELO [10.251.12.67]) ([10.251.12.67]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2023 15:39:21 -0800 Message-ID: <4c34773e-31e9-927f-c593-30bbe3b75fd7@intel.com> Date: Wed, 1 Mar 2023 15:39:20 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH RFC v8 00/56] Add AMD Secure Nested Paging (SEV-SNP) Hypervisor Support Content-Language: en-US To: Zhi Wang Cc: Michael Roth , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com References: <20230220183847.59159-1-michael.roth@amd.com> <20230302005943.00001a8e@intel.com> From: Dave Hansen In-Reply-To: <20230302005943.00001a8e@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 4ye4n6u4eqdr9trsu8ftb13pbogbxu6g X-Rspam-User: X-Rspamd-Queue-Id: B194B1C000A X-Rspamd-Server: rspam06 X-HE-Tag: 1677713968-877076 X-HE-Meta: U2FsdGVkX1+3YSt25jvliZg9/BjJJapnoAuZN7HuDFZYPzImsufrQMoVV2hIL5E0Z3Bhgv9q9u1X4mOHJ0EDBoy1dqWAFKs+3lcUU2Yi9Xxu/FcVM//ugqKINEEJKi2C0++BSmwL+7KLzWOuo26FciQDGE7ftHuwwKlGn4f2QYPFKYKt4Dc538Wlcca1X0N5lVaYL3M7FXgVcISH8oPPt3s17fqUOhQP48azTNfMoIqoyenkwHyOeSxcXaGUlP3mvohtq+zZtSPMX3TAFnXWo8EKgXBmGBEOwJ9fkFGy0I6Ck2PzoCNSAzYfpkOk6xcE5o+Z5dxtJ40AISgeIgWkF9gTOnAIHWwz78kc+2BAtkgjw/YWoeYlfLYhjh9iFm13H0/L91xGY2rHmcXTvCZl5E/PKcatJSMIpXj3yO8wNRBj/QgDPIs7JH7P7gHzn++fSy23F4Xh7ISzkovPukJ3xlbtsEt46PXhf/fknCIcvvnI7TIcjio12/ONB1nm6UoEbnwQL+wjYKCvgE7sG6JYD6Z3a/J4ATuNS3wsy6KQEnkIDwNw7uHezl57SIcWZ4P5oggs55W2ablzGQMy/KwUNqdf3kiPsH9hf3KxZ+NhhMwE0BbQSCyZ/YtOcQ6a+bLpCxe1kX+5J2WQMHBqhB/CIOjVV/TR/6USR6KUyW3jSvvNsrZGYGVAndYnUHUvDe1hBT+wnE7oRkNBTn2jelL0wGOYYh1bM3BYpHX3NmixxJukf+sgMMRlYB26kAGLzT05lrdRQ++MCcuenOKdBGFu8Jf/drIz3Sz/EjK7r4LmdzllctCef1Xwxv9AirQRnJ9jckEPScckTUHw3DLMbByb+q0VENBR913Zs1UTtEGjclymgH/8R5uMesPV6L8a3h/iWTJmTrQLlu+nFD5YOhYm6qriHdExDUGex4BXpNrTb+l86ZiwzysT7r/hnhI6pR932R4b5p8MKz+5KsTX2u9 ry61knvj XmxoW9uhlY4MltL6u/cj/ZY2p1HEX3glqwHn1pXvjOkOevh1HWl2gttIJbQzPRLZpasATLUfrX/Icp/zxqGEbUj/H/yaxvwOH29tkSDmcR7qNKaBwdUsjEYJJmYFD8wOcUiIUjX1Mx3KYxKBG6XRney+4xiZtEUC3tX/lClAbhrNcFqP1zu2ApKAuXgLRZ3lb/n3+kEuFFtaoZr5WvMti05rx9SQlXpimPosimcfYNl2Ypmc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/1/23 14:59, Zhi Wang wrote: > When the userspace sets the memory attribute of a GFN range through the > restricted memory ioctl, the sev logic (sev_update_mem_attr() in PATCH 48, to > be precise) will try to build a large page description in the RMP table if the > PFNs are continuous. When kernel mm breaks the the large page due to THP, KVM > updates the NPT accordingly. Gah, this really confused me. It's *NOT* looking for contiguous PFNs. It's looking for a restrictedmem THP, which really is something different. Restrictedmem THPs have contiguous PFNs, but not all contiguous PFNs will result in trying to build a large page. Anyway, I'll reply over to the other patch. But, either way, I'd appreciate this kind of summary in the changelogs and probably a comment or two: The RMP needs to be consistent with the contents of the NPT. KVM updates the NPT but will neglect to update the RMP. It is updated in response to faults when RMP and NPT get out of sync. Right? BTW, why doesn't KVM just update the RMP? Why bother taking the fault?