From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 198D1C07E94 for ; Fri, 4 Jun 2021 11:11:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A62EB613FF for ; Fri, 4 Jun 2021 11:11:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A62EB613FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0C31F6B0036; Fri, 4 Jun 2021 07:11:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 073756B006C; Fri, 4 Jun 2021 07:11:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E55976B006E; Fri, 4 Jun 2021 07:11:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id B5FAE6B0036 for ; Fri, 4 Jun 2021 07:11:52 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4DABB181AEF00 for ; Fri, 4 Jun 2021 11:11:52 +0000 (UTC) X-FDA: 78215776464.01.DB83B74 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf23.hostedemail.com (Postfix) with ESMTP id D0EC0A0049CF for ; Fri, 4 Jun 2021 11:11:33 +0000 (UTC) Received: by mail-ej1-f54.google.com with SMTP id c10so13847046eja.11 for ; Fri, 04 Jun 2021 04:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=BQUG9rLBagDE3J7LSSE86X2TmT7SF5szEvUlFFOgXJw=; b=AKZLZ9RcuNFtFpU2HlORqN+F0aDDdPOWEF0LmofzDUBzJVQxFuF03Iopw5UfbJo6wj dCrODKC6J9QggYjr4fn+5Awk3p7KTQYHQBkcLM1VihBqGR1yRXvQVP6e7d/xU54vcYkB Kf1up2JPH+87j0n8Tibjo70vosVzALe5dWICqux0nf6Aezw7orz+x73+DWy4ZrWUyOCY 2vqQRKvQrlthlG6farlgGqrDkOtJxzsyNp/+xeB8Q8yPAIHC0ZxoJzB//UvhLDZvn3ed lVZTcZaSQsWE9rpJ6UmFkZlzCo+di9rjRRMIkkDoIPzI7iQevgYFl5uiNOHowCKBgpQg Ng7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=BQUG9rLBagDE3J7LSSE86X2TmT7SF5szEvUlFFOgXJw=; b=Oc/SwoUv89y2vmf+81/PGH/cQ2uMmKkYqwQmxMnqgCsQWeep3ZDXDuZ5C6pfOlCQMq rXjHJn+cYsphDjiOlPnlOR1MYqnD0YUOxbGuXpT2zH9x9mhrsw1gKdyzCl5Mzn4nXyha XM7AEJ0gZb0RK03ZS0YjHwuvnzUEZkjW5UuD6P2S+D/VX8TDf4AmO/hOqa9W7MmTRPGI U7zKDbaaxJreSm/GeVTYVpIDhjYAeuRofyw8ix5jaQF6D5E/Th3OVELC0GRlGiRAgava j/ve1y0YK6SQhF+zwCoE8nmc41AmMAVUHS9ociap/JP3gqkZVNph2vr+mD/5JfATdxQ4 5zaw== X-Gm-Message-State: AOAM532e31EjVEx+7HPsTsa7g1tB0RQNlULtAmw0Wuy8jIqUVFrUoxnZ 4xZt8KEtKnFG7o/om/rdlqY= X-Google-Smtp-Source: ABdhPJxwOi2L/qa3p1KrMVaJKXxi1zF8E7uZF06kEzz3kjvluKA7vA7S+LWJ1SpnGlbw7LFo89zKHg== X-Received: by 2002:a17:906:5f93:: with SMTP id a19mr3677884eju.18.1622805098334; Fri, 04 Jun 2021 04:11:38 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:7b4b:873a:17b5:b581? ([2a02:908:1252:fb60:7b4b:873a:17b5:b581]) by smtp.gmail.com with ESMTPSA id dy19sm3062992edb.68.2021.06.04.04.11.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jun 2021 04:11:37 -0700 (PDT) Subject: Re: [PATCH] drm/amdgpu: Use vma_lookup() in amdgpu_ttm_tt_get_user_pages() To: Liam Howlett , Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" Cc: David Airlie , Daniel Vetter References: <20210603160928.3854180-1-Liam.Howlett@Oracle.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <4d2e62c7-af4c-b977-a05c-97b664b532b3@gmail.com> Date: Fri, 4 Jun 2021 13:11:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210603160928.3854180-1-Liam.Howlett@Oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Stat-Signature: m8twhajpwgxc6ykwbpgsot94scp6xpp8 X-Rspamd-Queue-Id: D0EC0A0049CF X-Rspamd-Server: rspam02 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=AKZLZ9Rc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of ckoenigleichtzumerken@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=ckoenigleichtzumerken@gmail.com X-HE-Tag: 1622805093-520707 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Am 03.06.21 um 18:09 schrieb Liam Howlett: > Use vma_lookup() to find the VMA at a specific address. As vma_lookup(= ) > will return NULL if the address is not within any VMA, the start addres= s > no longer needs to be validated. > > Signed-off-by: Liam R. Howlett Reviewed-by: Christian K=C3=B6nig > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/= amd/amdgpu/amdgpu_ttm.c > index 7cb7ffdd1900..dfb5ca3f8da8 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > @@ -680,9 +680,9 @@ int amdgpu_ttm_tt_get_user_pages(struct amdgpu_bo *= bo, struct page **pages) > return -ESRCH; > =20 > mmap_read_lock(mm); > - vma =3D find_vma(mm, start); > + vma =3D vma_lookup(mm, start); > mmap_read_unlock(mm); > - if (unlikely(!vma || start < vma->vm_start)) { > + if (unlikely(!vma)) { > r =3D -EFAULT; > goto out_putmm; > }