From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D282EC4BA0E for ; Wed, 26 Feb 2020 08:26:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 886A321556 for ; Wed, 26 Feb 2020 08:26:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (4096-bit key) header.d=d-silva.org header.i=@d-silva.org header.b="DPOwD4us" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 886A321556 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=d-silva.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 141786B0003; Wed, 26 Feb 2020 03:26:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F2596B0005; Wed, 26 Feb 2020 03:26:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFCE96B0006; Wed, 26 Feb 2020 03:26:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0205.hostedemail.com [216.40.44.205]) by kanga.kvack.org (Postfix) with ESMTP id D8D726B0003 for ; Wed, 26 Feb 2020 03:26:53 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B42DD8248068 for ; Wed, 26 Feb 2020 08:26:53 +0000 (UTC) X-FDA: 76531597506.07.title03_59325ba7ecb2c X-HE-Tag: title03_59325ba7ecb2c X-Filterd-Recvd-Size: 7542 Received: from ushosting.nmnhosting.com (ushosting.nmnhosting.com [66.55.73.32]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Wed, 26 Feb 2020 08:26:52 +0000 (UTC) Received: from mail2.nmnhosting.com (unknown [202.169.106.97]) by ushosting.nmnhosting.com (Postfix) with ESMTPS id 014E52DC00E4; Wed, 26 Feb 2020 19:26:46 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=d-silva.org; s=201810a; t=1582705607; bh=80fBdwbzVEqAw+uYKkj4SQtkzUXen9bXvqaTYfSOk4E=; h=From:To:Cc:References:In-Reply-To:Subject:Date:From; b=DPOwD4usPhiADwX4LI+zMnTd9uY8z9YYAZjTUDt4Pk1kBy0kYipEm2MbZ9x7pzd+S vKSVZd0g/6FbaM+mhA4ND9DXwPuLJQOARTy2MgpzzpNIoce5F2z1PoFzI9/G5x3T8a +cZZj3w+7uGbzs4eIOF7ISrc08Rs4+FdNOMQFVZUnjpvI5QS76UdyK7gUXCjtGZNct JI4Ew83JuGXQhdPeuFD3lFR68o0jsejd3QQzICIhfG/wItMM7jzvfe64YF0LQi+9Q/ 1DsKVAmOjw4iRnSL0MdsYAsvSPDCocIH8jz3iK1EBWBLA7j8XvrWkT66tjMbsrHFHc 0zpVeFUiQSU/Upu5EWV9o/y34hId+fdsj0eS1lkWMfpm//es540N4o0XAUEE6rsWUO vs4C2osTrvq2wEP8HzoapDqWJ6GslVFq4JcPH5HbSaifCbji1tF5h+hIbJUcPeeLAJ 6RpKY35T0y6KvgJkI3rVmWaZB5pYdQgCf/mvlc5YorK/OB1ATWO3r8fupn8GowdeuJ /pjGI7Hxv+CFYFUA7MyhU9j4LYYbx7H4qd+LvSY8zWvGHqW6AIT8Zrw64dsqAjpFxq G6HSY4vre1yuYynt+TqqVL9ZYyNyoX8loNaMKbnRQUjSOnte3r+TBEp4dEZAC4seWF 8ckmiALC5R6ZSO8+PgWwl8io= Received: from Hawking (ntp.lan [10.0.1.1]) (authenticated bits=0) by mail2.nmnhosting.com (8.15.2/8.15.2) with ESMTPSA id 01Q8QXFx062720 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 26 Feb 2020 19:26:34 +1100 (AEDT) (envelope-from alastair@d-silva.org) From: "Alastair D'Silva" To: "'Baoquan He'" , "'Alastair D'Silva'" Cc: "'Aneesh Kumar K . V'" , "'Oliver O'Halloran'" , "'Benjamin Herrenschmidt'" , "'Paul Mackerras'" , "'Michael Ellerman'" , "'Frederic Barrat'" , "'Andrew Donnellan'" , "'Arnd Bergmann'" , "'Greg Kroah-Hartman'" , "'Dan Williams'" , "'Vishal Verma'" , "'Dave Jiang'" , "'Ira Weiny'" , "'Andrew Morton'" , "'Mauro Carvalho Chehab'" , "'David S. Miller'" , "'Rob Herring'" , "'Anton Blanchard'" , "'Krzysztof Kozlowski'" , "'Mahesh Salgaonkar'" , "'Madhavan Srinivasan'" , "=?iso-8859-1?Q?'C=E9dric_Le_Goater'?=" , "'Anju T Sudhakar'" , "'Hari Bathini'" , "'Thomas Gleixner'" , "'Greg Kurz'" , "'Nicholas Piggin'" , "'Masahiro Yamada'" , "'Alexey Kardashevskiy'" , , , , References: <20200221032720.33893-1-alastair@au1.ibm.com> <20200221032720.33893-5-alastair@au1.ibm.com> <20200226081447.GH4937@MiWiFi-R3L-srv> In-Reply-To: <20200226081447.GH4937@MiWiFi-R3L-srv> Subject: RE: [PATCH v3 04/27] ocxl: Remove unnecessary externs Date: Wed, 26 Feb 2020 19:26:34 +1100 Message-ID: <4d49801d5ec7e$7a3e8610$6ebb9230$@d-silva.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFvwBELB7thA+Ae3jvxFm54+bhaEQJqYraXAhSTffeo1YSXcA== Content-Language: en-au X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail2.nmnhosting.com [10.0.1.20]); Wed, 26 Feb 2020 19:26:42 +1100 (AEDT) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > -----Original Message----- > From: Baoquan He > Sent: Wednesday, 26 February 2020 7:15 PM > To: Alastair D'Silva > Cc: alastair@d-silva.org; Aneesh Kumar K . V > ; Oliver O'Halloran ; > Benjamin Herrenschmidt ; Paul Mackerras > ; Michael Ellerman ; Frederic > Barrat ; Andrew Donnellan ; > Arnd Bergmann ; Greg Kroah-Hartman > ; Dan Williams ; > Vishal Verma ; Dave Jiang > ; Ira Weiny ; Andrew Morton > ; Mauro Carvalho Chehab > ; David S. Miller ; > Rob Herring ; Anton Blanchard ; > Krzysztof Kozlowski ; Mahesh Salgaonkar > ; Madhavan Srinivasan > ; C=E9dric Le Goater ; Anju T > Sudhakar ; Hari Bathini > ; Thomas Gleixner ; Greg > Kurz ; Nicholas Piggin ; Masahiro > Yamada ; Alexey Kardashevskiy > ; linux-kernel@vger.kernel.org; linuxppc- > dev@lists.ozlabs.org; linux-nvdimm@lists.01.org; linux-mm@kvack.org > Subject: Re: [PATCH v3 04/27] ocxl: Remove unnecessary externs >=20 > On 02/21/20 at 02:26pm, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > > Function declarations don't need externs, remove the existing ones = so > > they are consistent with newer code > > > > Signed-off-by: Alastair D'Silva > > --- > > arch/powerpc/include/asm/pnv-ocxl.h | 32 = ++++++++++++++--------------- > > include/misc/ocxl.h | 6 +++--- > > 2 files changed, 18 insertions(+), 20 deletions(-) > > > > diff --git a/arch/powerpc/include/asm/pnv-ocxl.h > > b/arch/powerpc/include/asm/pnv-ocxl.h > > index 0b2a6707e555..b23c99bc0c84 100644 > > --- a/arch/powerpc/include/asm/pnv-ocxl.h > > +++ b/arch/powerpc/include/asm/pnv-ocxl.h > > @@ -9,29 +9,27 @@ > > #define PNV_OCXL_TL_BITS_PER_RATE 4 > > #define PNV_OCXL_TL_RATE_BUF_SIZE > ((PNV_OCXL_TL_MAX_TEMPLATE+1) * PNV_OCXL_TL_BITS_PER_RATE / 8) > > > > -extern int pnv_ocxl_get_actag(struct pci_dev *dev, u16 *base, u16 > *enabled, > > - u16 *supported); >=20 > It works w or w/o extern when declare functions. Searching 'extern' > under include can find so many functions with 'extern' adding. Do we = have a > explicit standard if we should add or remove 'exter' in function declaration? >=20 > I have no objection to this patch, just want to make clear so that I = can handle > it w/o confusion. >=20 > Thanks > Baoquan >=20 For the OpenCAPI driver, we have settled on not having 'extern' on functions. I don't think I've seen a standard that supports or refutes this, but it does not value add. --=20 Alastair D'Silva mob: 0423 762 819 skype: alastair_dsilva msn: alastair@d-silva.org blog: http://alastair.d-silva.org Twitter: @EvilDeece