From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4C5DECAAD3 for ; Wed, 14 Sep 2022 17:30:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32AA08D0003; Wed, 14 Sep 2022 13:30:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D9BD8D0001; Wed, 14 Sep 2022 13:30:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17A9C8D0003; Wed, 14 Sep 2022 13:30:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 093038D0001 for ; Wed, 14 Sep 2022 13:30:52 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CA9ED1601BE for ; Wed, 14 Sep 2022 17:30:51 +0000 (UTC) X-FDA: 79911381102.02.3C53F51 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) by imf18.hostedemail.com (Postfix) with ESMTP id 791941C00A3 for ; Wed, 14 Sep 2022 17:30:51 +0000 (UTC) Received: by mail-qv1-f41.google.com with SMTP id d1so12318173qvs.0 for ; Wed, 14 Sep 2022 10:30:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=0L27G4iP/cuKuBXoxBJrd9C7v+AkXXve2e5WgZmnPFM=; b=OwNpFg7qm3P6LQcskO6h973FuZ5ZH5pqPhL9rSvFWvFDrm4IqvH2rasrZoz63gaIVM QBxwZeFlhTErfLCFnU/hBTKbTzaucoDPNVe+ec0H2jDaK8Ebhzi4iLc4B30cdh5SIP+J U/u8Q+X/XTfAqwup7cUdIYBZy2FMkUqtyZkZx1xbRc2bYhX/D4AOCAU6cAR2wn7cwBTv b/PDf4eVJsqSWzv4DCt6F0Fc7zS9N2yOjUi4GsS5Wj91RFeCQIxdy5ahy+ncakDr8iB6 Fxan9Mw9UOkoWGjPBTPYJun8O3wwAS+yMUT6j8hC6rwUjtVB9XEcsUqg/IOrwP18C5+W aNJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=0L27G4iP/cuKuBXoxBJrd9C7v+AkXXve2e5WgZmnPFM=; b=hq+IrWhiy06xdgeUlPgH6tqLIzEEEA/TluE48eiILM8I62jOf/aGZaLCq6QQRlajUX dyd6mPmvx93x9qHbNZg4puvR3ubtkMVaBYlaMalXCCLCXPxh0fjchyqbEVApdg5I3/MK 6AF3dwk33GSM5/qmLXGMjORZwE9czM5rYJdtsaJqPX3+g2x+3YnLyDp81VkMxQAag3Z+ XQ2M9pPQg9qswySYxs9My/Pz+Yujl2VMi50goEdzMC0nRboD2I4PaD1hKaAlFGD4psvi 1RSdBRofiGO4Y0yQjKITLuGCydb0UNteiap7n0zQoIRIf9jB3txYBNnXOEnVRQ9xlZ5h NxCQ== X-Gm-Message-State: ACgBeo1rXVh99lixwXvzx4H6wQ8MylRaxXv0Dw6tTmuUppisEEkL1QqG 7UMr+FqmcbiIUzkVN/xc/qw= X-Google-Smtp-Source: AA6agR4NanY+oRAKCwumuYS4qynQNlgRdXUQ9CoMAaXbiNck4dr+MBmcWBG+TscWXqo8NNLfJw1SfA== X-Received: by 2002:a05:6214:2aaa:b0:4ac:acbd:7ef8 with SMTP id js10-20020a0562142aaa00b004acacbd7ef8mr16025208qvb.126.1663176650653; Wed, 14 Sep 2022 10:30:50 -0700 (PDT) Received: from [10.69.40.226] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id x8-20020ac85388000000b0035bafecff78sm1838006qtp.74.2022.09.14.10.30.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Sep 2022 10:30:50 -0700 (PDT) Message-ID: <4d715585-413d-a506-1bc0-1f12a0aec716@gmail.com> Date: Wed, 14 Sep 2022 10:30:45 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH 02/21] mm/hugetlb: correct max_huge_pages accounting on demote Content-Language: en-US To: Mike Kravetz Cc: Andrew Morton , Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Frank Rowand , Muchun Song , Mike Rapoport , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Borislav Petkov , "Paul E. McKenney" , Neeraj Upadhyay , Randy Dunlap , Damien Le Moal , Florian Fainelli , David Hildenbrand , Zi Yan , Oscar Salvador , Hari Bathini , Kees Cook , - , KOSAKI Motohiro , Mel Gorman , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux.dev References: <20220913195508.3511038-1-opendmb@gmail.com> <20220913195508.3511038-3-opendmb@gmail.com> From: Doug Berger In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=OwNpFg7q; spf=pass (imf18.hostedemail.com: domain of opendmb@gmail.com designates 209.85.219.41 as permitted sender) smtp.mailfrom=opendmb@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663176651; a=rsa-sha256; cv=none; b=aFJ9rZL581MyKry8Db6R5F4pvpiCTdWes7tGUBgkF4xUC7rDYczyHv2mmeCHp4Cp10+u8u UJzfkAyH9TtS5kJCM3W52O/sx0jlcRg3Y0+DWTpVICHu7E52e5OxBlJ+dXAWud/imZqOLw 07NTPO/aWMzsoQav/wuqDk0AlxlUHqY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663176651; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0L27G4iP/cuKuBXoxBJrd9C7v+AkXXve2e5WgZmnPFM=; b=jnFZdsqbX1ZxGiY5GBoJLZHknkYTVpoT+nhv261Kd2Zh8SYszNwH4cPRIAfc2TnElLl+OG 1CMcCL39tmqk++a+xci/W8QiY87m+Yi/DjH78Q1ISN2+LGEI3GExqvgkGQUmCwU3iNapSI /zoQRCH/WKu/1aKVNAMjOEkcMoNpf9w= X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 791941C00A3 X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=OwNpFg7q; spf=pass (imf18.hostedemail.com: domain of opendmb@gmail.com designates 209.85.219.41 as permitted sender) smtp.mailfrom=opendmb@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: o9r4f6488hsbxjdyr8rfjdnnxotptqhk X-HE-Tag: 1663176651-243065 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/14/2022 10:23 AM, Mike Kravetz wrote: > On 09/13/22 12:54, Doug Berger wrote: >> When demoting a hugepage to a smaller order, the number of pages >> added to the target hstate will be the size of the large page >> divided by the size of the smaller page. >> >> Fixes: 8531fc6f52f5 ("hugetlb: add hugetlb demote page support") >> Signed-off-by: Doug Berger >> --- >> mm/hugetlb.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/mm/hugetlb.c b/mm/hugetlb.c >> index e070b8593b37..79949893ac12 100644 >> --- a/mm/hugetlb.c >> +++ b/mm/hugetlb.c >> @@ -3472,7 +3472,8 @@ static int demote_free_huge_page(struct hstate *h, struct page *page) >> * based on pool changes for the demoted page. >> */ >> h->max_huge_pages--; >> - target_hstate->max_huge_pages += pages_per_huge_page(h); >> + target_hstate->max_huge_pages += pages_per_huge_page(h) / >> + pages_per_huge_page(target_hstate); >> >> return rc; >> } > > This has already been fixed here, > > https://lore.kernel.org/linux-mm/20220823030209.57434-2-linmiaohe@huawei.com/ > Excellent! Thanks for the pointer and sorry for the noise. -Doug