From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD6A4C43460 for ; Tue, 6 Apr 2021 11:30:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 04D556128B for ; Tue, 6 Apr 2021 11:30:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04D556128B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=yunify.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6DBA96B007E; Tue, 6 Apr 2021 07:30:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68A896B0080; Tue, 6 Apr 2021 07:30:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52B386B0081; Tue, 6 Apr 2021 07:30:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0216.hostedemail.com [216.40.44.216]) by kanga.kvack.org (Postfix) with ESMTP id 39EC36B007E for ; Tue, 6 Apr 2021 07:30:30 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E76A2812F for ; Tue, 6 Apr 2021 11:30:29 +0000 (UTC) X-FDA: 78001724178.30.901CEFE Received: from zg8tmty1ljiyny4xntqumjca.icoremail.net (zg8tmty1ljiyny4xntqumjca.icoremail.net [165.227.154.27]) by imf18.hostedemail.com (Postfix) with SMTP id 2FE462000255 for ; Tue, 6 Apr 2021 11:30:27 +0000 (UTC) Received: from NeildeMBP.local (unknown [60.24.14.254]) by mailapp1 (Coremail) with SMTP id A7CowAA3ndhORmxgkgUAAA--.202S3; Tue, 06 Apr 2021 19:30:23 +0800 (CST) Subject: Re: [PATCH] mm/vmscan.c: drop_slab_node with task's memcg To: Michal Hocko Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1617359934-7812-1-git-send-email-neilsun@yunify.com> From: Neil Sun Message-ID: <4dba277d-e497-5c34-0e68-fd2283585de2@yunify.com> Date: Tue, 6 Apr 2021 19:30:22 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------403A99ED2AE94B9B9F6A38BA" X-CM-TRANSID:A7CowAA3ndhORmxgkgUAAA--.202S3 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUYx7k0a2IF6w4kM7kC6x804xWl14x267AK xVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AKwVWUJVWUGw A2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26ryj 6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j6r4UJwA2z4x0Y4vEx4A2jsIE14v26F 4j6r4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr1j6F4UJwAS0I0E0xvYzxvE52x082IY 62kv0487McIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4I kC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41l7480Y4vEI4kI2Ix0rVAqx4xJMxk0xIA0c2IE e2xFo4CEbIxvr21lc2xSY4AK67AK6r4kMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4 AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_JrI_JrWlx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE 17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMI IF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_WFyUJVCq 3wCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIda VFxhVjvjDU0xZFpf9x07bYNVkUUUUU= X-CM-SenderInfo: xqhlz21xq653pqli5hhfrp/1tbiAQAEClhaKtAAvQABsL X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 2FE462000255 X-Stat-Signature: 5t1i1pk859eqggtjbgj4br7y35fz4anb Received-SPF: none (yunify.com>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=zg8tmty1ljiyny4xntqumjca.icoremail.net; client-ip=165.227.154.27 X-HE-DKIM-Result: none/none X-HE-Tag: 1617708627-949647 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This is a multi-part message in MIME format. --------------403A99ED2AE94B9B9F6A38BA Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 2021/4/6 15:21, Michal Hocko wrote: > > You are changing semantic of the existing user interface. This knob has > never been memcg aware and it is supposed to have a global impact. I do > not think we can simply change that without some users being surprised > or even breaking them. Yes, do you think add new interface to sysfs is a good way? such as /sys/fs/cgroup/memory/lxc/i-vbe1u8o7/memory.kmem.drop_caches I will rewrite this patch later. --------------403A99ED2AE94B9B9F6A38BA Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
On 2021/4/6 15:21, Michal Hocko wrote:

You are changing semantic of the existing user interface. This knob has
never been memcg aware and it is supposed to have a global impact. I do
not think we can simply change that without some users being surprised
or even breaking them.

Yes, do you think add new interface to sysfs is a good way? such as 
/sys/fs/cgroup/memory/lxc/i-vbe1u8o7/memory.kmem.drop_caches

I will rewrite this patch later.
--------------403A99ED2AE94B9B9F6A38BA--