linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: linmiaohe <linmiaohe@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: mmap: Fix general protection fault in unlink_file_vma()
Date: Fri, 9 Oct 2020 06:39:04 +0000	[thread overview]
Message-ID: <4dcf86d0a9ac474c8dcb903aa6341b9f@huawei.com> (raw)

Andrew Morton <akpm@linux-foundation.org> wrote:
> On Thu, 8 Oct 2020 07:17:18 +0000 linmiaohe <linmiaohe@huawei.com> wrote:
>
>> Andrew Morton <akpm@linux-foundation.org> wrote:
>> > On Wed, 16 Sep 2020 05:07:33 -0400 Miaohe Lin <linmiaohe@huawei.com> wrote:
>> >
>> >> The syzbot reported the below general protection fault:
>>
>> >
>> >is this using the correct file?  I think it is, but please do check.
>> >
>> 
>> Many thanks for your reply.
>> 
>> Yes, I think so too. We do deny_write_access and mapping_map_writable on @file, so we should undo all of this on @file.
>> Since @file is unchanged over the second vma_merge() time, we'are using the correct @file to undo our temporary denial count.
>> 
>> But how should I check this explicitly ? I can't find out a way to do this. Could you please figure it out for me?
>
>I meant "please check (review) the code as it now is", not "please add a check" ;)
>

Oh, I see. I have reviewed the code carefully. The @file should be right one as I explained in previous email. ;)

Have a good day! ^_^



             reply	other threads:[~2020-10-09  6:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-09  6:39 linmiaohe [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-10-08  7:17 linmiaohe
2020-10-09  4:23 ` Andrew Morton
2020-10-07  2:51 linmiaohe
2020-09-16  9:07 Miaohe Lin
2020-10-07 19:04 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4dcf86d0a9ac474c8dcb903aa6341b9f@huawei.com \
    --to=linmiaohe@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --subject='Re: [PATCH] mm: mmap: Fix general protection fault in unlink_file_vma()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).