From: Arun KS <arunks@codeaurora.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: akpm@linux-foundation.org, keescook@chromium.org,
khlebnikov@yandex-team.ru, minchan@kernel.org, vbabka@suse.cz,
osalvador@suse.de, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, getarunks@gmail.com
Subject: Re: [PATCH v3 4/4] mm: Remove managed_page_count spinlock
Date: Thu, 08 Nov 2018 15:33:06 +0530 [thread overview]
Message-ID: <4e5e2923a424ab2e2c50e56b2e538a3c@codeaurora.org> (raw)
In-Reply-To: <20181108083400.GQ27423@dhcp22.suse.cz>
On 2018-11-08 14:04, Michal Hocko wrote:
> On Thu 08-11-18 13:53:18, Arun KS wrote:
>> Now totalram_pages and managed_pages are atomic varibles. No need
>> of managed_page_count spinlock.
>
> As explained earlier. Please add a motivation here. Feel free to reuse
> wording from
> http://lkml.kernel.org/r/20181107103630.GF2453@dhcp22.suse.cz
Sure. Will add in next spin.
Regards,
Arun
>
>>
>> Signed-off-by: Arun KS <arunks@codeaurora.org>
>> Reviewed-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
>> Acked-by: Michal Hocko <mhocko@suse.com>
>> Acked-by: Vlastimil Babka <vbabka@suse.cz>
>> ---
>> include/linux/mmzone.h | 6 ------
>> mm/page_alloc.c | 5 -----
>> 2 files changed, 11 deletions(-)
>>
>> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
>> index e73dc31..c71b4d9 100644
>> --- a/include/linux/mmzone.h
>> +++ b/include/linux/mmzone.h
>> @@ -428,12 +428,6 @@ struct zone {
>> * Write access to present_pages at runtime should be protected by
>> * mem_hotplug_begin/end(). Any reader who can't tolerant drift of
>> * present_pages should get_online_mems() to get a stable value.
>> - *
>> - * Read access to managed_pages should be safe because it's unsigned
>> - * long. Write access to zone->managed_pages and totalram_pages are
>> - * protected by managed_page_count_lock at runtime. Idealy only
>> - * adjust_managed_page_count() should be used instead of directly
>> - * touching zone->managed_pages and totalram_pages.
>> */
>> atomic_long_t managed_pages;
>> unsigned long spanned_pages;
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index f8b64cc..26c5e14 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -122,9 +122,6 @@
>> };
>> EXPORT_SYMBOL(node_states);
>>
>> -/* Protect totalram_pages and zone->managed_pages */
>> -static DEFINE_SPINLOCK(managed_page_count_lock);
>> -
>> atomic_long_t _totalram_pages __read_mostly;
>> EXPORT_SYMBOL(_totalram_pages);
>> unsigned long totalreserve_pages __read_mostly;
>> @@ -7065,14 +7062,12 @@ static int __init
>> cmdline_parse_movablecore(char *p)
>>
>> void adjust_managed_page_count(struct page *page, long count)
>> {
>> - spin_lock(&managed_page_count_lock);
>> atomic_long_add(count, &page_zone(page)->managed_pages);
>> totalram_pages_add(count);
>> #ifdef CONFIG_HIGHMEM
>> if (PageHighMem(page))
>> totalhigh_pages_add(count);
>> #endif
>> - spin_unlock(&managed_page_count_lock);
>> }
>> EXPORT_SYMBOL(adjust_managed_page_count);
>>
>> --
>> 1.9.1
next prev parent reply other threads:[~2018-11-08 10:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 8:23 [PATCH v3 0/4] mm: convert totalram_pages, totalhigh_pages and managed pages to atomic Arun KS
2018-11-08 8:23 ` [PATCH v3 1/4] mm: reference totalram_pages and managed_pages once per function Arun KS
2018-11-08 11:44 ` Vlastimil Babka
2018-11-09 11:33 ` kbuild test robot
2018-11-08 8:23 ` [PATCH v3 2/4] mm: convert zone->managed_pages to atomic variable Arun KS
2018-11-08 8:32 ` Michal Hocko
2018-11-08 8:23 ` [PATCH v3 3/4] mm: convert totalram_pages and totalhigh_pages variables to atomic Arun KS
2018-11-08 8:23 ` [PATCH v3 4/4] mm: Remove managed_page_count spinlock Arun KS
2018-11-08 8:34 ` Michal Hocko
2018-11-08 10:03 ` Arun KS [this message]
2018-11-08 10:14 ` Michal Hocko
2018-11-08 10:31 ` Arun KS
2018-11-09 15:42 ` Arun KS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e5e2923a424ab2e2c50e56b2e538a3c@codeaurora.org \
--to=arunks@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=getarunks@gmail.com \
--cc=keescook@chromium.org \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=osalvador@suse.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).