From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 770F9C433EF for ; Wed, 12 Jan 2022 16:42:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E41F56B01A2; Wed, 12 Jan 2022 11:42:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DF3EA6B01A3; Wed, 12 Jan 2022 11:42:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C914D6B01A4; Wed, 12 Jan 2022 11:42:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id 9F0CA6B01A2 for ; Wed, 12 Jan 2022 11:42:10 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 293C08249980 for ; Wed, 12 Jan 2022 16:42:10 +0000 (UTC) X-FDA: 79022202420.28.946AEE2 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf24.hostedemail.com (Postfix) with ESMTP id 1D79C18000B for ; Wed, 12 Jan 2022 16:42:08 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F35C12111A; Wed, 12 Jan 2022 16:42:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1642005728; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iPj77zfOxRCcPyyK297Nw8fAGEmReWAwmZRBcfRDDwI=; b=Lbem7p69GLWKSbIxnPTzAQw4r9cVFVUDjIJyfVJEhj5PIH3JLRLQSbg4qKu3AIaxAjIeEz NV4/PpwDGlgnZgjO/gmGuvYUas2cfoKiTz+xaRNofe3h6jPGpzTqn/BDtM0Ki55G22d8+8 k07G644Dmvi2BZH9IEGOiNzBIVUGD+I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1642005728; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iPj77zfOxRCcPyyK297Nw8fAGEmReWAwmZRBcfRDDwI=; b=SizK2zmP+zoXfYhgsaqQYwmKHnfGeHkTQPdKoh6MZWiBN4KZMmA8i+UNYc3s308oMqg28r XwgWtuI5gN20YOAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A419113BE6; Wed, 12 Jan 2022 16:42:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GbRIJ98E32H8TAAAMHmgww (envelope-from ); Wed, 12 Jan 2022 16:42:07 +0000 Message-ID: <4f0c30d7-fd10-84c7-4e7f-6d103e4ba9c1@suse.cz> Date: Wed, 12 Jan 2022 17:42:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH v4 20/66] mm/khugepaged: Optimize collapse_pte_mapped_thp() by using vma_lookup() Content-Language: en-US To: Liam Howlett , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Cc: Song Liu , Davidlohr Bueso , "Paul E . McKenney" , Matthew Wilcox , Laurent Dufour , David Rientjes , Axel Rasmussen , Suren Baghdasaryan , Rik van Riel , Peter Zijlstra , Michel Lespinasse , Jerome Glisse , Minchan Kim , Joel Fernandes , Rom Lemarchand References: <20211201142918.921493-1-Liam.Howlett@oracle.com> <20211201142918.921493-21-Liam.Howlett@oracle.com> From: Vlastimil Babka In-Reply-To: <20211201142918.921493-21-Liam.Howlett@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1D79C18000B X-Stat-Signature: qjbzmspjoza6rf1ecr6geckeaccwp58m Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Lbem7p69; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=SizK2zmP; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-HE-Tag: 1642005728-644173 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/1/21 15:29, Liam Howlett wrote: > From: "Liam R. Howlett" > > vma_lookup() will walk the vma tree once and not continue to look for > the next vma. Since the exact vma is checked below, this is a more > optimal way of searching. > > Signed-off-by: Liam R. Howlett Reviewed-by: Vlastimil Babka > --- > mm/khugepaged.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index e99101162f1a..0ff7d72cdd1d 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -1433,7 +1433,7 @@ static int khugepaged_add_pte_mapped_thp(struct mm_struct *mm, > void collapse_pte_mapped_thp(struct mm_struct *mm, unsigned long addr) > { > unsigned long haddr = addr & HPAGE_PMD_MASK; > - struct vm_area_struct *vma = find_vma(mm, haddr); > + struct vm_area_struct *vma = vma_lookup(mm, haddr); > struct page *hpage; > pte_t *start_pte, *pte; > pmd_t *pmd, _pmd;