From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D2FDC48BE6 for ; Wed, 16 Jun 2021 13:49:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 085176115B for ; Wed, 16 Jun 2021 13:49:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 085176115B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 550716B0036; Wed, 16 Jun 2021 09:49:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 526E06B006E; Wed, 16 Jun 2021 09:49:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A12F6B0070; Wed, 16 Jun 2021 09:49:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0180.hostedemail.com [216.40.44.180]) by kanga.kvack.org (Postfix) with ESMTP id 096776B0036 for ; Wed, 16 Jun 2021 09:49:55 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 97906180AD806 for ; Wed, 16 Jun 2021 13:49:55 +0000 (UTC) X-FDA: 78259720350.01.E2330FF Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf29.hostedemail.com (Postfix) with ESMTP id 4B322548 for ; Wed, 16 Jun 2021 13:49:41 +0000 (UTC) Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6289A1FD49; Wed, 16 Jun 2021 13:49:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1623851393; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zyV7Qx7wh9zu7NvPyslSVw3kJsSh12fcA7ebS8+fIW0=; b=EebTScugzf/2TP08Yce0VYq/3+Tpl7e8a/rDNvL7nyo4yDAzkdflcc8bJKS2nYH3FgvPHm Oq8GfJsFCBJcREjagBBM6NZVHZwx30nvxqCWOEn8Y9MWRQYxruxPN1BnhchZLaIy9tMZ5O SYD6OA/2f7EdkoxgJYKKlqEia4miQHc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1623851393; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zyV7Qx7wh9zu7NvPyslSVw3kJsSh12fcA7ebS8+fIW0=; b=LXGgKptvmrDMQqEcdEbT2tj71DdgP+MY8MFL/yw5UEj1/rYiO4OjeqLz7QrSUbfFfACOne aIqpVVC8mt4JSyAA== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id 37094118DD; Wed, 16 Jun 2021 13:49:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1623851393; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zyV7Qx7wh9zu7NvPyslSVw3kJsSh12fcA7ebS8+fIW0=; b=EebTScugzf/2TP08Yce0VYq/3+Tpl7e8a/rDNvL7nyo4yDAzkdflcc8bJKS2nYH3FgvPHm Oq8GfJsFCBJcREjagBBM6NZVHZwx30nvxqCWOEn8Y9MWRQYxruxPN1BnhchZLaIy9tMZ5O SYD6OA/2f7EdkoxgJYKKlqEia4miQHc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1623851393; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zyV7Qx7wh9zu7NvPyslSVw3kJsSh12fcA7ebS8+fIW0=; b=LXGgKptvmrDMQqEcdEbT2tj71DdgP+MY8MFL/yw5UEj1/rYiO4OjeqLz7QrSUbfFfACOne aIqpVVC8mt4JSyAA== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id QlTtDIEBymAWRgAALh3uQQ (envelope-from ); Wed, 16 Jun 2021 13:49:53 +0000 To: "Chu,Kaiping" , "mcgrof@kernel.org" , "keescook@chromium.org" , "yzaikin@google.com" , "akpm@linux-foundation.org" , "nigupta@nvidia.com" , "bhe@redhat.com" , "khalid.aziz@oracle.com" , "iamjoonsoo.kim@lge.com" , "mateusznosek0@gmail.com" , "sh_def@163.com" , Charan Teja Kalla , David Rientjes Cc: "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" References: <1619576901-9531-1-git-send-email-chukaiping@baidu.com> From: Vlastimil Babka Subject: =?UTF-8?B?UmU6IOetlOWkjTogW1BBVENIIHY0XSBtbS9jb21wYWN0aW9uOiBsZXQg?= =?UTF-8?Q?proactive_compaction_order_configurable?= Message-ID: <5007cc13-334b-bd73-857f-8e57c6e2397e@suse.cz> Date: Wed, 16 Jun 2021 15:49:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=EebTScug; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=LXGgKptv; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=EebTScug; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=LXGgKptv; spf=pass (imf29.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4B322548 X-Stat-Signature: kyrmftpo3iwjqynfquobg68c5dt6hq44 X-HE-Tag: 1623851381-729317 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/1/21 3:15 AM, Chu,Kaiping wrote: >=20 >=20 >> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >> =E5=8F=91=E4=BB=B6=E4=BA=BA: Vlastimil Babka >> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B45=E6=9C=8829=E6=97=A5= 1:42 >> =E6=94=B6=E4=BB=B6=E4=BA=BA: Chu,Kaiping ; mcgro= f@kernel.org; >> keescook@chromium.org; yzaikin@google.com; akpm@linux-foundation.org; >> nigupta@nvidia.com; bhe@redhat.com; khalid.aziz@oracle.com; >> iamjoonsoo.kim@lge.com; mateusznosek0@gmail.com; sh_def@163.com >> =E6=8A=84=E9=80=81: linux-kernel@vger.kernel.org; linux-fsdevel@vger.k= ernel.org; >> linux-mm@kvack.org >> =E4=B8=BB=E9=A2=98: Re: [PATCH v4] mm/compaction: let proactive compac= tion order >> configurable >>=20 >> On 4/28/21 4:28 AM, chukaiping wrote: >> > Currently the proactive compaction order is fixed to >> > COMPACTION_HPAGE_ORDER(9), it's OK in most machines with lots of >> > normal 4KB memory, but it's too high for the machines with small >> > normal memory, for example the machines with most memory configured = as >> > 1GB hugetlbfs huge pages. In these machines the max order of free >> > pages is often below 9, and it's always below 9 even with hard >> > compaction. This will lead to proactive compaction be triggered very >> > frequently. >>=20 >> Could you be more concrete about "very frequently"? There's a >> proactive_defer mechanism that should help here. Normally the proactiv= e >> compaction attempt happens each 500ms, but if it fails to improve the >> fragmentation score, it defers for 32 seconds. So is 32 seconds still = too >> frequent? Or the score does improve thus defer doesn't happen, but the= cost >> of that improvement is too high compared to the amount of the >> improvement? > I didn't measure the frequency accurately, I only judge it from code. T= he defer of 32 seconds is still very short to us, we want the proactive c= ompaction running period to be hours. Hours sounds like a lot, and maybe something that would indeed be easier = to accomplies with userspace proactive compaction triggering [1] than any ca= refully tuned thresholds. But with that low frequency, doesn't the kswapd+kcompactd non-proactive compaction actually happen more frequently? That one should react to the = order that the allocation waking up kswapd requested, AFAIK. [1] https://lore.kernel.org/linux-doc/cover.1622454385.git.charante@codea= urora.org/ >=20 >>=20 >> > In these machines we only care about order of 3 or 4. >> > This patch export the oder to proc and let it configurable by user, >> > and the default value is still COMPACTION_HPAGE_ORDER. >> > >> > Signed-off-by: chukaiping >> > Reported-by: kernel test robot >> > --- >> > >> > Changes in v4: >> > - change the sysctl file name to proactive_compation_order >> > >> > Changes in v3: >> > - change the min value of compaction_order to 1 because the >> fragmentation >> > index of order 0 is always 0 >> > - move the definition of max_buddy_zone into #ifdef >> > CONFIG_COMPACTION >> > >> > Changes in v2: >> > - fix the compile error in ia64 and powerpc, move the initializa= tion >> > of sysctl_compaction_order to kcompactd_init because >> > COMPACTION_HPAGE_ORDER is a variable in these architectures >> > - change the hard coded max order number from 10 to MAX_ORDER - = 1 >> > >> > include/linux/compaction.h | 1 + >> > kernel/sysctl.c | 10 ++++++++++ >> > mm/compaction.c | 12 ++++++++---- >> > 3 files changed, 19 insertions(+), 4 deletions(-) >> > >> > diff --git a/include/linux/compaction.h b/include/linux/compaction.h >> > index ed4070e..a0226b1 100644 >> > --- a/include/linux/compaction.h >> > +++ b/include/linux/compaction.h >> > @@ -83,6 +83,7 @@ static inline unsigned long compact_gap(unsigned i= nt >> > order) #ifdef CONFIG_COMPACTION extern int sysctl_compact_memory; >> > extern unsigned int sysctl_compaction_proactiveness; >> > +extern unsigned int sysctl_proactive_compaction_order; >> > extern int sysctl_compaction_handler(struct ctl_table *table, int w= rite, >> > void *buffer, size_t *length, loff_t *ppos); extern int >> > sysctl_extfrag_threshold; diff --git a/kernel/sysctl.c >> > b/kernel/sysctl.c index 62fbd09..ed9012e 100644 >> > --- a/kernel/sysctl.c >> > +++ b/kernel/sysctl.c >> > @@ -196,6 +196,7 @@ enum sysctl_writes_mode { #endif /* >> > CONFIG_SCHED_DEBUG */ >> > >> > #ifdef CONFIG_COMPACTION >> > +static int max_buddy_zone =3D MAX_ORDER - 1; >> > static int min_extfrag_threshold; >> > static int max_extfrag_threshold =3D 1000; #endif @@ -2871,6 +2872= ,15 >> > @@ int proc_do_static_key(struct ctl_table *table, int write, >> > .extra2 =3D &one_hundred, >> > }, >> > { >> > + .procname =3D "proactive_compation_order", >> > + .data =3D &sysctl_proactive_compaction_order, >> > + .maxlen =3D sizeof(sysctl_proactive_compaction_order), >> > + .mode =3D 0644, >> > + .proc_handler =3D proc_dointvec_minmax, >> > + .extra1 =3D SYSCTL_ONE, >> > + .extra2 =3D &max_buddy_zone, >> > + }, >> > + { >> > .procname =3D "extfrag_threshold", >> > .data =3D &sysctl_extfrag_threshold, >> > .maxlen =3D sizeof(int), >> > diff --git a/mm/compaction.c b/mm/compaction.c index e04f447..171436= e >> > 100644 >> > --- a/mm/compaction.c >> > +++ b/mm/compaction.c >> > @@ -1925,17 +1925,18 @@ static bool kswapd_is_running(pg_data_t >> > *pgdat) >> > >> > /* >> > * A zone's fragmentation score is the external fragmentation wrt t= o >> > the >> > - * COMPACTION_HPAGE_ORDER. It returns a value in the range [0, 100]= . >> > + * sysctl_proactive_compaction_order. It returns a value in the ran= ge >> > + * [0, 100]. >> > */ >> > static unsigned int fragmentation_score_zone(struct zone *zone) { >> > - return extfrag_for_order(zone, COMPACTION_HPAGE_ORDER); >> > + return extfrag_for_order(zone, sysctl_proactive_compaction_order); >> > } >> > >> > /* >> > * A weighted zone's fragmentation score is the external >> > fragmentation >> > - * wrt to the COMPACTION_HPAGE_ORDER scaled by the zone's size. It >> > - * returns a value in the range [0, 100]. >> > + * wrt to the sysctl_proactive_compaction_order scaled by the zone'= s size. >> > + * It returns a value in the range [0, 100]. >> > * >> > * The scaling factor ensures that proactive compaction focuses on = larger >> > * zones like ZONE_NORMAL, rather than smaller, specialized zones >> > like @@ -2666,6 +2667,7 @@ static void compact_nodes(void) >> > * background. It takes values in the range [0, 100]. >> > */ >> > unsigned int __read_mostly sysctl_compaction_proactiveness =3D 20; >> > +unsigned int __read_mostly sysctl_proactive_compaction_order; >> > >> > /* >> > * This is the entry point for compacting all nodes via @@ -2958,6 >> > +2960,8 @@ static int __init kcompactd_init(void) >> > int nid; >> > int ret; >> > >> > + sysctl_proactive_compaction_order =3D COMPACTION_HPAGE_ORDER; >> > + >> > ret =3D cpuhp_setup_state_nocalls(CPUHP_AP_ONLINE_DYN, >> > "mm/compaction:online", >> > kcompactd_cpu_online, NULL); >> > >=20